From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0E95158EC for ; Wed, 24 Oct 2018 16:53:27 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2018 07:53:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,420,1534834800"; d="scan'208";a="90897287" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 24 Oct 2018 07:53:27 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Oct 2018 07:53:27 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.34]) by FMSMSX113.amr.corp.intel.com ([169.254.13.112]) with mapi id 14.03.0319.002; Wed, 24 Oct 2018 07:53:26 -0700 From: "Wiles, Keith" To: Olivier Matz CC: dpdk-dev Thread-Topic: [dpdk-dev] [RFC 02/14] net: add rte prefix to arp defines Thread-Index: AQHUa3JV8pEXE+f700S9hOGSq4h6KaUu8RWA Date: Wed, 24 Oct 2018 14:53:25 +0000 Message-ID: <4C4FCEA1-EA26-4053-8235-2ACADE2F107D@intel.com> References: <20181024081833.21432-1-olivier.matz@6wind.com> <20181024081833.21432-3-olivier.matz@6wind.com> In-Reply-To: <20181024081833.21432-3-olivier.matz@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.4.59] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC 02/14] net: add rte prefix to arp defines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 14:53:28 -0000 > On Oct 24, 2018, at 1:18 AM, Olivier Matz wrote: >=20 > Add 'RTE_' prefix to defines: > - rename ARP_HRD_ETHER as RTE_ARP_HRD_ETHER. > - rename ARP_OP_REQUEST as RTE_ARP_OP_REQUEST. > - rename ARP_OP_REPLY as RTE_ARP_OP_REPLY. > - rename ARP_OP_REVREQUEST as RTE_ARP_OP_REVREQUEST. > - rename ARP_OP_REVREPLY as RTE_ARP_OP_REVREPLY. > - rename ARP_OP_INVREQUEST as RTE_ARP_OP_INVREQUEST. > - rename ARP_OP_INVREPLY as RTE_ARP_OP_INVREPLY. >=20 > Signed-off-by: Olivier Matz Were these conflicting with external headers ? If not it maybe reasonable to keep the old defines for a release or two and= then deprecate the old ones by defining the old defines in terms of the ne= w defines. This way we can support the old ones for a while then state they= will be deprecated later. Trying to make it easier for developers to update code. What do you think Regards, Keith