From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vipin.varghese@intel.com>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 9E49D1B6A9
 for <dev@dpdk.org>; Mon, 29 Jan 2018 16:05:52 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
 by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 29 Jan 2018 07:05:51 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,431,1511856000"; d="scan'208";a="13797279"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
 by fmsmga007.fm.intel.com with ESMTP; 29 Jan 2018 07:05:50 -0800
Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Mon, 29 Jan 2018 07:05:50 -0800
Received: from bgsmsx105.gar.corp.intel.com (10.223.43.197) by
 fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Mon, 29 Jan 2018 07:05:50 -0800
Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.25]) by
 BGSMSX105.gar.corp.intel.com ([169.254.3.49]) with mapi id 14.03.0319.002;
 Mon, 29 Jan 2018 20:35:47 +0530
From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
CC: "thomas@monjalon.net" <thomas@monjalon.net>
Thread-Topic: [PATCH v3 1/4] service: move finalize to internal
Thread-Index: AQHTmPnmBb09SmULhk6w37O0pohaXaOK8uFg
Date: Mon, 29 Jan 2018 15:05:46 +0000
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D191D54@BGSMSX101.gar.corp.intel.com>
References: <1517222751-110376-1-git-send-email-harry.van.haaren@intel.com>
 <1517227695-146913-1-git-send-email-harry.van.haaren@intel.com>
In-Reply-To: <1517227695-146913-1-git-send-email-harry.van.haaren@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_NT
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjNjN2VlM2EtN2YyZS00YjZmLWFkYzMtMTUwYzU5NTJhODc1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJsUFwvclVKaUZRM2pqRlJwT1Vhbnk5aG9vK2xLNkU3dVdrMUJZaTllQUoxZis2aEs4XC9uTURCWlViN2hab0YrNXkifQ==
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [10.223.10.10]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3 1/4] service: move finalize to internal
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jan 2018 15:05:53 -0000

Moving the function as internal is ok with me.

Acked-by: Vipin Varghese <vipin.varghese@intel.com>

> -----Original Message-----
> From: Van Haaren, Harry
> Sent: Monday, January 29, 2018 5:38 PM
> To: dev@dpdk.org
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; thomas@monjalon.net;
> Varghese, Vipin <vipin.varghese@intel.com>
> Subject: [PATCH v3 1/4] service: move finalize to internal
>=20
> This commit moves the rte_service_finalize() function to be in the compon=
ent
> header, and marks it as @internal.
> The function is only called internally by rte_eal_finalize().
>=20
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
>=20
> ---
>=20
> Cc: thomas@monjalon.net
> Cc: vipin.varghese@intel.com
> ---
>  lib/librte_eal/common/include/rte_service.h           | 11 -----------
>  lib/librte_eal/common/include/rte_service_component.h | 11 +++++++++++
>  2 files changed, 11 insertions(+), 11 deletions(-)
>=20
> diff --git a/lib/librte_eal/common/include/rte_service.h
> b/lib/librte_eal/common/include/rte_service.h
> index 5e3e3a6..02b1512 100644
> --- a/lib/librte_eal/common/include/rte_service.h
> +++ b/lib/librte_eal/common/include/rte_service.h
> @@ -429,17 +429,6 @@ int32_t rte_service_attr_get(uint32_t id, uint32_t
> attr_id,
>   */
>  int32_t rte_service_attr_reset_all(uint32_t id);
>=20
> -/**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice
> - *
> - * Free up the memory that has been initialized. This routine
> - * is to be invoked prior to process termination.
> - *
> - * @retval None
> - */
> -void rte_service_finalize(void);
> -
>  #ifdef __cplusplus
>  }
>  #endif
> diff --git a/lib/librte_eal/common/include/rte_service_component.h
> b/lib/librte_eal/common/include/rte_service_component.h
> index 849c71d..f881ac0 100644
> --- a/lib/librte_eal/common/include/rte_service_component.h
> +++ b/lib/librte_eal/common/include/rte_service_component.h
> @@ -139,4 +139,15 @@ int32_t rte_service_component_runstate_set(uint32_t
> id, uint32_t runstate);
>   */
>  int32_t rte_service_init(void);
>=20
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> + * @internal Free up the memory that has been initialized.
> + * This routine is to be invoked prior to process termination.
> + *
> + * @retval None
> + */
> +void rte_service_finalize(void);
> +
>  #endif /* _RTE_SERVICE_PRIVATE_H_ */
> --
> 2.7.4