From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 65BBF1B960; Mon, 29 Jan 2018 17:14:54 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2018 08:14:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,431,1511856000"; d="scan'208";a="27194647" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 29 Jan 2018 08:14:51 -0800 Received: from bgsmsx103.gar.corp.intel.com (10.223.4.130) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 29 Jan 2018 08:14:51 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.25]) by BGSMSX103.gar.corp.intel.com ([169.254.4.154]) with mapi id 14.03.0319.002; Mon, 29 Jan 2018 21:44:49 +0530 From: "Varghese, Vipin" To: "Kovacevic, Marko" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "stable@dpdk.org" Thread-Topic: [PATCH v1] mk: support building with renamed makefile Thread-Index: AQHTk3AaxedEk9kA5UOWvnJaPWNyr6OLEVaw Date: Mon, 29 Jan 2018 16:14:48 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D191E4C@BGSMSX101.gar.corp.intel.com> References: <20180122105905.6996-1-marko.kovacevic@intel.com> In-Reply-To: <20180122105905.6996-1-marko.kovacevic@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmRjMDY0OWUtZjUxYS00Yzg5LTg1YjUtOTQ3NjAyNzEyMmI1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiIwMk1iZW1BRTFTOEgrSUxFeUt1WTdBcTlHTVh5STVNWVQ5U3VnUWdPOVJCTVdHM0YycVNTTXpUOUk2V1BTaGY1In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] mk: support building with renamed makefile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 16:14:55 -0000 > -----Original Message----- > From: Kovacevic, Marko > Sent: Monday, January 22, 2018 4:29 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; Varghese, Vipin ; > Kovacevic, Marko ; stable@dpdk.org > Subject: [PATCH v1] mk: support building with renamed makefile >=20 > The build system made a recursive call to "make" after creating the build > directory. This recursive call used the hard-coded filename "Makefile", w= hich > prevented builds from working if the file was renamed and make called usi= ng > "make -f". Taking the filename from MAKEFILES_LIST make variable fixes th= is. >=20 > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org >=20 > Signed-off-by: Marko Kovacevic > --- > mk/internal/rte.extvars.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk inde= x > 94f27e9..19594da 100644 > --- a/mk/internal/rte.extvars.mk > +++ b/mk/internal/rte.extvars.mk > @@ -20,7 +20,7 @@ ifeq ("$(origin M)", "command line") RTE_EXTMK :=3D > $(abspath $(M)) endif endif -RTE_EXTMK ?=3D $(RTE_SRCDIR)/Makefile > +RTE_EXTMK ?=3D $(RTE_SRCDIR)/$(firstword $(MAKEFILE_LIST)) > export RTE_EXTMK >=20 > # RTE_SDK_BIN must point to .config, include/ and lib/. > -- > 2.9.5 I have validated on Linux environment with custom make file name as 'Makefi= le.test'. Acked-by: Vipin Varghese