From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 3EAD01B685 for ; Mon, 5 Feb 2018 19:14:04 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2018 10:14:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,465,1511856000"; d="scan'208";a="15171451" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 05 Feb 2018 10:14:01 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 5 Feb 2018 10:14:00 -0800 Received: from BGSMSX108.gar.corp.intel.com (10.223.4.192) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 5 Feb 2018 10:14:00 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.25]) by BGSMSX108.gar.corp.intel.com ([169.254.8.123]) with mapi id 14.03.0319.002; Mon, 5 Feb 2018 23:43:57 +0530 From: "Varghese, Vipin" To: "Varghese, Vipin" , Pascal Mazon , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Jain, Deepak K" Thread-Topic: [dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as args Thread-Index: AQHTnppGpdhOxhSARUy+OJohsXpNW6OWG8XQ Date: Mon, 5 Feb 2018 18:13:56 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D194FB2@BGSMSX101.gar.corp.intel.com> References: <1517422961-21284-1-git-send-email-vipin.varghese@intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D194E83@BGSMSX101.gar.corp.intel.com> In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D194E83@BGSMSX101.gar.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2I4MWMwMDUtZWJlOC00YjI3LTljNDktYjkyNTdhNDFiOGZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJcL0RtbFBTMTlDa2Jjbk1pd3hRcEdveG9zeHRYbkJicU9ocGgyczE0VXl5ektRSG1aVnBVRncrZGd5QU1IOGFscSJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 18:14:04 -0000 Hi Pascal, Please find my observation inline > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Varghese, Vipin > Sent: Monday, February 5, 2018 3:59 PM > To: Pascal Mazon ; dev@dpdk.org > Cc: Yigit, Ferruh ; Jain, Deepak K > > Subject: Re: [dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed a= s args >=20 > Hi Pascal, >=20 > Thanks for the update, I see your point instead of mixing up with int32_t= and > uint64_t; converting to ' struct ether_addr' makes sense. >=20 > I will check internally and thanks once again for the suggestion. >=20 > Thanks > Vipin Varghese >=20 > > -----Original Message----- > > From: Pascal Mazon [mailto:pascal.mazon@6wind.com] > > Sent: Monday, February 5, 2018 3:55 PM > > To: dev@dpdk.org; Varghese, Vipin > > Cc: Yigit, Ferruh ; Jain, Deepak K > > ; Pascal Mazon > > Subject: [PATCH v2] net/tap: allow user MAC to be passed as args > > > > From: Vipin Varghese > > > > Allow TAP PMD to pass user desired MAC address as argument. > > The argument value is processed as string, where each 2 bytes are > > converted to HEX MAC address after validation. > > > > Signed-off-by: Vipin Varghese > > Signed-off-by: Pascal Mazon > > --- > > > > Hi Vipin, > > > > I suggest the following patch for your MAC address argument, if that su= its you. > > I removed ETH_TAP_MAC_STR_FXD and ETH_TAP_MAC_STR_USR that were > not > > really useful. I find it nicer to deal with MAC mostly inside set_mac_t= ype(). > > What do you think? Can you test that it fits your needs? > > > > Best regards, > > Pascal > > > > doc/guides/nics/tap.rst | 6 ++++ > > drivers/net/tap/rte_eth_tap.c | 80 > > +++++++++++++++++++++++++++++----------- > > --- > > 2 files changed, 60 insertions(+), 26 deletions(-) > > > > diff --git a/doc/guides/nics/tap.rst b/doc/guides/nics/tap.rst index > > dc6f834ca0a1..6b083c846b21 100644 > > --- a/doc/guides/nics/tap.rst > > +++ b/doc/guides/nics/tap.rst > > + > > + while ((mac_byte !=3D NULL) && > > + strspn(mac_byte, ETH_TAP_CMP_MAC_FMT) && Added ' strspn(mac_byte + 1, ETH_TAP_CMP_MAC_FMT) &&'; because 2 character = validation was not taking place > > > > /* Open a TAP interface device. > > @@ -1594,7 +1622,7 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev) > > int speed; > > char tap_name[RTE_ETH_NAME_MAX_LEN]; > > char remote_iface[RTE_ETH_NAME_MAX_LEN]; > > - int fixed_mac_type =3D 0; > > + struct ether_addr user_mac =3D {0}; Changed to ' struct ether_addr user_mac =3D { .addr_bytes=3D{0}};'; to prev= ent compilation failure. > > > > name =3D rte_vdev_device_name(dev); > > params =3D rte_vdev_device_args(dev); > > @@ -1640,7 +1668,7 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev) > > ret =3D rte_kvargs_process(kvlist, > > ETH_TAP_MAC_ARG, > > &set_mac_type, > > - &fixed_mac_type); > > + &user_mac); > > if (ret =3D=3D -1) > > goto leave; > > } > > @@ -1651,7 +1679,7 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev) > > RTE_LOG(NOTICE, PMD, "Initializing pmd_tap for %s as %s\n", > > name, tap_name); > > > > - ret =3D eth_dev_tap_create(dev, tap_name, remote_iface, > > fixed_mac_type); > > + ret =3D eth_dev_tap_create(dev, tap_name, remote_iface, &user_mac); > > > > leave: > > if (ret =3D=3D -1) { > > @@ -1716,5 +1744,5 @@ RTE_PMD_REGISTER_ALIAS(net_tap, eth_tap); > > RTE_PMD_REGISTER_PARAM_STRING(net_tap, > > ETH_TAP_IFACE_ARG "=3D " > > ETH_TAP_SPEED_ARG "=3D " > > - ETH_TAP_MAC_ARG "=3D" ETH_TAP_MAC_FIXED " " > > + ETH_TAP_MAC_ARG "=3D" ETH_TAP_MAC_ARG_FMT > > ETH_TAP_REMOTE_ARG "=3D"); > > -- > > 2.11.0 With these changes it is reviewed from my end.