From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 0F2374C74 for ; Mon, 26 Feb 2018 12:48:37 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2018 03:48:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,396,1515484800"; d="scan'208";a="32859192" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 26 Feb 2018 03:48:36 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 26 Feb 2018 03:48:36 -0800 Received: from BGSMSX108.gar.corp.intel.com (10.223.4.192) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 26 Feb 2018 03:48:35 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.25]) by BGSMSX108.gar.corp.intel.com ([169.254.8.123]) with mapi id 14.03.0319.002; Mon, 26 Feb 2018 17:18:33 +0530 From: "Varghese, Vipin" To: "Pattan, Reshma" , "dev@dpdk.org" CC: "Mcnamara, John" Thread-Topic: [PATCH] app/pdump: check for ports Thread-Index: AQHTru9nEeaEc5NRfEulWvHQnECoB6O2KH8AgABozPA= Date: Mon, 26 Feb 2018 11:48:32 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D19BE28@BGSMSX101.gar.corp.intel.com> References: <1519662622-10011-1-git-send-email-vipin.varghese@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A2A4011@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2A4011@irsmsx110.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmIxZjUxNGUtYmQxYi00MzVhLTgwNGUtNmVhM2Q5ZDFjODEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJMVllPeldlQ0RTYisyTHpkMEhETnFBTVRXMEpOZHlLUHhJNFZDeVZ0azI3VUJsZXBKbksyQzhndzNhMnFKN1BpIn0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/pdump: check for ports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2018 11:48:38 -0000 > -----Original Message----- > From: Pattan, Reshma > Sent: Monday, February 26, 2018 11:02 AM > To: Varghese, Vipin ; dev@dpdk.org > Cc: Mcnamara, John > Subject: RE: [PATCH] app/pdump: check for ports >=20 >=20 >=20 > > -----Original Message----- > > From: Varghese, Vipin > > Sent: Monday, February 26, 2018 4:30 PM > > To: dev@dpdk.org; Pattan, Reshma > > Cc: Mcnamara, John ; Varghese, Vipin > > > > Subject: [PATCH] app/pdump: check for ports > > > > + if (rte_eth_dev_count() =3D=3D 0) > > + rte_exit(EXIT_FAILURE, "Failed to fetch ports for > PDUMP!\n"); > > + >=20 > Good one, can you just change the failure log to rte_exit(EXIT_FAILURE, "= No > Ethernet ports - bye\n"); As, I see most of the other examples and apps d= o > use the similar check and log as above. :-) >=20 Sure, I will send a v2 patch with updated log information. > Thanks, > Reshma