From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D3486293B for ; Sat, 27 Oct 2018 06:37:10 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Oct 2018 21:37:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,430,1534834800"; d="scan'208";a="102926636" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 26 Oct 2018 21:37:09 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 26 Oct 2018 21:37:09 -0700 Received: from BGSMSX108.gar.corp.intel.com (10.223.4.192) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 26 Oct 2018 21:37:08 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.20]) by BGSMSX108.gar.corp.intel.com ([169.254.8.62]) with mapi id 14.03.0415.000; Sat, 27 Oct 2018 10:07:05 +0530 From: "Varghese, Vipin" To: "Pattan, Reshma" , "dev@dpdk.org" , "stephen@networkplumber.org" , "Tahhan, Maryam" CC: "Patel, Amol" , "Tummala, Sivaprasad" , "Byrne, Stephen1" , "Glynn, Michael J" Thread-Topic: [PATCH v2 6/9] app/procinfo: add code for debug crypto Thread-Index: AQHUa2YdUHNelxTskUGntxLz3YvtbaUxKU0AgAFb1EA= Date: Sat, 27 Oct 2018 04:37:04 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2B4F78@BGSMSX101.gar.corp.intel.com> References: <20181023135751.21536-1-vipin.varghese@intel.com> <20181024064805.23197-1-vipin.varghese@intel.com> <20181024064805.23197-6-vipin.varghese@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A3BE6D6@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A3BE6D6@irsmsx110.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODJhZDk0OTMtY2ExMS00NmQ5LTk3Y2UtNmRiZjNiNWU1NmZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWUhGY2RES3BIUXlYQXkzdjY2bzNtVGpkVEhZOWt4MWc1dzlJbzdKSm5rRUlGS0pnaFFENFZUNFJWK1FDWjZlcSJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 6/9] app/procinfo: add code for debug crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2018 04:37:11 -0000 Hi Reshma, >=20 > + "\t -- id (%u) flags (0x%"PRIx64") socket (%d)\n" > + "\t -- queue pairs (%d)\n", > + rte_cryptodev_name_get(i), > + dev_info.driver_name, dev_info.driver_id, > + dev_info.feature_flags, dev_info.device->numa_node, > + rte_cryptodev_queue_pair_count(i)); >=20 > Above 6lines have spaces+ tabs mixed, should use only tabs. Thanks for the feedback, can you please help me understand usage pattern in= nic_stats_display, nic_stats_clear and nic_xstats_by_name_display.=20 I always use tabs, but since its mixed usage it forced me to follow the sam= e. But since the suggestion is right one, I will share the V3 with the fixe= s for the newly added functions.=20 Let us decide format correction for nic_stats_display, nic_stats_clear and = nic_xstats_by_name_display separately too.