From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 50EF62986 for ; Sat, 27 Oct 2018 09:10:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2018 00:10:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,430,1534834800"; d="scan'208";a="99154242" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 27 Oct 2018 00:10:00 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 27 Oct 2018 00:09:59 -0700 Received: from bgsmsx103.gar.corp.intel.com (10.223.4.130) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 27 Oct 2018 00:09:59 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.234]) by BGSMSX103.gar.corp.intel.com ([169.254.4.92]) with mapi id 14.03.0415.000; Sat, 27 Oct 2018 12:39:57 +0530 From: "Varghese, Vipin" To: "Pattan, Reshma" , "dev@dpdk.org" , "Tahhan, Maryam" CC: "Patel, Amol" , "Tummala, Sivaprasad" , "Byrne, Stephen1" , "Glynn, Michael J" Thread-Topic: [PATCH v1 4/9] app/procinfo: add code for debug port Thread-Index: AQHUatj9Qxz4WbdBfkGdKUTttQAXYKUvv6QAgALLNIA= Date: Sat, 27 Oct 2018 07:09:55 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2B500B@BGSMSX101.gar.corp.intel.com> References: <20181023135751.21536-1-vipin.varghese@intel.com> <20181023135751.21536-4-vipin.varghese@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A3BE0A7@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A3BE0A7@irsmsx110.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWRhOWExMzctN2EzMy00NjBmLWE1ODEtNGY3YzNlMGY4NjNlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibkVLREdadVlSNjVHZ0tuMzN1SHZGUVZ2TXoxSjNcL3Y5aXVSY0l6Y3RKWDVqZHFNRnY1cUhNSzJDYXozOVdMWE8ifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 4/9] app/procinfo: add code for debug port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2018 07:10:01 -0000 > > > > +char bdr_str[100]; >=20 > #define for marco size would be good. Instead of hard code. Yes, agreed. > > + struct rte_eth_link link =3D {0}; >=20 > Initialize structs using memset here and in other places. >=20 Will change for v3 > > + printf("\t -- RSS len %u key (hex):", > > + rss_conf.rss_key_len); > > + for (k =3D 0; k < rss_conf.rss_key_len; k++) > > + printf(" %x", rss_conf.rss_key[k]); > > + printf("\t -- hf 0x%"PRIx64"\n", > > + rss_conf.rss_hf); >=20 > Is this per port? not per queue. Can this be moved to outside of the queu= e for > loop. Yes, currently RSS is set for all rx queues so it is per port. I think I co= ded for upcoming feature rx RSS queue group,. I will correct and send v3. > > + } > > + > > + printf(" - drop packet information\n"); >=20 > Printf heading can be changed as it is printing input and output packets = also. >=20 ok