From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Tahhan, Maryam" <maryam.tahhan@intel.com>
Cc: "Patel, Amol" <amol.patel@intel.com>,
"Tummala, Sivaprasad" <sivaprasad.tummala@intel.com>,
"Byrne, Stephen1" <stephen1.byrne@intel.com>,
"Glynn, Michael J" <michael.j.glynn@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 2/9] app/procinfo: add compare for new options
Date: Sat, 27 Oct 2018 07:17:47 +0000 [thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2B501E@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A3BE084@irsmsx110.ger.corp.intel.com>
HI
<snipped>
>
> > +/**< Enable port debug. */
> In comment , Enable displaying port info?
ok
>
> > +static uint32_t enable_dbg_port;
> Do you want to consider replacing "debug" to "show" in code here other
> places? As you have already changed the commands to "show."
>
If the variable naming has to change, I can do
> ring_name = optarg;
> How about doing memcpy instead of pointer assignment? Similarly below.
> Though I don't see issue here. But safe to use memcpy.
>
I will check this internally, I also think this is safe as it is pointer argv elements. I have taken the same design from
/* Print xstat single value given by name*/
if (!strncmp(long_option[option_index].name,
"xstats-name", MAX_LONG_OPT_SZ)) {
enable_xstats_name = 1;
xstats_name = optarg;
<snipped>
next prev parent reply other threads:[~2018-10-27 7:17 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 13:57 [dpdk-dev] [PATCH v1 1/9] app/procinfo: add usage for new debug Vipin Varghese
2018-10-23 13:57 ` [dpdk-dev] [PATCH v1 2/9] app/procinfo: add compare for new options Vipin Varghese
2018-10-25 15:18 ` Pattan, Reshma
2018-10-27 7:17 ` Varghese, Vipin [this message]
2018-10-23 13:57 ` [dpdk-dev] [PATCH v1 3/9] app/procinfo: add prototype for debug instances Vipin Varghese
2018-10-23 13:57 ` [dpdk-dev] [PATCH v1 4/9] app/procinfo: add code for debug port Vipin Varghese
2018-10-25 15:38 ` Pattan, Reshma
2018-10-27 7:09 ` Varghese, Vipin
2018-10-25 15:46 ` Pattan, Reshma
2018-10-27 4:47 ` Varghese, Vipin
2018-10-23 13:57 ` [dpdk-dev] [PATCH v1 5/9] app/procinfo: add code for debug tm Vipin Varghese
2018-10-23 13:57 ` [dpdk-dev] [PATCH v1 6/9] app/procinfo: add code for debug crypto Vipin Varghese
2018-10-23 13:57 ` [dpdk-dev] [PATCH v1 7/9] app/procinfo: add code for debug ring Vipin Varghese
2018-10-23 13:57 ` [dpdk-dev] [PATCH v1 8/9] app/procinfo: add code for debug mempool Vipin Varghese
2018-10-23 13:57 ` [dpdk-dev] [PATCH v1 9/9] doc/proc_info: add information for debug options Vipin Varghese
2018-10-23 15:19 ` [dpdk-dev] [PATCH v1 1/9] app/procinfo: add usage for new debug Stephen Hemminger
2018-10-24 5:41 ` Varghese, Vipin
2018-10-24 15:56 ` Stephen Hemminger
2018-10-24 6:47 ` [dpdk-dev] [PATCH v2 " Vipin Varghese
2018-10-24 6:47 ` [dpdk-dev] [PATCH v2 2/9] app/procinfo: add compare for new options Vipin Varghese
2018-10-24 6:47 ` [dpdk-dev] [PATCH v2 3/9] app/procinfo: add prototype for debug instances Vipin Varghese
2018-10-24 6:48 ` [dpdk-dev] [PATCH v2 4/9] app/procinfo: add code for debug port Vipin Varghese
2018-10-25 16:20 ` Pattan, Reshma
2018-10-27 4:45 ` Varghese, Vipin
2018-11-05 11:39 ` Thomas Monjalon
2018-11-05 15:31 ` Varghese, Vipin
2018-10-24 6:48 ` [dpdk-dev] [PATCH v2 5/9] app/procinfo: add code for debug tm Vipin Varghese
2018-10-24 6:48 ` [dpdk-dev] [PATCH v2 6/9] app/procinfo: add code for debug crypto Vipin Varghese
2018-10-26 13:01 ` Pattan, Reshma
2018-10-27 4:42 ` Varghese, Vipin
2018-10-28 15:29 ` Stephen Hemminger
2018-10-29 14:29 ` Varghese, Vipin
2018-10-26 13:16 ` Pattan, Reshma
2018-10-27 4:37 ` Varghese, Vipin
2018-10-24 6:48 ` [dpdk-dev] [PATCH v2 7/9] app/procinfo: add code for debug ring Vipin Varghese
2018-10-24 6:48 ` [dpdk-dev] [PATCH v2 8/9] app/procinfo: add code for debug mempool Vipin Varghese
2018-10-24 6:48 ` [dpdk-dev] [PATCH v2 9/9] doc/procinfo: add information for debug options Vipin Varghese
2018-10-25 15:11 ` Varghese, Vipin
2018-11-05 17:51 ` [dpdk-dev] [PATCH v3 1/9] app/procinfo: add usage for new debug Vipin Varghese
2018-11-05 17:51 ` [dpdk-dev] [PATCH v3 2/9] app/procinfo: add compare for new options Vipin Varghese
2018-11-05 17:51 ` [dpdk-dev] [PATCH v3 3/9] app/procinfo: add prototype for debug instances Vipin Varghese
2018-11-05 17:51 ` [dpdk-dev] [PATCH v3 4/9] app/procinfo: add support for show port Vipin Varghese
2018-11-05 17:51 ` [dpdk-dev] [PATCH v3 5/9] app/procinfo: add support for show tm Vipin Varghese
2018-11-05 17:51 ` [dpdk-dev] [PATCH v3 6/9] app/procinfo: add support for show crypto Vipin Varghese
2018-11-05 18:08 ` [dpdk-dev] [PATCH " Vipin Varghese
2018-11-05 18:08 ` [dpdk-dev] [PATCH v3 " Varghese, Vipin
2018-11-05 18:17 ` [dpdk-dev] [PATCH " Vipin Varghese
2018-11-05 17:51 ` [dpdk-dev] [PATCH v3 7/9] app/procinfo: add support for debug ring Vipin Varghese
2018-11-05 17:51 ` [dpdk-dev] [PATCH v3 8/9] app/procinfo: add support for show mempool Vipin Varghese
2018-11-05 18:06 ` [dpdk-dev] [PATCH " Vipin Varghese
2018-11-05 18:09 ` [dpdk-dev] [PATCH v3 " Varghese, Vipin
2018-11-05 18:18 ` [dpdk-dev] [PATCH " Vipin Varghese
2018-11-05 18:22 ` Vipin Varghese
2018-11-06 2:24 ` [dpdk-dev] [PATCH v4 " Vipin Varghese
2018-11-06 2:25 ` Vipin Varghese
2018-11-06 2:31 ` [dpdk-dev] [PATCH v5 1/9] app/procinfo: add usage for new debug Vipin Varghese
2018-11-06 2:31 ` [dpdk-dev] [PATCH v5 2/9] app/procinfo: add compare for new options Vipin Varghese
2018-11-06 2:31 ` [dpdk-dev] [PATCH v5 3/9] app/procinfo: add prototype for debug instances Vipin Varghese
2018-11-06 2:31 ` [dpdk-dev] [PATCH v5 4/9] app/procinfo: add support for show port Vipin Varghese
2018-11-06 2:31 ` [dpdk-dev] [PATCH v5 5/9] app/procinfo: add support for show tm Vipin Varghese
2018-11-06 2:31 ` [dpdk-dev] [PATCH v5 6/9] app/procinfo: add support for show crypto Vipin Varghese
2018-11-06 2:31 ` [dpdk-dev] [PATCH v5 7/9] app/procinfo: add support for debug ring Vipin Varghese
2018-11-06 2:31 ` [dpdk-dev] [PATCH v5 8/9] app/procinfo: add support for show mempool Vipin Varghese
2018-11-06 2:31 ` [dpdk-dev] [PATCH v5 9/9] doc/procinfo: add information for debug options Vipin Varghese
2018-11-05 17:51 ` [dpdk-dev] [PATCH v3 " Vipin Varghese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2B501E@BGSMSX101.gar.corp.intel.com \
--to=vipin.varghese@intel.com \
--cc=amol.patel@intel.com \
--cc=dev@dpdk.org \
--cc=maryam.tahhan@intel.com \
--cc=michael.j.glynn@intel.com \
--cc=reshma.pattan@intel.com \
--cc=sivaprasad.tummala@intel.com \
--cc=stephen1.byrne@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).