From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 479C72B8C for ; Sat, 27 Oct 2018 09:17:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2018 00:17:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,430,1534834800"; d="scan'208";a="84561893" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 27 Oct 2018 00:17:52 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 27 Oct 2018 00:17:51 -0700 Received: from bgsmsx154.gar.corp.intel.com (10.224.48.47) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 27 Oct 2018 00:17:51 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.234]) by BGSMSX154.gar.corp.intel.com ([169.254.7.23]) with mapi id 14.03.0415.000; Sat, 27 Oct 2018 12:47:48 +0530 From: "Varghese, Vipin" To: "Pattan, Reshma" , "dev@dpdk.org" , "Tahhan, Maryam" CC: "Patel, Amol" , "Tummala, Sivaprasad" , "Byrne, Stephen1" , "Glynn, Michael J" Thread-Topic: [PATCH v1 2/9] app/procinfo: add compare for new options Thread-Index: AQHUatj8i6Z8Z3V8Zk2nhG1+vWIxG6UvuigAgAL5i5A= Date: Sat, 27 Oct 2018 07:17:47 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2B501E@BGSMSX101.gar.corp.intel.com> References: <20181023135751.21536-1-vipin.varghese@intel.com> <20181023135751.21536-2-vipin.varghese@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A3BE084@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A3BE084@irsmsx110.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTRjYTdiZGEtYmVkZi00Njg5LWI4YTgtNGVlMzUxNGU3MTBhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMXgxQlVRK1BDSlQxQ1NYS092WTVDN3VXOXlsNG1BNlwvQnFPWDRZTnZubTN2TGk1VDZHNEdycUdyU1ZveFA5ZmEifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 2/9] app/procinfo: add compare for new options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2018 07:17:53 -0000 HI >=20 > > +/**< Enable port debug. */ > In comment , Enable displaying port info? ok >=20 > > +static uint32_t enable_dbg_port; > Do you want to consider replacing "debug" to "show" in code here other > places? As you have already changed the commands to "show." >=20 If the variable naming has to change, I can do > ring_name =3D optarg; > How about doing memcpy instead of pointer assignment? Similarly below. > Though I don't see issue here. But safe to use memcpy. >=20 I will check this internally, I also think this is safe as it is pointer ar= gv elements. I have taken the same design from /* Print xstat single value given by name*/ if (!strncmp(long_option[option_index].name, "xstats-name", MAX_LONG_OPT_SZ)) { enable_xstats_name =3D 1; xstats_name =3D optarg;