From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 747061E2F for ; Mon, 29 Oct 2018 15:29:24 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Oct 2018 07:29:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,440,1534834800"; d="scan'208";a="269698614" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 29 Oct 2018 07:29:23 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 29 Oct 2018 07:29:23 -0700 Received: from bgsmsx105.gar.corp.intel.com (10.223.43.197) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 29 Oct 2018 07:29:22 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.234]) by BGSMSX105.gar.corp.intel.com ([169.254.3.64]) with mapi id 14.03.0415.000; Mon, 29 Oct 2018 19:59:19 +0530 From: "Varghese, Vipin" To: Stephen Hemminger CC: "Pattan, Reshma" , "dev@dpdk.org" , "Tahhan, Maryam" , "Patel, Amol" , "Tummala, Sivaprasad" , "Byrne, Stephen1" , "Glynn, Michael J" Thread-Topic: [PATCH v2 6/9] app/procinfo: add code for debug crypto Thread-Index: AQHUa2YdUHNelxTskUGntxLz3YvtbaUxJSgAgAFhfZCAAexWAIAB2X0g Date: Mon, 29 Oct 2018 14:29:19 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2B56C5@BGSMSX101.gar.corp.intel.com> References: <20181023135751.21536-1-vipin.varghese@intel.com> <20181024064805.23197-1-vipin.varghese@intel.com> <20181024064805.23197-6-vipin.varghese@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A3BE6A5@irsmsx110.ger.corp.intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2B4F8E@BGSMSX101.gar.corp.intel.com> <20181028082918.2020a5c5@xeon-e3> In-Reply-To: <20181028082918.2020a5c5@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDM2NzVhYzMtMmU4OC00NWMzLTkwYzItZWU1ZTkzYzQzMWY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaGRtV2s3aGFpWVdRdFppUFoxaTc1SDJvem5vdkdPcmRRMUMzaXRJZDJvVW1OTXViTE55REliZWcrWWZoeXRiTyJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 6/9] app/procinfo: add code for debug crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 14:29:25 -0000 Hi Stepehen, > > > This is a very big macro, better have static function for this instea= d of > macro. > > > > > > > There are two thoughts in choosing MACRO over function. > > 1. The information need to display in certain format within the same co= ntext. > > 2. As the API are modified, co locating all at same scope is easier to = clean up > and correct in future. > > > > So I feel use of MACRO over function in this instance. >=20 >=20 > I don't agree with your arguments. Macros, are ugly and error prone. This= is > not performance critical so it should be a function. The only reason to u= se > macro's is if it is not possible to write it as a function (as in a templ= ate for code > generation). Thanks for the sharing your feedback. But In my comments I never stated the= MACRO were used for performance or critical blocks. As mentioned in my exp= lanation, the MACRO is used for printing the desired format and format the = code.=20 Since I have received 2 request for change, I will do the same and release = v3. Thanks Vipin Varghese