From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vipin.varghese@intel.com>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id 821CF1B675
 for <dev@dpdk.org>; Mon, 26 Nov 2018 11:13:57 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 26 Nov 2018 02:13:56 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.56,281,1539673200"; d="scan'208";a="284215284"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
 by fmsmga006.fm.intel.com with ESMTP; 26 Nov 2018 02:13:56 -0800
Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Mon, 26 Nov 2018 02:13:56 -0800
Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by
 fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Mon, 26 Nov 2018 02:13:56 -0800
Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.234]) by
 BGSMSX102.gar.corp.intel.com ([169.254.2.133]) with mapi id 14.03.0415.000;
 Mon, 26 Nov 2018 15:43:53 +0530
From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, Stephen Hemminger
 <stephen@networkplumber.org>
CC: "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, 
 "thomas@monjalon.net" <thomas@monjalon.net>, "Mcnamara, John"
 <john.mcnamara@intel.com>, "Byrne, Stephen1" <stephen1.byrne@intel.com>,
 "Glynn, Michael J" <michael.j.glynn@intel.com>, "Patel, Amol"
 <amol.patel@intel.com>
Thread-Topic: [PATCH v4 5/9] app/procinfo: add support for show tm
Thread-Index: AQHUdc+zPfVf/p7zD0i8dNfiuPEpQaVaBQMAgAHdNJCAARuHAIAAdxGA//+lqACAAGIkoP//tUMAgABdKbD//8tNgACG1NyA///73gCAAAGlgP//oOLggABlZAD//595gA==
Date: Mon, 26 Nov 2018 10:13:52 +0000
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C222C@BGSMSX101.gar.corp.intel.com>
References: <20181106124912.40700-1-vipin.varghese@intel.com>
 <20181106124912.40700-5-vipin.varghese@intel.com>
 <3AEA2BF9852C6F48A459DA490692831F2A3D58A3@irsmsx110.ger.corp.intel.com>
 <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1435@BGSMSX101.gar.corp.intel.com>
 <3AEA2BF9852C6F48A459DA490692831F2A3D61A6@irsmsx110.ger.corp.intel.com>
 <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1A45@BGSMSX101.gar.corp.intel.com>
 <3AEA2BF9852C6F48A459DA490692831F2A3D6264@irsmsx110.ger.corp.intel.com>
 <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1A79@BGSMSX101.gar.corp.intel.com>
 <3AEA2BF9852C6F48A459DA490692831F2A3D62FB@irsmsx110.ger.corp.intel.com>
 <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1B26@BGSMSX101.gar.corp.intel.com>
 <20181123092215.50d299ae@xeon-e3>
 <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1FD9@BGSMSX101.gar.corp.intel.com>
 <2601191342CEEE43887BDE71AB977258010CEBC4DC@IRSMSX106.ger.corp.intel.com>
 <2601191342CEEE43887BDE71AB977258010CEBC50B@IRSMSX106.ger.corp.intel.com>
 <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C21D4@BGSMSX101.gar.corp.intel.com>
 <2601191342CEEE43887BDE71AB977258010CEBC536@IRSMSX106.ger.corp.intel.com>
In-Reply-To: <2601191342CEEE43887BDE71AB977258010CEBC536@IRSMSX106.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_NT
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjM4MzQyYTctNmQyNy00YmE1LTk0YzYtMTRiYzU3N2IxYzVlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVm1CTHRsa21IOG9hUE4xMldpR09mMzJrWENPeVRoa3ZNaGY1UlZ6dmVrMHFGcmdBVXh6QUQyc1I3TlR4Z3lvKyJ9
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-originating-ip: [10.223.10.10]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Nov 2018 10:13:58 -0000

Hi,

> Hi Vipin,
>=20
> >
> > Hi Konstantin,
> >
> > > >
> > > > If the operator is '|' what else except of 'OR' you expect it to be=
 remapped?
> >
> > Thanks for your correction. I have rerun with logical or
> >
> >                         if ((ret) || (!is_leaf))
> >    9a512:       83 bd 3c fd ff ff 00    cmp    DWORD PTR [rbp-0x2c4],0x=
0
> >    9a519:       75 7e                   jne    9a599 <show_tm+0x739>
> >    9a51b:       8b 85 28 fd ff ff       mov    eax,DWORD PTR [rbp-0x2d8=
]
> >    9a521:       85 c0                   test   eax,eax
> >    9a523:       74 74                   je     9a599 <show_tm+0x739>
> >                                 continue;
> >
> > There is no conversion to 'Or' operation here. Thanks for
> >
> > > BTW, I am agree with Reshma it has to be '||' here.
> > Thanks for your opinion, can you share review comments for show_tm for
> debug?
>=20
> Not sure I understand your last sentence...
> Konstantin

As mentioned earlier email I am ready to spin v6 with 'logical or'. But if =
there any other comments for show_tm it will be nice to accommodate to v6 r=
ather than v7. So, can you please share if there any other comments for sho=
w_tm?

Thanks
Vipin Varghese