From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 51A631B1D6; Wed, 5 Dec 2018 06:16:04 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2018 21:16:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,316,1539673200"; d="scan'208";a="116066716" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 04 Dec 2018 21:16:03 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Dec 2018 21:16:03 -0800 Received: from bgsmsx104.gar.corp.intel.com (10.223.4.190) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Dec 2018 21:16:02 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.234]) by BGSMSX104.gar.corp.intel.com ([169.254.5.13]) with mapi id 14.03.0415.000; Wed, 5 Dec 2018 10:45:59 +0530 From: "Varghese, Vipin" To: "Varghese, Vipin" , "Yang, Qiming" , "dev@dpdk.org" CC: "Yang, Qiming" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] lib: add warning for NULL pointer Thread-Index: AQHUjFM7tPWsNVxV5k2OYe3lpX89UaVvjy3AgAALNRA= Date: Wed, 5 Dec 2018 05:15:59 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C4C1A@BGSMSX101.gar.corp.intel.com> References: <20181205115531.17073-1-qiming.yang@intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C4BF6@BGSMSX101.gar.corp.intel.com> In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C4BF6@BGSMSX101.gar.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDExNThkZjQtODQ3MC00MzM2LWJmNTUtMTcxMzhmNTcyOGMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYVd2c3NvRVpVODNxQWVnVFhrbmlNbk9LU2hhRXg0MWFhN3k1c3Z4N0VEUUNVRDVyOXpnYkFLTnBiTTRNVzVRKyJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] lib: add warning for NULL pointer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2018 05:16:04 -0000 Do you plan to check for all iteration for ' flows->last_cmplt ' is success= ful? > -----Original Message----- > From: dev On Behalf Of Varghese, Vipin > Sent: Wednesday, December 5, 2018 10:07 AM > To: Yang, Qiming ; dev@dpdk.org > Cc: Yang, Qiming ; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib: add warning for NULL pointer >=20 > Hi, >=20 > Should not the warning be stated for ' alloc_completion' failure >=20 > Snipped >=20 > > flows->num_packets * flows->categories); > > } > > > > + if (flows->last_cmplt =3D=3D NULL) > > + RTE_LOG(WARNING, MALLOC, "packet tries allocate > > failed"); >=20 > Why is that we want to try this outside block? >=20 > > + > > /* set completion parameters and starting index for this slot */ > > parms[n].cmplt =3D flows->last_cmplt; > > transition =3D > > -- > > 2.9.5