From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id B23FB2BF5 for ; Thu, 13 Dec 2018 17:21:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2018 08:21:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,349,1539673200"; d="scan'208";a="303573094" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 13 Dec 2018 08:21:44 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Dec 2018 08:21:44 -0800 Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Dec 2018 08:21:43 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.20]) by BGSMSX102.gar.corp.intel.com ([169.254.2.62]) with mapi id 14.03.0415.000; Thu, 13 Dec 2018 21:51:39 +0530 From: "Varghese, Vipin" To: "Pattan, Reshma" , "Ananyev, Konstantin" , "stephen@networkplumber.org" , "dev@dpdk.org" , "Mcnamara, John" CC: "thomas@monjalon.net" , "Byrne, Stephen1" , "Patel, Amol" Thread-Topic: [PATCH v7 0/9] app/proc-info: improve debug of proc-info tool Thread-Index: AQHUkqIChTM8jv1BUUKrANUUQroTMaV8YrgAgAB3rGA= Date: Thu, 13 Dec 2018 16:21:38 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2DA895@BGSMSX101.gar.corp.intel.com> References: <20181203055000.39012-2-vipin.varghese@intel.com> <20181213050842.64587-1-vipin.varghese@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A3EA1F0@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A3EA1F0@irsmsx110.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTM2YTdhNWEtYjkzNi00ODliLTkzZTktOTYwZDQwMzhhZjFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibmNGaWxmQkNlXC9lN0taZU9wVnh4MWpqclwvVzZDSzVqQjV1eHZSenFpelNzc0hWaFBBMWVIK0l5aUdoYmNVT0dGIn0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 0/9] app/proc-info: improve debug of proc-info tool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2018 16:21:46 -0000 HI Reshma > -----Original Message----- > From: Pattan, Reshma > Sent: Thursday, December 13, 2018 8:13 PM > To: Varghese, Vipin ; Ananyev, Konstantin > ; stephen@networkplumber.org; > dev@dpdk.org; Mcnamara, John > Cc: thomas@monjalon.net; Byrne, Stephen1 ; > Patel, Amol > Subject: RE: [PATCH v7 0/9] app/proc-info: improve debug of proc-info too= l >=20 > Hi >=20 > > -----Original Message----- > > From: Varghese, Vipin > > Sent: Thursday, December 13, 2018 5:09 AM > > To: Ananyev, Konstantin ; > > stephen@networkplumber.org; Pattan, Reshma > ; > > dev@dpdk.org; Mcnamara, John > > Cc: thomas@monjalon.net; Byrne, Stephen1 ; > > Patel, Amol ; Varghese, Vipin > > > > Subject: [PATCH v7 0/9] app/proc-info: improve debug of proc-info tool > > > > This patch adds new debug functions to existing proc-info tool. > > > > Motivation > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > DPDK proc-info tool is been widely used as secondary process to > > collect stats for any primary process. But these are limited to DPDK > > NIC ports and basic memory usage. > > > > Motivation > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > This patch tries to address the short coming by adding debug for port, > > traffic manager, crypto, ring and mempool. With these additional > > information in tool will be able to deliver helpful data to debug issue= s and > performance variance. > > > > Status > > =3D=3D=3D=3D=3D=3D > > > > With the following patch set debug data has been collected from > > customers using DPDK instances. Analysing the information helped to > > suggest the next debug steps and solutions for fixing the issues. > > > > Next Steps > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > - add event dev debug information. > > - enhance iter_mempool for INLINE crypto entries. > > - add debug for libraries like hash and acl. > > - explore debug possibility for ring and list. > > - add links and reference to 'how to guide' for 'debug and troubleshoo= t'. > > > > Patch set Information > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > Patch includes set of 9 patches: > > * 0 : to introduce the debug function enhancement for proc-info > > * 1 : MACRO and help usage for new functions > > * 2 : string compare for new functions > > * 3 : invocation for the new prototypes > > * 4 : show port > > * 5 : show tm > > * 6 : show crypto > > * 7 : ring element debug > > * 8 : mempool element debug > > * 9 : iterate mempoool elements > > >=20 > Small nits > 9th patch in this set is doc. So above info need to be corrected. > if you are addressing my earlier comment of separating out mempool elemen= t > iteration changes in to separate new patch 9/10 .Please keep my ack in ne= xt > version Thanks for pointing this out, Like updated in email and chat I am not plann= ing to split it. Hence no version 8. >=20 > Reviewed-by: Reshma Pattan > Acked-by: Reshma Pattan >=20 >=20 >=20 >=20 >=20