From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E7D011B6CD for ; Mon, 17 Dec 2018 09:20:03 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2018 00:20:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,364,1539673200"; d="scan'208";a="107958913" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga007.fm.intel.com with ESMTP; 17 Dec 2018 00:20:02 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 17 Dec 2018 00:20:02 -0800 Received: from bgsmsx104.gar.corp.intel.com (10.223.4.190) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 17 Dec 2018 00:20:02 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.20]) by BGSMSX104.gar.corp.intel.com ([169.254.5.240]) with mapi id 14.03.0415.000; Mon, 17 Dec 2018 13:49:59 +0530 From: "Varghese, Vipin" To: "Daly, Lee" , "akhil.goyal@nxp.com" CC: "dev@dpdk.org" , "Daly, Lee" Thread-Topic: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver Thread-Index: AQHUk5PJOQKfXSq2qU+k/VXgOF8Ox6WCmrdg Date: Mon, 17 Dec 2018 08:19:58 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2DC5B7@BGSMSX101.gar.corp.intel.com> References: <11544697752-156863-1-git-send-email-lee.daly@intel.com> <1544781564-63598-1-git-send-email-lee.daly@intel.com> In-Reply-To: <1544781564-63598-1-git-send-email-lee.daly@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzM1Yzc5YjYtMGM2NC00M2M3LTllNzItNDZjNGEzODM3YTVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTHAyb1ZrWUdmNUtjTGJKSTN2SHlINzZPc2RVTEhJNjMrenBVWUtqcUErNExjVnNSNDJoOXhNbDV2VUdGOW4zUiJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 08:20:04 -0000 Hi Lee, Apologies if the logic is already done for my query snipped > + /* Set private xform checksum */ > + switch (xform->compress.chksum) { > + /* Raw deflate by default */ Does the user have to choose RTE_COMP_CHECKSUM_NONE while creating compress= /isal instance? > + case(RTE_COMP_CHECKSUM_NONE): > + priv_xform->compress.chksum =3D IGZIP_DEFLATE; > + break; > + case(RTE_COMP_CHECKSUM_CRC32): > + priv_xform->compress.chksum =3D IGZIP_GZIP_NO_HDR; > + break; > + case(RTE_COMP_CHECKSUM_ADLER32): > + priv_xform->compress.chksum =3D IGZIP_ZLIB_NO_HDR; > + break; > + case(RTE_COMP_CHECKSUM_CRC32_ADLER32): > + ISAL_PMD_LOG(ERR, "Combined CRC and ADLER > checksum not" > + " supported\n"); > + return -ENOTSUP; > + default: > + ISAL_PMD_LOG(ERR, "Checksum type not > supported\n"); > + return -ENOTSUP; Do we not fall back to RTE_COMP_CHECKSUM_NONE if the configuration is wrong= and report warning? snipped