From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id DF8761B609 for ; Mon, 17 Dec 2018 13:33:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2018 04:33:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,365,1539673200"; d="scan'208";a="108004561" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 17 Dec 2018 04:33:09 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 17 Dec 2018 04:33:07 -0800 Received: from BGSMSX108.gar.corp.intel.com (10.223.4.192) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 17 Dec 2018 04:33:07 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.20]) by BGSMSX108.gar.corp.intel.com ([169.254.8.128]) with mapi id 14.03.0415.000; Mon, 17 Dec 2018 18:03:04 +0530 From: "Varghese, Vipin" To: "Daly, Lee" , "akhil.goyal@nxp.com" CC: "dev@dpdk.org" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver Thread-Index: AQHUk5PJOQKfXSq2qU+k/VXgOF8Ox6WCmrdg//+1VICAAJINgA== Date: Mon, 17 Dec 2018 12:33:04 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2DC763@BGSMSX101.gar.corp.intel.com> References: <11544697752-156863-1-git-send-email-lee.daly@intel.com> <1544781564-63598-1-git-send-email-lee.daly@intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2DC5B7@BGSMSX101.gar.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzM1Yzc5YjYtMGM2NC00M2M3LTllNzItNDZjNGEzODM3YTVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTHAyb1ZrWUdmNUtjTGJKSTN2SHlINzZPc2RVTEhJNjMrenBVWUtqcUErNExjVnNSNDJoOXhNbDV2VUdGOW4zUiJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 12:33:11 -0000 Thanks for the update > -----Original Message----- > From: Daly, Lee > Sent: Monday, December 17, 2018 2:50 PM > To: Varghese, Vipin ; akhil.goyal@nxp.com > Cc: dev@dpdk.org; Trahe, Fiona > Subject: RE: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum > support in driver >=20 > Hi Vipin, thanks for the question. >=20 > > -----Original Message----- > > From: Varghese, Vipin > > Sent: Monday, December 17, 2018 8:20 AM > > To: Daly, Lee ; akhil.goyal@nxp.com > > Cc: dev@dpdk.org; Daly, Lee > > Subject: RE: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum > > support in driver > > > > Hi Lee, > > > > Apologies if the logic is already done for my query > > > > snipped > > > + /* Set private xform checksum */ > > > + switch (xform->compress.chksum) { > > > + /* Raw deflate by default */ > > Does the user have to choose RTE_COMP_CHECKSUM_NONE while creating > > compress/isal instance? >=20 > At the moment, yes the application must fill out the xform/instance. > > > > > + case(RTE_COMP_CHECKSUM_NONE): > > > + priv_xform->compress.chksum =3D IGZIP_DEFLATE; > > > + break; > > > + case(RTE_COMP_CHECKSUM_CRC32): > > > + priv_xform->compress.chksum =3D > > IGZIP_GZIP_NO_HDR; > > > + break; > > > + case(RTE_COMP_CHECKSUM_ADLER32): > > > + priv_xform->compress.chksum =3D > > IGZIP_ZLIB_NO_HDR; > > > + break; > > > + case(RTE_COMP_CHECKSUM_CRC32_ADLER32): > > > + ISAL_PMD_LOG(ERR, "Combined CRC and ADLER > > > checksum not" > > > + " supported\n"); > > > + return -ENOTSUP; > > > + default: > > > + ISAL_PMD_LOG(ERR, "Checksum type not > > > supported\n"); > > > + return -ENOTSUP; > > Do we not fall back to RTE_COMP_CHECKSUM_NONE if the configuration is > > wrong and report warning? > > >=20 > Right now, the xform must be filled out correctly before compression can = be > executed. > Perhaps we could do as you say and fall back to a default config if the n= on- > essential params are incorrect. > > snipped