From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E175B5F34 for ; Wed, 26 Dec 2018 06:21:40 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Dec 2018 21:21:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,399,1539673200"; d="scan'208";a="113275335" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 25 Dec 2018 21:21:38 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 25 Dec 2018 21:21:38 -0800 Received: from bgsmsx104.gar.corp.intel.com (10.223.4.190) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 25 Dec 2018 21:21:37 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.20]) by BGSMSX104.gar.corp.intel.com ([169.254.5.240]) with mapi id 14.03.0415.000; Wed, 26 Dec 2018 10:51:35 +0530 From: "Varghese, Vipin" To: Thomas Monjalon , "Pattan, Reshma" CC: "dev@dpdk.org" , "Ananyev, Konstantin" , "stephen@networkplumber.org" , "Mcnamara, John" , "Byrne, Stephen1" , "Patel, Amol" Thread-Topic: [dpdk-dev] [PATCH v7 0/9] app/proc-info: improve debug of proc-info tool Thread-Index: AQHUkqIChTM8jv1BUUKrANUUQroTMaV8YrgAgAB3rGCADheAAIAFnbKA Date: Wed, 26 Dec 2018 05:21:34 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2DF1A4@BGSMSX101.gar.corp.intel.com> References: <20181203055000.39012-2-vipin.varghese@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A3EA1F0@irsmsx110.ger.corp.intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2DA895@BGSMSX101.gar.corp.intel.com> <1651608.RmD6NkZceM@xps> In-Reply-To: <1651608.RmD6NkZceM@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzFmOTdkZTgtZGFmOS00NjlmLWEwNzQtYmVmMDFmOGQ3OTNjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUWJnUFZBR1VWVTM2aThqbVlEcXdlVGlMZkFlZ1FMQVNoK1YyOE9EMXdcL2dQcXFOaG41Sm40aUt4XC9lbEVKUUdZIn0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 0/9] app/proc-info: improve debug of proc-info tool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Dec 2018 05:21:41 -0000 HI Thomas, Snipped > > > Small nits > > > 9th patch in this set is doc. So above info need to be corrected. > > > if you are addressing my earlier comment of separating out mempool > > > element iteration changes in to separate new patch 9/10 .Please keep > > > my ack in next version > > > > Thanks for pointing this out, Like updated in email and chat I am not > planning to split it. Hence no version 8. >=20 > So, no ack and no merge? >=20 > Looking at the first patches + doc patch, the split is not meaningful. > You should merge doc and option parsing in the related patches. > For instance, parsing and doc of "tm" option should be in the "tm" patch. >=20 >=20 I did not follow you request. Are you stating, for each functionality I sho= uld be updating document rather than 1 document update after adding the new= functions? If former is true I am not able to find such reasoning stated i= n guideline or documentation or from the maintainer.=20 Thanks Vipin Varghese