From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 9FBB54C94 for ; Thu, 10 Jan 2019 04:09:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2019 19:08:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,459,1539673200"; d="scan'208";a="115609166" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga008.fm.intel.com with ESMTP; 09 Jan 2019 19:08:59 -0800 Received: from bgsmsx109.gar.corp.intel.com (10.223.4.211) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 9 Jan 2019 19:08:58 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.128]) by BGSMSX109.gar.corp.intel.com ([169.254.10.162]) with mapi id 14.03.0415.000; Thu, 10 Jan 2019 08:38:44 +0530 From: "Varghese, Vipin" To: Thomas Monjalon CC: "dev@dpdk.org" , "Pattan, Reshma" , "Mcnamara, John" , "Patel, Amol" , "stephen@networkplumber.org" , "Ananyev, Konstantin" , "Singh, Jasvinder" Thread-Topic: [dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions Thread-Index: AQHUpm03E0cC0f5CLEyCP8ONBDfNEqWnQaEAgACUxxA= Date: Thu, 10 Jan 2019 03:08:43 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2EE451@BGSMSX101.gar.corp.intel.com> References: <20181213050842.64587-1-vipin.varghese@intel.com> <20190107153829.34047-1-vipin.varghese@intel.com> <20190107153829.34047-2-vipin.varghese@intel.com> <15168357.XSmGzJBqIm@xps> In-Reply-To: <15168357.XSmGzJBqIm@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODFjYjVlM2ItZmY1OC00NDJhLTg4ZGYtNWY3MDc4ZWU4NWI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibEczd1E3b0JxVlhwRWlBV0FIdldWa2xVZkU0TXNjdnl2M2xwUzc1a0IzdlRoVVBTUWJsZE5QVVBFNXdVaDRMNSJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 03:09:01 -0000 snipped >=20 > Hi Vipin, >=20 > The code split in this v8 looks really better, except this patch which ma= kes no > sense alone. Hi Thomas, I need this base patch as first one. These include the helper MA= CRO and include which pans out for next 7 patches. > I feel you can move these changes in next patches, where appropriate, isn= 't it? Patches v2 to v7 uses common features from v1.=20 >=20 > 07/01/2019 16:38, Vipin Varghese: > > Update code base and meson build file to accomadate changes for the > > new functionality. > > > > Signed-off-by: Vipin Varghese > > Acked-by: Reshma Pattan > > --- > > app/proc-info/main.c | 13 +++++++++++++ > > app/proc-info/meson.build | 2 +- > > 2 files changed, 14 insertions(+), 1 deletion(-) > > > > diff --git a/app/proc-info/main.c b/app/proc-info/main.c index > > c20effa4f..c7697389c 100644 > > --- a/app/proc-info/main.c > > +++ b/app/proc-info/main.c > > @@ -29,6 +29,9 @@ > > #include > > #include > > #include > > +#include > > +#include > > +#include > > > > /* Maximum long option length for option parsing. */ #define > > MAX_LONG_OPT_SZ 64 @@ -36,6 +39,10 @@ > > > > #define MAX_STRING_LEN 256 > > > > +#define STATS_BDR_FMT > "=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D" > > +#define STATS_BDR_STR(w, s) printf("%.*s%s%.*s\n", w, \ > > + STATS_BDR_FMT, s, w, STATS_BDR_FMT) > > + > > /**< mask of enabled ports */ > > static uint32_t enabled_port_mask; > > /**< Enable stats. */ > > @@ -65,6 +72,9 @@ static char *xstats_name; static uint32_t > > nb_xstats_ids; static uint64_t xstats_ids[MAX_NB_XSTATS_IDS]; > > > > +/* show border */ > > +static char bdr_str[MAX_STRING_LEN]; > > + > > /**< display usage */ > > static void > > proc_info_usage(const char *prgname) > > @@ -668,5 +678,8 @@ main(int argc, char **argv) > > if (ret) > > printf("Error from rte_eal_cleanup(), %d\n", ret); > > > > + snprintf(bdr_str, MAX_STRING_LEN, " "); > > + STATS_BDR_STR(50, bdr_str); > > + > > return 0; > > } > > diff --git a/app/proc-info/meson.build b/app/proc-info/meson.build > > index a52b2ee4a..866b390d6 100644 > > --- a/app/proc-info/meson.build > > +++ b/app/proc-info/meson.build > > @@ -3,4 +3,4 @@ > > > > sources =3D files('main.c') > > allow_experimental_apis =3D true > > -deps +=3D ['ethdev', 'metrics'] > > +deps +=3D ['ethdev', 'metrics', 'security'] > > >=20 >=20 >=20 >=20