From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"Patel, Amol" <amol.patel@intel.com>,
"Byrne, Stephen1" <stephen1.byrne@intel.com>,
"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>
Subject: Re: [dpdk-dev] [PATCH v3] doc: add meson build to contributing guide
Date: Thu, 10 Jan 2019 16:37:56 +0000 [thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2EFA35@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <2703864.trOpUck9ay@xps>
HI Thomas
snipped
> > >
> > > +Compliation of patches has to be tested using meson::
> > > +
> > > + ./devtools/test-meson-builds.sh
> > > +
> > > +This will test for shared and static builds. If gcc arm cross
> > > +compiler is installed, cross build is tested too.
> > >
> > > Sending Patches
> > > ---------------
> >
> > Ran the script all runs fine
> >
> > Tested-by: Marko Kovacevic <marko.kovacevic@intel.com>
> > Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
>
> Yes we must add such explanation, but it can be improved.
>
> We should make clear that meson must be tested in addition of make.
In Patch ' https://patches.dpdk.org/patch/47562/´as per suggestion Bruce, we have given emphasis on ' Compliation of patches has to be tested using meson'. In my opinion, this is bare minimum one liner, which is required to be executed for any patch before sending.
>
> We could be more explicit about cross-compilation, saying on x86 host, both
> x86 and Arm can be compiled thanks to the cross compilers.
>
I believe this should be covered about compilation section and features.
> More details:
> - s/Compliation/Compilation/
> - the double blank line is removed before next header
>
>
next prev parent reply other threads:[~2019-01-10 16:38 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 4:56 [dpdk-dev] [PATCH v1] " Vipin Varghese
2018-10-30 10:54 ` Bruce Richardson
2018-10-30 14:13 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
2018-10-30 14:18 ` [dpdk-dev] [PATCH v3] " Vipin Varghese
2018-11-14 14:30 ` Kovacevic, Marko
2018-11-24 18:57 ` Thomas Monjalon
2019-01-10 16:37 ` Varghese, Vipin [this message]
2019-01-24 23:05 ` [dpdk-dev] [PATCH v4] doc/patches: " Vipin Varghese
2019-01-28 0:39 ` Thomas Monjalon
2019-01-28 14:27 ` Varghese, Vipin
2019-01-28 14:52 ` Thomas Monjalon
2019-01-28 15:40 ` Varghese, Vipin
2019-01-29 10:10 ` [dpdk-dev] [PATCH v5] " Vipin Varghese
2019-02-12 9:36 ` Thomas Monjalon
2019-02-13 5:38 ` Varghese, Vipin
2019-02-13 5:41 ` [dpdk-dev] [PATCH v6] " Vipin Varghese
2019-02-25 17:12 ` [dpdk-dev] [PATCH v7 0/2] guide to debug and troubleshoot Vipin Varghese
2019-02-25 17:12 ` [dpdk-dev] [PATCH v7 1/2] doc: add svg for debug and troubleshoot guide Vipin Varghese
2019-04-01 14:56 ` Mcnamara, John
2019-04-01 14:56 ` Mcnamara, John
2019-02-25 17:12 ` [dpdk-dev] [PATCH v7 2/2] doc: add guide for debug and troubleshoot Vipin Varghese
2019-04-01 14:56 ` Mcnamara, John
2019-04-01 14:56 ` Mcnamara, John
2019-04-05 8:49 ` Thomas Monjalon
2019-04-05 8:49 ` Thomas Monjalon
2019-04-08 3:18 ` Varghese, Vipin
2019-04-08 3:18 ` Varghese, Vipin
2019-04-08 6:45 ` Thomas Monjalon
2019-04-08 6:45 ` Thomas Monjalon
2019-04-09 6:33 ` Varghese, Vipin
2019-04-09 6:33 ` Varghese, Vipin
2019-04-09 6:33 ` [dpdk-dev] [PATCH v8 0/2] guide to " Vipin Varghese
2019-04-09 6:33 ` Vipin Varghese
2019-04-09 6:33 ` [dpdk-dev] [PATCH v8 1/2] doc: add svg for debug and troubleshoot guide Vipin Varghese
2019-04-09 6:33 ` Vipin Varghese
2019-04-09 6:33 ` [dpdk-dev] [PATCH v8 2/2] doc: add guide for debug and troubleshoot Vipin Varghese
2019-04-09 6:33 ` Vipin Varghese
2019-05-04 22:26 ` [dpdk-dev] [PATCH v8 0/2] guide to " Thomas Monjalon
2019-05-04 22:26 ` Thomas Monjalon
2019-04-01 4:08 ` [dpdk-dev] [PATCH v7 " Varghese, Vipin
2019-04-01 4:08 ` Varghese, Vipin
2019-02-27 11:41 ` [dpdk-dev] [PATCH v6] doc/patches: add meson build to contributing guide Thomas Monjalon
2019-02-27 12:13 ` Varghese, Vipin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2EFA35@BGSMSX101.gar.corp.intel.com \
--to=vipin.varghese@intel.com \
--cc=amol.patel@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=stephen1.byrne@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).