From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <vipin.varghese@intel.com> Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 189EE20BD for <dev@dpdk.org>; Mon, 25 Feb 2019 16:46:47 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Feb 2019 07:46:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,411,1544515200"; d="scan'208";a="302393950" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 25 Feb 2019 07:46:46 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 25 Feb 2019 07:46:46 -0800 Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 25 Feb 2019 07:46:46 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.95]) by BGSMSX102.gar.corp.intel.com ([169.254.2.94]) with mapi id 14.03.0415.000; Mon, 25 Feb 2019 21:16:38 +0530 From: "Varghese, Vipin" <vipin.varghese@intel.com> To: "Mcnamara, John" <john.mcnamara@intel.com>, "Kovacevic, Marko" <marko.kovacevic@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Padubidri, Sanjay A" <sanjay.padubidri@intel.com>, "Patel, Amol" <amol.patel@intel.com> Thread-Topic: [PATCH v6 2/2] doc: add guide for debug and troubleshoot Thread-Index: AQHUyGvSQhKo3HEWdk+xlHQd7u1AeqXwDxsAgACiiGA= Date: Mon, 25 Feb 2019 15:46:36 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D30DB07@BGSMSX101.gar.corp.intel.com> References: <20190121104144.67365-2-vipin.varghese@intel.com> <20190219155719.89443-1-vipin.varghese@intel.com> <20190219155719.89443-3-vipin.varghese@intel.com> <B27915DBBA3421428155699D51E4CFE23F56086D@IRSMSX103.ger.corp.intel.com> In-Reply-To: <B27915DBBA3421428155699D51E4CFE23F56086D@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2MyODE2OTItODQ3Yy00YTMzLWE0MzItMjU5MmQwYmQyZjA5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTmxNM3hTNWxNWTcxNE5kZHQyRGdRckxMS3Z4RXdwQmNUYmhYZkh0ZTlEMUdzTkR3dXZOM3RhZ2F3R1lZTWIrVyJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 2/2] doc: add guide for debug and troubleshoot X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 25 Feb 2019 15:46:48 -0000 Thanks John, I will look into the same ASAP. > -----Original Message----- > From: Mcnamara, John > Sent: Monday, February 25, 2019 5:05 PM > To: Varghese, Vipin <vipin.varghese@intel.com>; Kovacevic, Marko > <marko.kovacevic@intel.com>; thomas@monjalon.net; Yigit, Ferruh > <ferruh.yigit@intel.com>; shreyansh.jain@nxp.com; dev@dpdk.org > Cc: Padubidri, Sanjay A <sanjay.padubidri@intel.com>; Patel, Amol > <amol.patel@intel.com> > Subject: RE: [PATCH v6 2/2] doc: add guide for debug and troubleshoot >=20 >=20 >=20 > > -----Original Message----- > > From: Varghese, Vipin > > Sent: Tuesday, February 19, 2019 3:57 PM > > To: Mcnamara, John <john.mcnamara@intel.com>; Kovacevic, Marko > > <marko.kovacevic@intel.com>; thomas@monjalon.net; Yigit, Ferruh > > <ferruh.yigit@intel.com>; shreyansh.jain@nxp.com; dev@dpdk.org > > Cc: Padubidri, Sanjay A <sanjay.padubidri@intel.com>; Patel, Amol > > <amol.patel@intel.com>; Varghese, Vipin <vipin.varghese@intel.com> > > Subject: [PATCH v6 2/2] doc: add guide for debug and troubleshoot > > > > Add user guide on debugging and troubleshooting for common issues and > > bottleneck found in the sample application model. > > >=20 > Hi, >=20 > Thanks for this. It is a good How-to doc and also a FAQ from customers. >=20 > A couple of minor comments. >=20 >=20 > There is a warning due to one of the header underlines not being long > enough: >=20 > How to develop a custom code to debug? > ------------------------------------- > /work/dpdk_docs/doc/guides/howto/debug_troubleshoot_guide.rst:444: > WARNING: Title underline too short. >=20 > Also, in 2 places the ".. note::" directive is used without a space after= .., like > below: >=20 > > + > > +..note:: > > + > > + It is difficult to cover all possible issues; in a single attempt. >=20 > Also, for the second note you may wish to indent it to the same level as = the > previous paragraph. >=20 > But overall it looks good. >=20 > John