From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8CB32A05DC for ; Mon, 10 Jun 2019 07:14:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 377CB1BDF9; Mon, 10 Jun 2019 07:14:10 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id ED7C31BDDE for ; Mon, 10 Jun 2019 07:14:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jun 2019 22:14:08 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 09 Jun 2019 22:14:07 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 9 Jun 2019 22:14:05 -0700 Received: from bgsmsx106.gar.corp.intel.com (10.223.43.196) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 9 Jun 2019 22:14:05 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.109]) by BGSMSX106.gar.corp.intel.com ([169.254.1.97]) with mapi id 14.03.0415.000; Mon, 10 Jun 2019 10:44:01 +0530 From: "Varghese, Vipin" To: "Richardson, Bruce" , Stephen Hemminger CC: "olivier.matz@6wind.com" , "Pattan, Reshma" , "Wiles, Keith" , "dev@dpdk.org" , "Padubidri, Sanjay A" Thread-Topic: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck Thread-Index: AQHVHJZTSox6wG22SEqA+y7b3zcuwKaOrIWAgADldACABMtD0A== Date: Mon, 10 Jun 2019 05:14:01 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D36604A@BGSMSX101.gar.corp.intel.com> References: <20190606183355.56734-1-vipin.varghese@intel.com> <20190606124927.1a369d5b@hermes.lan> <20190607093042.GB1600@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190607093042.GB1600@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDMxYWVjOWYtNjQxMS00ZWI0LTlkYjktYzczZjg5ZWZkMWVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiT0ErbnRUMzZHaWgxb3YzejNPQzNpNytPVVYwZlF2YjIwM1g4dFh3V1JlT2hmRXU0d3RJa0RJZWJmSlhwNDZycCJ9 dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, June 7, 2019 3:01 PM > To: Stephen Hemminger > Cc: Varghese, Vipin ; olivier.matz@6wind.com; > Pattan, Reshma ; Wiles, Keith > ; dev@dpdk.org; Padubidri, Sanjay A > > Subject: Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue call= abck >=20 > On Thu, Jun 06, 2019 at 12:49:27PM -0700, Stephen Hemminger wrote: > > On Fri, 7 Jun 2019 00:03:54 +0530 > > Vipin Varghese wrote: > > > > > Add callback event handler for enqueue dequeue operation on ring. > > > The pre-enqueue and post-dequeue operation on ring is selected to > > > invoke user callback handler. > > > > > > Signed-off-by: Vipin Varghese > > > --- > > > > NAK > > What is the use case for this? Rings are one of the most used elements > > of DPDK and anything like this will have performance impact. > > > > And as DPDK goes to more of distribution model, all features have to > > be enabled. > > > To add callback handlers to a ring, I'd suggest wrapping the ring as an e= thdev > using the ring pmd, and then using the ethdev callbacks. Thanks Bruce, I will check the same and get back. >=20 > /Bruce