From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7446CA328D for ; Tue, 22 Oct 2019 04:49:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1994C1BE93; Tue, 22 Oct 2019 04:49:03 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id EE3DF5B3E for ; Tue, 22 Oct 2019 04:49:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2019 19:48:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,325,1566889200"; d="scan'208";a="348922535" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 21 Oct 2019 19:48:59 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 21 Oct 2019 19:48:59 -0700 Received: from bgsmsx105.gar.corp.intel.com (10.223.43.197) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 21 Oct 2019 19:48:59 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.199]) by BGSMSX105.gar.corp.intel.com ([169.254.3.227]) with mapi id 14.03.0439.000; Tue, 22 Oct 2019 08:18:55 +0530 From: "Varghese, Vipin" To: Pavan Nikhilesh Bhagavatula , "Jerin Jacob Kollanukkaran" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "Kovacevic, Marko" , "Ori Kam" , "Nicolau, Radu" , "Akhil Goyal" , "Kantecki, Tomasz" , Sunil Kumar Kori CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v6 09/10] examples/l2fwd-event: add graceful teardown Thread-Index: AQHVgrynGoRuD5GrqUiKl0IPOofGY6dkc1zggACL24CAAQFfkA== Date: Tue, 22 Oct 2019 02:48:55 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D3DE2B5@BGSMSX101.gar.corp.intel.com> References: <20191002205754.11746-1-pbhagavatula@marvell.com> <20191014182247.961-1-pbhagavatula@marvell.com> <20191014182247.961-10-pbhagavatula@marvell.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D3DCA46@BGSMSX101.gar.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDJhYWQyOWUtODJjNi00N2NhLWE2ZjQtZmM3ZDFiOTdlM2ZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYVBRZzN0eWZ4ZnZ4SHppMTRLa0FDU3luUXpkYkJkT3d4WjhFS1kwSnJCWDgySFU1WFFYcDVTUjdPcitDTEUwNyJ9 dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 09/10] examples/l2fwd-event: add graceful teardown X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pavan, snipped > >> Add graceful teardown that addresses both event mode and poll > >mode. > >> > >> Signed-off-by: Pavan Nikhilesh > >> --- > >snipped > >> + if (rsrc->event_mode) { > >> + struct l2fwd_event_resources *evt_rsrc =3D > >> + rsrc->evt_rsrc; > >> + for (i =3D 0; i < evt_rsrc->rx_adptr.nb_rx_adptr; i++) > >> + rte_event_eth_rx_adapter_stop( > >> + evt_rsrc->rx_adptr.rx_adptr[i]); > >Question from my end, for a graceful tear down first we stop the RX > >adapter then ensure after all events from worker are either dropped or > >transmit. Then we continue to TX adapter is stop. Is this right way? >=20 > The general rule of thumb is to stop producers before consumers. >=20 > >> + for (i =3D 0; i < evt_rsrc->tx_adptr.nb_tx_adptr; i++) > >> + rte_event_eth_tx_adapter_stop( > >> + evt_rsrc->tx_adptr.tx_adptr[i]); > >Should we call `rte_cleanup` to clean up the service core usage? >=20 > Since we are exiting from here I don't think we explicitly need to do a c= leanup of > service config. As I recollect in dpdk 18.11, there was a bug and fix done for service core= cleanup with `rte_cleanup`. If this taken care implicity 19.11, then yes y= ou are right there is no need of `rte_celanup` when service cores are in us= e. >=20 > > > >> } > >> printf("Bye...\n"); > >> > >> -- > >> 2.17.1