From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D057CA328D for ; Tue, 22 Oct 2019 04:57:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 53196316B; Tue, 22 Oct 2019 04:57:15 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8F8BB2D13 for ; Tue, 22 Oct 2019 04:57:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2019 19:57:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,325,1566889200"; d="scan'208";a="348924069" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 21 Oct 2019 19:57:12 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 21 Oct 2019 19:57:12 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 21 Oct 2019 19:57:11 -0700 Received: from bgsmsx109.gar.corp.intel.com (10.223.4.211) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 21 Oct 2019 19:57:11 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.199]) by BGSMSX109.gar.corp.intel.com ([169.254.10.209]) with mapi id 14.03.0439.000; Tue, 22 Oct 2019 08:27:09 +0530 From: "Varghese, Vipin" To: Pavan Nikhilesh Bhagavatula , "Jerin Jacob Kollanukkaran" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v6 00/10] example/l2fwd-event: introduce l2fwd-event example Thread-Index: AQHVgrx9eJpZ2lvPeEOLAZY7l5+hUKdkd/lQgACJBYCAAQAdQA== Date: Tue, 22 Oct 2019 02:57:08 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D3DE2D0@BGSMSX101.gar.corp.intel.com> References: <20191002205754.11746-1-pbhagavatula@marvell.com> <20191014182247.961-1-pbhagavatula@marvell.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D3DCA77@BGSMSX101.gar.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmNmZGExYzUtOTYwMC00YmI1LWFmNjMtNGZjZjg1NGI4YTEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS0hBTWNudE5tUXhCelQ2S1wvRThUcE1XWWpGak1BMGsyR2Znd0VKSEp2K1RhOExoMUtzSUNZc2pua21hdmJOQ00ifQ== dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 00/10] example/l2fwd-event: introduce l2fwd-event example X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pavan, snipped > >> > >> Based on event device capability the configuration is done as follows: > >> - A single event device is enabled. > >> - The number of event ports is equal to the number of worker > >> cores enabled in the core mask. Additional event ports might > >> be configured based on Rx/Tx adapter capability. > >> - The number of event queues is equal to the number of ethernet > >> ports. If Tx adapter doesn't have internal port capability then > >> an additional single link event queue is used to enqueue events > >> to Tx adapter. > >1. Are we support per port function as 'mac_updating' and > >'non_macupdating'? > No, its global. Thanks for confirming, so all ports behaviour are affected by this flag. >=20 > >2. If no for above, why is that each port should have ` number of event > >queues is equal to the number of ethernet`? >=20 > It's not a quantifier of each port, It across the eventdevice that the nu= mber of > event queues is equal to number of ethdevices used. >=20 > This is to prevent event queues being overcrowded i.e. in case there is o= nly one > event queue and multiple Eth devices then SW/HW will have a bottleneck in > enqueueing all the mbufs to a single event queue. Yes you are correct, but here is my confusion=20 1. let us assume there are 2 ports, ie: port 0 <=3D=3D> port 1. 2. We have 4 workers and 2 event queue (2 ports, so Q-0 for port-0 and Q-11= for port-1) 3. The event mode (SW or HW) is parallel. 4. In this case we need to rely of Q-2 which can absorb the events for sing= le-event TX adapter for L2FWD_EVENT_TX_ENQ. 5. But for L2FWD_EVENT_TX_DIRECT (which is to send packets out directly) th= is is not right form as multiple parallel workers may concurrently send out= same destination port queue (as there is 1 TX configured). Can you help me understand, how this is worked around? >=20 > >3. With this work for vdev ports, if no are we adding check for the > >same in `main` function? >=20 > I have verified the functionality for --vdev=3Devent_sw0 and it seems to = work fine. Thanks, so whether it is physical or virtual ethernet device all packets ha= s to come to worker cores for 'no-mac-updating'. >=20 > > > >snipped