Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library

["Shah, Rahul R" <rahul.r.shah@intel.com>]

Thanks Bruce,

I confirmed both points. 

1. eventdev is listed before port 
2. librte_port/meson.build file has this patch added already.

Thanks,
Rahul

-----Original Message-----
From: Bruce Richardson [mailto:bruce.richardson@intel.com] 
Sent: Monday, November 4, 2019 4:54 PM
To: Yigit, Ferruh <ferruh.yigit@intel.com>
Cc: Shah, Rahul R <rahul.r.shah@intel.com>; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>; Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library

On Thu, Oct 31, 2019 at 05:03:09PM +0000, Ferruh Yigit wrote:
> On 10/1/2019 7:05 PM, Rahul Shah wrote:
> > Adding a new port type called eventdev to the rte_port library.
> > 
> > Signed-off-by: Rahul Shah <rahul.r.shah@intel.com>
> > ---
> >  lib/librte_port/Makefile             |   4 +-
> >  lib/librte_port/meson.build          |   8 +-
> >  lib/librte_port/rte_port_eventdev.c  | 585 
> > +++++++++++++++++++++++++++  lib/librte_port/rte_port_eventdev.h  | 100 +++++
> >  lib/librte_port/rte_port_version.map |   9 +
> >  5 files changed, 702 insertions(+), 4 deletions(-)  create mode 
> > 100644 lib/librte_port/rte_port_eventdev.c
> >  create mode 100644 lib/librte_port/rte_port_eventdev.h
> > 
> > diff --git a/lib/librte_port/Makefile b/lib/librte_port/Makefile 
> > index 1b83f6f2b..de6f0428a 100644
> > --- a/lib/librte_port/Makefile
> > +++ b/lib/librte_port/Makefile
> > @@ -11,7 +11,7 @@ ifeq ($(CONFIG_RTE_PORT_PCAP),y)  LDLIBS += -lpcap  
> > endif  LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev 
> > -LDLIBS += -lrte_ip_frag -lrte_sched -lrte_cryptodev
> > +LDLIBS += -lrte_ip_frag -lrte_sched -lrte_cryptodev -lrte_eventdev
> 
> This creates a dependency form 'librte_port' to 'librte_eventdev', 
> this dependency should be reflected to the build system, so that 'librte_eventdev'
> have built before 'librte_port'
> This is done via 'lib/Makefile' in make build but not sure how to do in meson.
> 
1. Ensure that eventdev is listed before port in the libs/meson.build file.
   Since there is no parallelism in meson runs, only when using ninja,
   you just need to place the libs in the order you want them processed.
2. To have the library linkage and header path setup correct, add
   "eventdev" to the "deps" variable in the librte_port/meson.build file.

/Bruce