From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DE79A0352; Mon, 4 Nov 2019 13:03:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F5FD37A2; Mon, 4 Nov 2019 13:03:28 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 8A154374C for ; Mon, 4 Nov 2019 13:03:26 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Nov 2019 04:03:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,267,1569308400"; d="scan'208";a="402954077" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 04 Nov 2019 04:03:24 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 Nov 2019 04:03:24 -0800 Received: from fmsmsx122.amr.corp.intel.com ([169.254.5.107]) by fmsmsx101.amr.corp.intel.com ([169.254.1.3]) with mapi id 14.03.0439.000; Mon, 4 Nov 2019 04:03:24 -0800 From: "Shah, Rahul R" To: "Richardson, Bruce" , "Yigit, Ferruh" CC: "Dumitrescu, Cristian" , "dev@dpdk.org" , "Singh, Jasvinder" , "Thomas Monjalon" Thread-Topic: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library Thread-Index: AQHVkA0dDvt11bmpBEaechG3mgxCXqd7atQA//+Cz4A= Date: Mon, 4 Nov 2019 12:03:23 +0000 Message-ID: <4DAF8D815EA7614683D9B9071A032C699742B330@fmsmsx122.amr.corp.intel.com> References: <20191001180526.3259-1-rahul.r.shah@intel.com> <2d6827ec-3aba-e5da-2793-c4abbc188dc9@intel.com> <20191104112424.GD1356@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20191104112424.GD1356@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmNmYTBhYTEtMTVkMy00YmYyLThmNTItMmU5MzI1YzI0YjhjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidndQMU9JckY4VGIzVnNwa05TR1k0d3lZWHBrcldmWWc0VHd4Q1hPWlJKUW5cL0pFOGtPdmZueUZPc1VIa1pDXC9CIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.1.200.108] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks Bruce, I confirmed both points.=20 1. eventdev is listed before port=20 2. librte_port/meson.build file has this patch added already. Thanks, Rahul -----Original Message----- From: Bruce Richardson [mailto:bruce.richardson@intel.com]=20 Sent: Monday, November 4, 2019 4:54 PM To: Yigit, Ferruh Cc: Shah, Rahul R ; Dumitrescu, Cristian ; dev@dpdk.org; Singh, Jasvinder ; Thomas Monjalon Subject: Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the= rte_port library On Thu, Oct 31, 2019 at 05:03:09PM +0000, Ferruh Yigit wrote: > On 10/1/2019 7:05 PM, Rahul Shah wrote: > > Adding a new port type called eventdev to the rte_port library. > >=20 > > Signed-off-by: Rahul Shah > > --- > > lib/librte_port/Makefile | 4 +- > > lib/librte_port/meson.build | 8 +- > > lib/librte_port/rte_port_eventdev.c | 585=20 > > +++++++++++++++++++++++++++ lib/librte_port/rte_port_eventdev.h | 100= +++++ > > lib/librte_port/rte_port_version.map | 9 + > > 5 files changed, 702 insertions(+), 4 deletions(-) create mode=20 > > 100644 lib/librte_port/rte_port_eventdev.c > > create mode 100644 lib/librte_port/rte_port_eventdev.h > >=20 > > diff --git a/lib/librte_port/Makefile b/lib/librte_port/Makefile=20 > > index 1b83f6f2b..de6f0428a 100644 > > --- a/lib/librte_port/Makefile > > +++ b/lib/librte_port/Makefile > > @@ -11,7 +11,7 @@ ifeq ($(CONFIG_RTE_PORT_PCAP),y) LDLIBS +=3D -lpcap = =20 > > endif LDLIBS +=3D -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev=20 > > -LDLIBS +=3D -lrte_ip_frag -lrte_sched -lrte_cryptodev > > +LDLIBS +=3D -lrte_ip_frag -lrte_sched -lrte_cryptodev -lrte_eventdev >=20 > This creates a dependency form 'librte_port' to 'librte_eventdev',=20 > this dependency should be reflected to the build system, so that 'librte_= eventdev' > have built before 'librte_port' > This is done via 'lib/Makefile' in make build but not sure how to do in m= eson. >=20 1. Ensure that eventdev is listed before port in the libs/meson.build file. Since there is no parallelism in meson runs, only when using ninja, you just need to place the libs in the order you want them processed. 2. To have the library linkage and header path setup correct, add "eventdev" to the "deps" variable in the librte_port/meson.build file. /Bruce