From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <matvejchikov@gmail.com>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id 40D471D8E
 for <dev@dpdk.org>; Wed,  6 Dec 2017 15:02:25 +0100 (CET)
Received: by mail-wm0-f44.google.com with SMTP id n138so7384165wmg.2
 for <dev@dpdk.org>; Wed, 06 Dec 2017 06:02:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:content-transfer-encoding:mime-version:subject:message-id:date
 :cc:to; bh=57ibyRXRajTljntvg6uvL4iPQut0N1kkmhE7PEiM4Lc=;
 b=fTDq6l2SdBXUmSk/dczbLAV//crjVicsVsCIt+b8dehaBhH9TDjxjOotWCGiOXRm+s
 lRFK9mIWdAUHNroclpuftR1a54a4RdkStXLILSCCVnUuFQVTaCaBw2UrYhHU643uVTW+
 PsaadfzpY2ApMqk8V/mWxs3BwoaP8lLoTSkN96NWlLsr8fe/IwBnNP0KtigD8GdMeIke
 VWM5/M+x8BYlQX2mmaGp/oILZoRDButl1fDdNK3fdqg2vJW5207nFOdadqd0gr+nZ8Q2
 PGI14qY42jJ/mKDkkcGZj4T4eY0THd+fetPurgRtQc0IJa5B11OK2JX9eSzB69RVSNr1
 89Wg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:content-transfer-encoding:mime-version
 :subject:message-id:date:cc:to;
 bh=57ibyRXRajTljntvg6uvL4iPQut0N1kkmhE7PEiM4Lc=;
 b=OrDwTaiD4zZ4e0F4FyYZ0MO1Zoz8RWtzFfmkGflBoTPe2zY1XIxod5vyCZF9EWyWwU
 PuxHsJSO5Hc/fTbXGW8+0NL9JArczz7rP3AxQJWd8WmZn2xLdJeqK917wJ782Jr5vkg3
 Sw87o0SKuXf2oebRp0Qeu+cz481cl4tHOj/l9fM46J/+syYjM1QP0s9lr+zchfktUY0r
 jFQ0pc5bQqF3XqPrbPiSqtPYFiiG2EYZy01rwrLtW5VQMGcT0C/gUks4Japzq+i9wEMY
 8Cm3HV1b/K/RJNE8zhXQXc9yrEYJ0FJwPJSDwQSjXMqL9pCzF2zYttZdMUguEbsshe6t
 C6sg==
X-Gm-Message-State: AKGB3mJOYZ6OUS2Tq9aOHf70mznEisNmZhF10ghzNsZnf3oQHnIte4xn
 ATp6jaGF8Izlf+BH1i/G+AcDiqGt
X-Google-Smtp-Source: AGs4zMa/fpuOjALwMkAaRcPfMtJN6UK235a4b5zdrcnppPyAP1FBqaxg8mCk/84fcQ9uy5egPNP/Iw==
X-Received: by 10.28.127.197 with SMTP id a188mr12547480wmd.138.1512568944638; 
 Wed, 06 Dec 2017 06:02:24 -0800 (PST)
Received: from [10.61.0.167] (bba193485.alshamil.net.ae. [217.165.96.191])
 by smtp.gmail.com with ESMTPSA id j125sm3488487wmd.24.2017.12.06.06.02.23
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 06 Dec 2017 06:02:23 -0800 (PST)
From: Ilya Matveychikov <matvejchikov@gmail.com>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\))
Message-Id: <4F9781B2-338C-4154-BDA1-BC24D1B2B689@gmail.com>
Date: Wed, 6 Dec 2017 18:02:21 +0400
Cc: jiayu.hu@intel.com
To: dev@dpdk.org
X-Mailer: Apple Mail (2.3445.4.7)
Subject: [dpdk-dev] A question about GRO neighbor packet matching
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Dec 2017 14:02:25 -0000

Hello all,


My question is about neighbor packet matching algorithm for TCP. Is it
correct to expect that IP packets should have continuous ID enumeration
(i.e. iph-next.id = iph-prev.id + 1)?

~~~
lib/librte_gro/gro_tcp4.c:check_seq_option()
	...
	/* check if the two packets are neighbors */
	tcp_dl0 = pkt0->pkt_len - pkt0->l2_len - pkt0->l3_len - tcp_hl0;
	if ((sent_seq == (item->sent_seq + tcp_dl0)) &&
			(ip_id == (item->ip_id + 1)))
		/* append the new packet */
		return 1;
	else if (((sent_seq + tcp_dl) == item->sent_seq) &&
			((ip_id + item->nb_merged) == item->ip_id))
		/* pre-pend the new packet */
		return -1;
	else
		return 0;
~~~

As per RFC791:

  Identification:  16 bits

    An identifying value assigned by the sender to aid in assembling the
    fragments of a datagram.