From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CA6B43A2A; Wed, 7 Feb 2024 04:13:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E3FA40E8A; Wed, 7 Feb 2024 04:13:17 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2083.outbound.protection.outlook.com [40.107.92.83]) by mails.dpdk.org (Postfix) with ESMTP id 1ECC540274 for ; Wed, 7 Feb 2024 04:13:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SvhQeEBcZFAQmOwBHdLf7+tbN41zORxE9tRJ0vml7Novloo2B4YkCD835trE398Y7qbImTkbIeZf68gjDAqPZRfRBbDiNMdh1FerUMx0TBanzFZzeTz3RWRU55wOyojZCUqCB6UFgOOwN4D+uzapBCoUWZIPuBeChyQagBQCtHWNmWpcOTMakLg65InEdhgjGhIWJLcrob6Aqxos32o33Pu18fv7t+za+YvIXr8fVTwZIR0fFhhtEKpdmpki7V29D0LiRIsPV3V/wMkd6hXdsdg7QHV81hzUCyAvDzFffy3Kgqi9NdE7Lv9UI1+2UJsY16n7NTuyrwMdrQBGIR+F7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wx8k5wTdB9OPG4jdY3+JWA/YeRNRUer3fJdScLDLwKg=; b=IRsQbrcOrozF/av+069q7+I9VWotZNIbYh/aEo+1/vxGELNTTS3A8KpDYvEyDsqNanrnQO6bG8SO8Hw80QT8dxJiTuRfUVbpP1mGO8vbtx5jsvjOnz3do9yuag2EMynkADHapLMb52QoIr9SjK1U5yEj3S3cnRmDldydW3dGqz1Mmr/r5yy5b24dbu6WUh+V1JdCDymGsWYUswg5RllzLEDrLCCbPnPqaQRQqIfDDmLx07HrT+7BGY3+m2kGST8I0sRmjuF3KdDgOdGmPtQAXNSHZo2/sXeNCV7YzOlBpbOsXKln6HS9wnW52sKtKHhzBN9j2lDZauCn00xwH6JwcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wx8k5wTdB9OPG4jdY3+JWA/YeRNRUer3fJdScLDLwKg=; b=PYUromdlE5fbHbtzk5B9NyQ2bNGpLKSdNOz4d9H0aObDdkd5PJGNTDpYWkM5HWQOZI+GrqQBd75BrcG+PWL21tp5xvLHF9xojvYsAYaign1KwmRgtoSCq2XB8GFb6BjXo5l+VhJLZzCf4FIhuc9p+DkV7JVI0dVQ5K9o52auOiY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CYYPR12MB9014.namprd12.prod.outlook.com (2603:10b6:930:bf::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.14; Wed, 7 Feb 2024 03:13:13 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7270.016; Wed, 7 Feb 2024 03:13:13 +0000 Message-ID: <4a0e5000-3ae3-4894-a23d-715801f3c3b7@amd.com> Date: Wed, 7 Feb 2024 03:13:08 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] net/txgbe: add vectorized functions for Rx/Tx Content-Language: en-US To: Jiawen Wu , dev@dpdk.org References: <20240201030019.21336-1-jiawenwu@trustnetic.com> <20240201030019.21336-2-jiawenwu@trustnetic.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240201030019.21336-2-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0688.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:37b::17) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CYYPR12MB9014:EE_ X-MS-Office365-Filtering-Correlation-Id: a940db96-6daf-452e-ba77-08dc278ab85f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uwHgtGn0S4+tvZLVoQ9E2YycHy55wMka9+b0QM8n22qOVGxIZ4O4IvPq8FegUtLzo3EGnhucY2l+eoZJOpQLMcA54D2GjGQBfNeo5OQv3J84RFH3CLkd90b5/PSH1dxsCZdq/NhdBPTLVoGpl2bCmeISKCejZikjiAVNLAbmhVzSDAIW4ErUoeg78euft+aKp7azf2D3y2Z7/S/5FX+J8BsFOnWMCsjtrB9PgHdgue0R2xN7/ocpJD8Y3KQxyzAqtO4AY1ruM/PXCcVXcLPf+P69NSpBWMllSS6JLGXtyy/CgiipvnOgPYlRtxjG4mhsCBtbaGzPGC9lSiRcpj734H8nIKmozZBI0bc49zOCKC7a3L+rBaoKkQMqzq0M04apJ7dAeiVeS1ErL83+pu9gKfE68H7392YlkZ5pxSruajsc8SRDLt6qxc4vCKE/Oqlt8wZU/6gNENW5WK/xaKc3gwJgPUp6ke0mMYnbk2loMR4MjhzIBWTkA3SPW4MJ5ZGNqYuiTwCX8+cFC0MGkHGKqNYz6ivcBiR7YjYAA7cQBVJWZKV6uCXR1uhKryT3TCZFmtjfYowdIua4Hh4eSDK45RRUDDG6+HrA4sAQ90yZyRcd0e0dci5WGb71uE3JhSVM0M1Qrh3vo96ZuxYUTrWTGA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(396003)(346002)(376002)(136003)(366004)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(6506007)(6486002)(86362001)(2616005)(31696002)(26005)(31686004)(53546011)(316002)(66476007)(66556008)(6512007)(66946007)(6666004)(478600001)(83380400001)(38100700002)(8936002)(44832011)(8676002)(36756003)(41300700001)(2906002)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tzl0d0E4Mysrbm9iN3Axeko3d05vYjNFUXM0WjcyRVJhbWR3SFE1V25NNHFQ?= =?utf-8?B?eVNVYTNiQm0rSXhyNVBwMTgxd0lYZUZJQ0dQcmY3b1NWYXkxU3hEemNrQW1E?= =?utf-8?B?QVl4c2ppVkNhT3pkM3dqc1FaTjB0Nkh2OGRod3FNajRqY1RQb2VmVzhzZVNk?= =?utf-8?B?NXlEaVlHL3hOaHhNN3lwTURma1d2T0piQjhFM2tBVWpFa2xGcHIwaE1WUTNo?= =?utf-8?B?MW9ud0VsbGN4TTZ1akVvMkp5TStSQU1hZi9ZaDl1TDNOaklqMVVJdDd5QzJT?= =?utf-8?B?TWd6VWdyNy96ODJZN3U1dXlRZ1pmaHFJWnExbWg2M2JtUSs3ZTNZZDMxM0xX?= =?utf-8?B?MjhQb1RmbnlDckNMancrOEZZVmd4clFJZWdYNnpKZnQ4TU5QVUNybmJ5czZk?= =?utf-8?B?VWxRNGpmLzgyckx3MkZXSEpBbFg1OUdxWGs4bEt1TVdTK1M3NWJaS2FVbXFa?= =?utf-8?B?OGswUm9yTWRyYWVMZzVKKzRtRkhuZmtBYy8xbVhCcVA0UHdyMDZ2K25QNEN6?= =?utf-8?B?RHZadjF5aWhBN29hZEllNndtcG5TQUFhWG5MdWlvOVoyZWZWa2xydnljMlZq?= =?utf-8?B?OVBjVlhBVTMrd1ZyMW50ZzFQbE9tMGhXb0x2YkZ2dk9nOG5HYWk4WGtKZGl6?= =?utf-8?B?elBaeWhaVURKUWZtNzBYQmtnMDA4bEZsTkQ4eGpOY2VlRnZWQUxNZy9RWGVG?= =?utf-8?B?NHpBRURnSzJKS3V5UEtrazJEZjZyTEdLOWw4MTNTLzFCSXFYemtUNUJUT3Jh?= =?utf-8?B?bTYzdVlSZVdiUWFkbk9DL2pLSlAvYy9xcUJMWS90UVowZVJubWE4OUl4THNi?= =?utf-8?B?aTJJaDVORFh2MTJwN01KTE4zMUNHbVo1ZkhTUmZwMGJ4OWtNMHdET0VQK3I2?= =?utf-8?B?YkhIckxqN1VvNXVWYncxLzkrbklscWs2R3BQV3VxRlo3ajdENjBoam55MkVw?= =?utf-8?B?ZUhRMGp0TS9iUkp1TGNjbEJpWWRrOFVBUnlzRkpHYjBaNGJiQTBKL1V2OXlC?= =?utf-8?B?enBscW44Ykx2UkM3Z1V6cE51TUNyVmdvUXhZRmJEUGh6cUwzOVlSekU1QUJU?= =?utf-8?B?V2RyZlFsbWNVZk5UT2ZlWmwrLzl3cXVVQTA4Tm5IeXovdnA1YjZ3UmZ5bnkx?= =?utf-8?B?TnhndzFxaWx0Y1JMcmN4a1JXZlFZV2VwM3N0M2pNNmpUUjBLVkVKUSs5U2Vw?= =?utf-8?B?bFFqV292WUE1VXg0bVJ5N0d5THdCaE9vZm9yRitNUXJJeUlaanNIUTIzNHFU?= =?utf-8?B?Q2JVUSttUHJ4ZTBOYUhiYkRHblpvcFc2T3BkUHY5STRqdDRlcFB5d0QwdDZR?= =?utf-8?B?cWMrYVlJZFh3VUYxN0xCdnlRVlBrVi9YV1JyelF2a0U4UmdkamlQR2FKeDZv?= =?utf-8?B?SFVkVUJZM2F5alhWamdhRVRSOWVka3VPazl4UEkrTE5naXgzQjVYbFphTzc2?= =?utf-8?B?WkpxZml4QStqVzZuWklJMHljMmFmU0FXakNxbGhReEVQbEY0ejczOGl1bUR4?= =?utf-8?B?ME1BZVlVVnRrajBGKzd1eG9VTHhsME1OOFRQVkt3T3FuaXB3UTg1bDRMYWR5?= =?utf-8?B?Qm5tMURUK2NleStQVk11ZFozOStLZ0hralI3bU1GNXNDSm8zTVdETmsza0lO?= =?utf-8?B?ajZoVC84NU5ZdlRhQzFhbSsybEJ5QUE2dmpjTTNsNURQd0lxaXZQbUhJSUpS?= =?utf-8?B?YzJydEZPL3d1dGhjaDRydEtaOG1RdGR0Yk9RMmczdGxYVmhSZjc0U3h1RG1x?= =?utf-8?B?OURxNC9sMnFXTWUvY1dPdE5FczZ0YkFzTXl6ZDJYTTRXWThqSktJdVU2YWF4?= =?utf-8?B?N1cvUFkvUUpvaEJObmlMcEtkajFBQmltQUdUMEo2TTVCa2NGTjhockJBSEhB?= =?utf-8?B?bytpRks3b2pHUU8vL0V4SjZ0VXVoczRNbUlTdFJLWWxMamVBd3l2bjY1NE1S?= =?utf-8?B?Q0c1V2FrMEtOVDltNEROK0l2L0o3Qnk1ZUhiR1cxWnZESmRlYmlXSGJ0alho?= =?utf-8?B?RFFjS09DOFA0RkkwWG94aTMyV2Vob2Q1QVYzUEtnNnNTVXFWMU9BTVRvNUxa?= =?utf-8?B?ZWRWdkwwbHdGMDlMdUg3bTZPcnJlUVIvUGkzYXY3ZTJMdkwveDh0bUUraEs4?= =?utf-8?Q?cTuLFWVoLrxLCF+xBfcdchUGj?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a940db96-6daf-452e-ba77-08dc278ab85f X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 03:13:13.4456 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hQtMSabAmKGUqy6Zd+ekuPxtfE8dBRQxCvkt98sUZMDpEu7aSXwjG80qDT21F8lR X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB9014 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/1/2024 3:00 AM, Jiawen Wu wrote: > To optimize Rx/Tx burst process, add SSE/NEON vector instructions on > x86/arm architecture. > Do you have any performance improvement number with vector implementation, if so can you put it into commit log for record? > Signed-off-by: Jiawen Wu > --- > drivers/net/txgbe/meson.build | 6 + > drivers/net/txgbe/txgbe_ethdev.c | 6 + > drivers/net/txgbe/txgbe_ethdev.h | 1 + > drivers/net/txgbe/txgbe_ethdev_vf.c | 1 + > drivers/net/txgbe/txgbe_rxtx.c | 150 ++++- > drivers/net/txgbe/txgbe_rxtx.h | 18 + > drivers/net/txgbe/txgbe_rxtx_vec_common.h | 301 +++++++++ > drivers/net/txgbe/txgbe_rxtx_vec_neon.c | 604 ++++++++++++++++++ > drivers/net/txgbe/txgbe_rxtx_vec_sse.c | 736 ++++++++++++++++++++++ > 9 files changed, 1817 insertions(+), 6 deletions(-) > create mode 100644 drivers/net/txgbe/txgbe_rxtx_vec_common.h > create mode 100644 drivers/net/txgbe/txgbe_rxtx_vec_neon.c > create mode 100644 drivers/net/txgbe/txgbe_rxtx_vec_sse.c > > diff --git a/drivers/net/txgbe/meson.build b/drivers/net/txgbe/meson.build > index 14729a6cf3..ba7167a511 100644 > --- a/drivers/net/txgbe/meson.build > +++ b/drivers/net/txgbe/meson.build > @@ -24,6 +24,12 @@ sources = files( > > deps += ['hash', 'security'] > > +if arch_subdir == 'x86' > + sources += files('txgbe_rxtx_vec_sse.c') > +elif arch_subdir == 'arm' > + sources += files('txgbe_rxtx_vec_neon.c') > +endif > + > includes += include_directories('base') > > install_headers('rte_pmd_txgbe.h') > diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c > index 6bc231a130..2d5b935002 100644 > --- a/drivers/net/txgbe/txgbe_ethdev.c > +++ b/drivers/net/txgbe/txgbe_ethdev.c > @@ -1544,6 +1544,7 @@ txgbe_dev_configure(struct rte_eth_dev *dev) > * allocation Rx preconditions we will reset it. > */ > adapter->rx_bulk_alloc_allowed = true; > + adapter->rx_vec_allowed = true; > > return 0; > } > @@ -2735,6 +2736,11 @@ txgbe_dev_supported_ptypes_get(struct rte_eth_dev *dev) > dev->rx_pkt_burst == txgbe_recv_pkts_bulk_alloc) > return txgbe_get_supported_ptypes(); > > +#if defined(RTE_ARCH_X86) || defined(__ARM_NEON) > + if (dev->rx_pkt_burst == txgbe_recv_pkts_vec || > + dev->rx_pkt_burst == txgbe_recv_scattered_pkts_vec) > + return txgbe_get_supported_ptypes(); > +#endif > Sometimes the packet parsing capability of the device changes based on vector Rx used, but above calls same function. If there is no ptype parsing capability difference, why not just add above checks to previous if block? Btw, 'txgbe_get_supported_ptypes()' now gets a parameter, based on changes in 'next-net', can you please rebase code on top of latest next-net? <...> > @@ -2198,8 +2220,15 @@ txgbe_set_tx_function(struct rte_eth_dev *dev, struct txgbe_tx_queue *txq) > #endif > txq->tx_free_thresh >= RTE_PMD_TXGBE_TX_MAX_BURST) { > PMD_INIT_LOG(DEBUG, "Using simple tx code path"); > - dev->tx_pkt_burst = txgbe_xmit_pkts_simple; > dev->tx_pkt_prepare = NULL; > + if (txq->tx_free_thresh <= RTE_TXGBE_TX_MAX_FREE_BUF_SZ && > + (rte_eal_process_type() != RTE_PROC_PRIMARY || > Why vector Tx enable only for secondary process? <...> > @@ -297,6 +299,12 @@ struct txgbe_rx_queue { > #ifdef RTE_LIB_SECURITY > uint8_t using_ipsec; > /**< indicates that IPsec RX feature is in use */ > +#endif > + uint64_t mbuf_initializer; /**< value to init mbufs */ > + uint8_t rx_using_sse; > +#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM) > RTE_ARCH_ARM, RTE_ARCH_ARM64 & __ARM_NEON seems used interchangable, what do you think to stick one? Similarly with RTE_ARCH_X86_64 & RTE_ARCH_X86. <...> > +++ b/drivers/net/txgbe/txgbe_rxtx_vec_neon.c > @@ -0,0 +1,604 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2015-2024 Beijing WangXun Technology Co., Ltd. > + * Copyright(c) 2010-2015 Intel Corporation > + */ > + > +#include > +#include > +#include > + > +#include "txgbe_ethdev.h" > +#include "txgbe_rxtx.h" > +#include "txgbe_rxtx_vec_common.h" > + > +#pragma GCC diagnostic ignored "-Wcast-qual" > + Is this pragma really required?