DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Sam <batmanustc@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Where is the padding code in DPDK?
Date: Wed, 14 Nov 2018 10:17:49 +0000	[thread overview]
Message-ID: <4a1e4ea9-e75a-0615-dcc8-c762817f4d2e@intel.com> (raw)
In-Reply-To: <CAOE=1Z2ExdoLMgOjvCY6GFHSwKrfXMD19c7D+XXz_90SOBg8Yg@mail.gmail.com>

On 14-Nov-18 5:45 AM, Sam wrote:
> OK, then shortly speaking, DPDK will NOT care about padding.
> NIC will care about padding while send and recv with NIC.
> kernel will care about while send and recv with vhostuser port.
> 
> Is that right?

I cannot speak for virtio/vhost user since i am not terribly familiar 
with them. For regular packets, generally speaking, packets shorter than 
60 bytes are invalid. Whether DPDK does or does not care about padding 
is irrelevant, because *you* are attempting to transmit packets that are 
not valid. You shouldn't rely on this behavior.

> 
> 
> Burakov, Anatoly <anatoly.burakov@intel.com 
> <mailto:anatoly.burakov@intel.com>> 于2018年11月13日周二 下午5:29写道:
> 
>     On 13-Nov-18 7:16 AM, Sam wrote:
>      > Hi all,
>      >
>      > As we know, ethernet frame must longer then 64B.
>      >
>      > So if I create rte_mbuf and fill it with just 60B data, will
>      > rte_eth_tx_burst add padding data, let the frame longer then 64B
>      >
>      > If it does, where is the code?
>      >
> 
>     Others can correct me if i'm wrong here, but specifically in case of
>     64-byte packets, these are the shortest valid packets that you can
>     send,
>     and a 64-byte packet will actually carry only 60 bytes' worth of packet
>     data, because there's a 4-byte CRC frame at the end (see Ethernet frame
>     format). If you enabled CRC offload, then your NIC will append the 4
>     bytes at transmit. If you haven't, then it's up to each individual
>     driver/NIC to accept/reject such a packet because it can rightly be
>     considered malformed.
> 
>     In addition, your NIC may add e.g. VLAN tags or other stuff, again
>     depending on hardware offloads that you have enabled in your TX
>     configuration, which may push the packet size beyond 64 bytes while
>     having only 60 bytes of actual packet data.
> 
>     -- 
>     Thanks,
>     Anatoly
> 


-- 
Thanks,
Anatoly

  reply	other threads:[~2018-11-14 10:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13  7:16 Sam
2018-11-13  7:17 ` Sam
2018-11-13  7:22   ` Sam
2018-11-13  9:29 ` Burakov, Anatoly
2018-11-14  5:45   ` Sam
2018-11-14 10:17     ` Burakov, Anatoly [this message]
2018-11-14 10:51       ` Morten Brørup
2018-11-14 16:19         ` Wiles, Keith
2018-11-15  2:07           ` Sam
2018-11-15  2:13             ` Sam
2018-11-15 10:06             ` Burakov, Anatoly
2018-11-15 10:27           ` Morten Brørup
2018-11-15 13:32             ` Wiles, Keith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a1e4ea9-e75a-0615-dcc8-c762817f4d2e@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=batmanustc@gmail.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).