From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id CFD342BAD
 for <dev@dpdk.org>; Tue, 20 Dec 2016 13:58:29 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga104.fm.intel.com with ESMTP; 20 Dec 2016 04:58:28 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,378,1477983600"; d="scan'208";a="1074411575"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29])
 ([10.237.220.29])
 by orsmga001.jf.intel.com with ESMTP; 20 Dec 2016 04:58:27 -0800
To: Jan Blunck <jblunck@infradead.org>
References: <1482232315-21626-1-git-send-email-jblunck@infradead.org>
 <1482232315-21626-5-git-send-email-jblunck@infradead.org>
 <dfdd8c5c-2b15-e9e4-03f6-805ce4788442@intel.com>
 <CALe+Z021O=MyCLnPg0RYy6eKH2vTPazKD7i-nDvyGtFsFWJ4Ow@mail.gmail.com>
Cc: dev@dpdk.org, Shreyansh Jain <shreyansh.jain@nxp.com>,
 David Marchand <david.marchand@6wind.com>,
 Stephen Hemminger <stephen@networkplumber.org>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <4a3631af-85be-f5bc-53fd-eabc4ca51354@intel.com>
Date: Tue, 20 Dec 2016 12:58:26 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <CALe+Z021O=MyCLnPg0RYy6eKH2vTPazKD7i-nDvyGtFsFWJ4Ow@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v3 4/9] virtio: Don't fill
 dev_info->driver_name
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Dec 2016 12:58:30 -0000

On 12/20/2016 12:40 PM, Jan Blunck wrote:
> On Tue, Dec 20, 2016 at 1:17 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>> On 12/20/2016 11:11 AM, Jan Blunck wrote:
>>> This is overwritten in rte_eth_dev_info_get().
>>>
>>> Signed-off-by: Jan Blunck <jblunck@infradead.org>
>>> Reviewed-by: David Marchand <david.marchand@6wind.com>
>>> ---
>>>  drivers/net/virtio/virtio_ethdev.c | 4 ----
>>>  1 file changed, 4 deletions(-)
>>>
>>> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
>>> index 079fd6c..741688e 100644
>>> --- a/drivers/net/virtio/virtio_ethdev.c
>>> +++ b/drivers/net/virtio/virtio_ethdev.c
>>> @@ -1624,10 +1624,6 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>>>       uint64_t tso_mask;
>>>       struct virtio_hw *hw = dev->data->dev_private;
>>>
>>> -     if (dev->pci_dev)
>>> -             dev_info->driver_name = dev->driver->pci_drv.driver.name;
>>> -     else
>>> -             dev_info->driver_name = "virtio_user PMD";
>>>       dev_info->max_rx_queues =
>>>               RTE_MIN(hw->max_queue_pairs, VIRTIO_MAX_RX_QUEUES);
>>>       dev_info->max_tx_queues =
>>>
>>
>>
>> This has been already removed in next-net with following commit:
>> 7c6c1857358c ("net: remove dead driver names")
> 
> Thanks. Do you want me to rebase against next-net and resend the
> series before continuing to review further?
> 

No, I thought this patch can be dropped from patchset, but no, you need
this for decoupling pci_dev.

So, this needs to be resolved in integration time.

I believe this patchset should be against main tree, because of eal and
ethdev patches in it.
And there are already a few patchset around for this area, let's not add
more complexity by adding next-net into the picture.