From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36F37A034E; Fri, 4 Mar 2022 17:44:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BFD98427CA; Fri, 4 Mar 2022 17:44:09 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id F36E2427A9 for ; Fri, 4 Mar 2022 17:44:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646412248; x=1677948248; h=message-id:date:to:references:from:subject:in-reply-to: content-transfer-encoding:mime-version; bh=3QDprr4Ssz4eBjghb189LNgnAD6a4S+4ip2RutpxerI=; b=U6JYyfEl+bQB+WWlAH/LNUnPoE+D2XE3SCmlFPq8J8OLovhF5XY/PDVC aNLhQIOh3HOshlmEhkbczD/7KmENU80zRn/H5JKRCxDdEfB1DgpgqC8gx Y4oSIPVS7YdVqN52HfS/v6BgEqOiF6RV9yZHKAwA6rBjKxn4AJ5nw+OyG c3bxxi2v3bItjDgsf0g++OPPq5lM3TanZB0Giv3aki1/Tw+KUV+ANIEqr osJi1xMVq0u1sMQGEHNqM3apmK/44HZbh1wUWyhLaw2HhxhD/41BN9V5u U0JZfSI9xxrTVZ4UT7AZT2osS6MhhirWycIlecQmy9Ov78mLS67YD/3Po w==; X-IronPort-AV: E=McAfee;i="6200,9189,10276"; a="254204168" X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="254204168" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2022 08:44:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="576926770" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 04 Mar 2022 08:44:06 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 4 Mar 2022 08:44:06 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 4 Mar 2022 08:44:05 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Fri, 4 Mar 2022 08:44:05 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Fri, 4 Mar 2022 08:44:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H4u4mEhg3DbNIsncEkRB2TH2L/U9nM6qcI8bR+1zwI7kHcK9XqeFDJDUpunhz6Yuq4GO9SC+fgf1Yq2IXVJMOYZemeP/mU0ZRH2YUDfO1yZvDehSYPNbyJW8NG1YM8ApWxk3XF2Gi7gWv1H/GWOodAQKLo1KLk7U50kJ15Nnzd4oFB09iaT63kGo0cvTSA//ROGlqt17XKJJLtFJgz84eLTvoV1b4ig5kgUISXVKaxaStRXSMdYrtzwdnUa+CfuPBqJIFNayRvKt72m2+8chjELPYa8xHdIz5SzYS9CBi2bEI4xLhOBDnIMVZviVGIZ95HwF72JisiXZfsT2A6QHYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eBbRkq+RMUhnvGt7C/215hQCat3r+F9sJr6ZRPLebAI=; b=RHNqKOnecN3DzSIbVeG78X9jQfGbmyGKMKs/j3lcj+cU6+xpbbDH83dXzHFmu9fNoq1ZJrYcUpuHi+iesCAE5miqELCLwRGrjoHC/6WdhKNIKhQZTybwBPhRhFB9paL0VuCtLgvAjc5TJJy75QW7hk4eoOOyUMEYbWhU2N+yVB7DjQd4OpHSk8Lj/LmcH6p6wrx20z4X6dtyGWNQ+S+vdUZQRaCyZ7HNYLVQX1Lo0pAuOcCVPnl0kNw0jpyAlP2d1LYi2tIq4IWrPKU2Eh34dkous1FYfCUu+kgjWSyxv5sVaei0Ok64FfvAn5ABGBVTQz/5/4YVflXR10w6DN1Bvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BL1PR11MB5286.namprd11.prod.outlook.com (2603:10b6:208:312::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.13; Fri, 4 Mar 2022 16:44:03 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%7]) with mapi id 15.20.5038.017; Fri, 4 Mar 2022 16:44:03 +0000 Message-ID: <4a963f00-c673-4361-16a1-2964ad828dc5@intel.com> Date: Fri, 4 Mar 2022 16:43:56 +0000 Content-Language: en-US To: Ke Zhang , , , , References: <20220301020653.329263-1-ke1x.zhang@intel.com> From: Ferruh Yigit Subject: Re: [PATCH] app/testpmd: fix issue with memory leaks when quit testpmd X-User: ferruhy In-Reply-To: <20220301020653.329263-1-ke1x.zhang@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0165.eurprd04.prod.outlook.com (2603:10a6:10:2b0::20) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dcfd84be-bd47-4cb9-d954-08d9fdfe2ff6 X-MS-TrafficTypeDiagnostic: BL1PR11MB5286:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QlkPZeldGREg6hRcYrqSQe/zFirwWsGX3UVW5qUkb7z9jbj62DjNsYJBSI5PQJn2PBOSnApN+7Ok9bqGljTR+RWYAvOGCM/oOMFmrBhqXdmEfbPikmKJj3+gdi7QSn3sc3SiDZH9Up8BtxCI0iwHinwA6tP4NIrcgm1WQK4lAYcx/Q6LcqgR6BS0TqxE5olYml3rtFawbwXzay9yptnqkX8HansRL+0KSr7csF6T1WU4kCWiuVsDs83zCI5nDmc19lO6NxSaNrMrpTAha1CZDfktGJlQ3RAvSH35pHL7b0doaUXFr5rcG9wQlg3zNUPzcIudoWxNFKd8wng9s56BXNpaK389Wz0qm0KAlU1LPc263SlXatLrdcSfogynUCPVzJjCvwQVc9m9jy7L/+ChCkjxpRUKjmx1DPuzzcNkKprS+dJdZdcfFMDAGe4tahoeiKze6I6HP8aMhwgcAlxmOltMHZB99IbA000I7tmqzjs78bw+5Wm351Fu7s4N5tScrrn2OnJmORQVF1wFSV984gKGWGwUIBbmbPg/b/iKYDpeutuuCYdn2IVByIp9NxlcK1lFCxkkbvAnrVooI/i321yMPmvwc331clFcyQXlvd8FUm7HsNynfNs4lUVKHpg6AMfygrp0gcoMjiK2qynJcbh1P2C+bCljhr1luUj/Y6wtLQE3YXbatSGmDtVGdE+0uSm8nSNXjfDRtJYwKItvrA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6486002)(66476007)(86362001)(31696002)(2616005)(83380400001)(6666004)(66946007)(66556008)(316002)(26005)(186003)(8676002)(44832011)(38100700002)(31686004)(36756003)(6512007)(53546011)(8936002)(5660300002)(6506007)(508600001)(2906002)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NE5nWGNQWlVieVRPU09FTVJkeWtwaExjZnQ5S0lZWTFvTlN6RVErRy9OdmVr?= =?utf-8?B?T0d2VUZVc2wrQUdxdWZkTC9qSjV3eGl5cXNocStTalFvR0d5ejJkaExLNUJm?= =?utf-8?B?VGZ2TTh3bVdsTkxLd3QyTDRORE53M2g1ODg0T0IxcXpiNzZlRzhiK1lkOTRU?= =?utf-8?B?aGF6K0t3TTlxVkM1ampBa2taemZTNXAzbWF6NUVmY0RmQldmWU1pYk1ZbVJS?= =?utf-8?B?dWt4VCthanZEMUVaV2E5MTE1SXFiWE1kUWpGQTJXalliTXlTdStzWnN4MkNl?= =?utf-8?B?NUpES2xNL3FsTnNyVmJoUUViZk9SeXpYNWt6ME9NMFFPRGQzUy8xYnhNK08v?= =?utf-8?B?K3ozdkIwaUUxb2JaMnlyYitDZnljZDN6NTYyNFoxcURaTzNmUXlqdFZYR1N2?= =?utf-8?B?a052dmZUajVOVWJpcDdxNG11RUYyRXkyRmJOVWkyZjErbXhnYkRpcEFLTzVu?= =?utf-8?B?SVlaOWVDQUk2bWVvVTQrWnV6Yk1SNkgyRVN5ZEZmakRQQzg1WGFMSTB5R0Nv?= =?utf-8?B?bkxyZDVneTB4L1h6VUtNcWJkdXJlMWhld01QMmFSeVZIR0Jnb3RNbmRUNUZP?= =?utf-8?B?N2NzWlJYaHFJVjM1WnJzTEgwTXplZlZwRm9JUXJySEdGclJoOFQ4S0hkMmZi?= =?utf-8?B?VW1iZ2k4NDVFSEJocEFNZXFaNmdxZVBNQzFSUFN5UFZyYjlHL1Fyd2pNNTJH?= =?utf-8?B?cmZ2Q3ovayswY2RCaWR2VFNXSy9zWkNaVzZyWXlYWEwvL0hSb0JLazZ4dFlS?= =?utf-8?B?ZXFyYmVjL0ttZlFOb1BrNmdKcElOeXIxSWNtd2FLZlloejV2TWFJTHhCckwx?= =?utf-8?B?Rlo2SHUvMGhKZk5IU2xoRkhtSDRVL0NrdEo1VUhaK3ZjOXAwVTg5bXJ2NVdu?= =?utf-8?B?VldQKzdtcEtFeitzTDlhL05KOVJqbEZuN0RBMmQ4VDNrUkdmSHd1VTN4cXIv?= =?utf-8?B?YTY2eWNLL0xyYnRKU1dKUS9qYWpadEczWjI3SGNTcUJKSUsyUzRqeVZ2UWdF?= =?utf-8?B?a1RjOVRBUTFnc1RxNXQvRWR5a1Iva2V2dFZDalFlZ0kxT3ZjbW9wWlJGbVVn?= =?utf-8?B?ZGl2UGtxWkxEQm9ZZEpvMUhpZC9zcXdOQ3E5b3B5ZVBlT0JhcGI5QlZOTmVt?= =?utf-8?B?cHVWS3V0V3V1MVBEZFoxQnQydGUyTHdSYjJPeFVRdENHRFJoMmdqR2FZbXM3?= =?utf-8?B?L1JXam51aC9wQVpEOGNTQVh1dksrOW5TTXlWb3F4VFVBRmZFM2d2Zm5NRTQx?= =?utf-8?B?OEtrSGY0K2s3c1ZHQmx3eVhtWkQ4VlJJZWl0cWFWd3dMek1kbWM4ckVPTGp1?= =?utf-8?B?eCtOVlZPUW1Dc1hlc3FoWXlMNm9VTDA2V3JNblNhc1hQNU9kbjYySS9MYTlx?= =?utf-8?B?SHpieUwwbFhSdWx3VU4zam8yY3pVTzJ5aUxoSmU4aFE0d1llWmozTkVEeTdW?= =?utf-8?B?YkVtRnN2YUNJeGNPR1Z3M01naElXL1BneW1OOThFZC9lUlZyMUxVOVlKNnJQ?= =?utf-8?B?UG9uakUvMkwxVHBrUGdVdWJyQmR2b0oxUFlNMjZ5ZFkrUXFKNnV5UTc4VzJ5?= =?utf-8?B?bm9DRFBpZ0pVeGJKL3NlS2FKcCtiay95dmFZbFZ2MnFxbCticCtKUmlETzQ5?= =?utf-8?B?U1psOTk1NDJiTDlGM1dSNGNPWVY2LzUvVUk1TUtJV01qS0xpbW5Yb3BnS3Vt?= =?utf-8?B?ZkhuTXFkRkVqNjhIa1FuV0xRdlM0NTlnVFV0RjVBdCtCNW1KeitzaFFmYVRQ?= =?utf-8?B?aHB5S01obEFiWnZBQXM2b2R2anFWajdSNUc3WTljVWh4cFJJckxSd0RFL2dQ?= =?utf-8?B?TXRXajFPZWt6V2dzcVcyVzRVZDRoRzlOb3czK05IMVh2bEVNbEpNWm44NWdT?= =?utf-8?B?QzJ4enNTMkFpdXA3R1JSY21Rbk5uMUNiN0prbHFuTERCWkpUcEFkRjZacXNr?= =?utf-8?B?Z3o5T3VKcnJNUGh0SnR5R3M4bmtkYnJGR2dUNEZ0bmxmSlRSNmlINHU3WXk5?= =?utf-8?B?d2ZGckRsMmxmYkg1OUVXcTR6UFVCRDU0Z3Z0Ly9iMU9sV2Z0QmlkYkhha1U4?= =?utf-8?B?ZG5Xc3RXUFdEd1prazc3MExLNkowYVFFOEgyUXhqRFY0L2gvWVFneWJ3Vlp2?= =?utf-8?B?S1A0bmVoaHY1UVUyRFFoaVNQdjdDL1BVMzc5UWFFanA4cWdlMFRuMTU1cDd2?= =?utf-8?Q?x1qrgxOga+0OvB7LsYg2nMQ=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: dcfd84be-bd47-4cb9-d954-08d9fdfe2ff6 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 16:44:03.0615 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ni11QiXgCyU9g+0XEmiNJaVKWsoLXnoRHhakKkXBFy1myQgz3gmjFyP2FjSfBOBcRBgtb++c26tyUtTzeHQR7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5286 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/1/2022 2:06 AM, Ke Zhang wrote: > when dpdk is compiled in ASan, there is a memory leaks after > quit testpmd if set mcast_addr, this patch fix this issue. > > Error info as following: > ERROR: LeakSanitizer: detected memory leaksDirect leak of > 192 byte(s) > 0 0x7f6a2e0aeffe in __interceptor_realloc > (/lib/x86_64-linux-gnu/libasan.so.5+0x10dffe) > 1 0x565361eb340f in mcast_addr_pool_extend > ../app/test-pmd/config.c:5162 > 2 0x565361eb3556 in mcast_addr_pool_append > ../app/test-pmd/config.c:5180 > 3 0x565361eb3aae in mcast_addr_add > ../app/test-pmd/config.c:5243 > > Signed-off-by: Ke Zhang > --- > app/test-pmd/testpmd.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index fe2ce19f99..fa7f80fdf7 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2742,6 +2742,8 @@ start_port(portid_t pid) > continue; > } > > + port->mc_addr_pool = NULL; > + User can do consecutive start / stop / start / .. Won't user expect the previous allocated and set MAC address to be valid after this? What about to free the 'port->mc_addr_pool' in close() instead of stop()? > if (port->need_reconfig > 0) { > struct rte_eth_conf dev_conf; > int k; > @@ -3065,6 +3067,16 @@ stop_port(portid_t pid) > if (eth_dev_stop_mp(pi) != 0) > RTE_LOG(ERR, EAL, "rte_eth_dev_stop failed for port %u\n", > pi); > + /* > + * free the pool of multicast addresses. If it is NULL, > + * it means there is no mc addr.Make sure the mc_addr_pool > + * is NULL at port init. > + */ > + if (port->mc_addr_pool != NULL) { > + free(port->mc_addr_pool); > + port->mc_addr_pool = NULL; > + } > + port->mc_addr_nb = 0; will it work to use 'port->mc_addr_nb' to detect if the 'port->mc_addr_pool' pointer is valid if (port->mc_addr_nb) { free(port->mc_addr_pool); port->mc_addr_pool = NULL; port->mc_addr_nb = 0; } > > if (port->port_status == RTE_PORT_HANDLING) > port->port_status = RTE_PORT_STOPPED;