From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 1462B4D3A for ; Tue, 20 Mar 2018 11:29:22 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id EA798980071; Tue, 20 Mar 2018 10:29:20 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Tue, 20 Mar 2018 10:29:16 +0000 To: Olivier Matz CC: , Bruce Richardson References: <1516713372-10572-1-git-send-email-arybchenko@solarflare.com> <1520696382-16400-1-git-send-email-arybchenko@solarflare.com> <1520696382-16400-2-git-send-email-arybchenko@solarflare.com> <20180319170352.ddwhimxr6dzkpqea@platinum> From: Andrew Rybchenko Message-ID: <4ab1ccc5-53c0-afe0-9bac-bc61a54be38e@solarflare.com> Date: Tue, 20 Mar 2018 13:29:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180319170352.ddwhimxr6dzkpqea@platinum> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23730.003 X-TM-AS-Result: No--12.116100-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1521541761-RvoE8DoKlFfk Subject: Re: [dpdk-dev] [PATCH v1 1/9] mempool: add op to calculate memory size to be allocated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 10:29:22 -0000 On 03/19/2018 08:03 PM, Olivier Matz wrote: > On Sat, Mar 10, 2018 at 03:39:34PM +0000, Andrew Rybchenko wrote: >> --- a/lib/librte_mempool/Makefile >> +++ b/lib/librte_mempool/Makefile >> @@ -11,11 +11,12 @@ LDLIBS += -lrte_eal -lrte_ring >> >> EXPORT_MAP := rte_mempool_version.map >> >> -LIBABIVER := 3 >> +LIBABIVER := 4 >> >> # all source are stored in SRCS-y >> SRCS-$(CONFIG_RTE_LIBRTE_MEMPOOL) += rte_mempool.c >> SRCS-$(CONFIG_RTE_LIBRTE_MEMPOOL) += rte_mempool_ops.c >> +SRCS-$(CONFIG_RTE_LIBRTE_MEMPOOL) += rte_mempool_ops_default.c >> # install includes >> SYMLINK-$(CONFIG_RTE_LIBRTE_MEMPOOL)-include := rte_mempool.h >> >> diff --git a/lib/librte_mempool/meson.build b/lib/librte_mempool/meson.build >> index 7a4f3da..9e3b527 100644 >> --- a/lib/librte_mempool/meson.build >> +++ b/lib/librte_mempool/meson.build >> @@ -1,7 +1,8 @@ >> # SPDX-License-Identifier: BSD-3-Clause >> # Copyright(c) 2017 Intel Corporation >> >> -version = 2 >> -sources = files('rte_mempool.c', 'rte_mempool_ops.c') >> +version = 4 >> +sources = files('rte_mempool.c', 'rte_mempool_ops.c', >> + 'rte_mempool_ops_default.c') >> headers = files('rte_mempool.h') >> deps += ['ring'] > It's strange to see that meson does not have the same > .so version than the legacy build system. > > +CC Bruce in case he wants to fix this issue separately. I'll make a patchset to fix all similar issues. It should be definitely separate since it should be backported to 18.02. I think main problem here is the version=1 default in the case of meson. So, there are really many examples w/o version and it is simply lost/forgotten when a new library is added to meson.