DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/qede: correct function declaration syntax
@ 2017-01-15 19:51 Emmanuel Roullit
  2017-01-16  9:06 ` Ferruh Yigit
  2017-01-16 13:00 ` Ferruh Yigit
  0 siblings, 2 replies; 4+ messages in thread
From: Emmanuel Roullit @ 2017-01-15 19:51 UTC (permalink / raw)
  To: rasesh.mody; +Cc: dev

clang reports this error message:
error: this function declaration is not a prototype
[-Werror,-Wstrict-prototypes]

Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
---
 drivers/net/qede/qede_eth_if.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/qede/qede_eth_if.h b/drivers/net/qede/qede_eth_if.h
index 33655c3..74e17f8 100644
--- a/drivers/net/qede/qede_eth_if.h
+++ b/drivers/net/qede/qede_eth_if.h
@@ -171,7 +171,7 @@ struct qed_eth_ops {
 
 extern const struct qed_common_ops qed_common_ops_pass;
 
-const struct qed_eth_ops *qed_get_eth_ops();
+const struct qed_eth_ops *qed_get_eth_ops(void);
 
 int qed_configure_filter_rx_mode(struct ecore_dev *edev,
 				 enum qed_filter_rx_mode_type type);
-- 
1.9.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] net/qede: correct function declaration syntax
  2017-01-15 19:51 [dpdk-dev] [PATCH] net/qede: correct function declaration syntax Emmanuel Roullit
@ 2017-01-16  9:06 ` Ferruh Yigit
  2017-01-16 13:00 ` Ferruh Yigit
  1 sibling, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2017-01-16  9:06 UTC (permalink / raw)
  To: Emmanuel Roullit, rasesh.mody; +Cc: dev

Hi Emmanuel,

On 1/15/2017 7:51 PM, Emmanuel Roullit wrote:
> clang reports this error message:
> error: this function declaration is not a prototype
> [-Werror,-Wstrict-prototypes]

What is the clang version?

Thanks,
ferruh

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] net/qede: correct function declaration syntax
  2017-01-15 19:51 [dpdk-dev] [PATCH] net/qede: correct function declaration syntax Emmanuel Roullit
  2017-01-16  9:06 ` Ferruh Yigit
@ 2017-01-16 13:00 ` Ferruh Yigit
  2017-01-16 13:17   ` Ferruh Yigit
  1 sibling, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2017-01-16 13:00 UTC (permalink / raw)
  To: Emmanuel Roullit, rasesh.mody; +Cc: dev

On 1/15/2017 7:51 PM, Emmanuel Roullit wrote:
> clang reports this error message:
> error: this function declaration is not a prototype
> [-Werror,-Wstrict-prototypes]
> 
> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] net/qede: correct function declaration syntax
  2017-01-16 13:00 ` Ferruh Yigit
@ 2017-01-16 13:17   ` Ferruh Yigit
  0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2017-01-16 13:17 UTC (permalink / raw)
  To: Emmanuel Roullit, rasesh.mody; +Cc: dev, dpdk stable

On 1/16/2017 1:00 PM, Ferruh Yigit wrote:
> On 1/15/2017 7:51 PM, Emmanuel Roullit wrote:
>> clang reports this error message:
>> error: this function declaration is not a prototype
>> [-Werror,-Wstrict-prototypes]
>>
>> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Fixes: 5cdd769a26ec ("qede: add L2 support")

CC: stable@dpdk.org

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-01-16 13:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-15 19:51 [dpdk-dev] [PATCH] net/qede: correct function declaration syntax Emmanuel Roullit
2017-01-16  9:06 ` Ferruh Yigit
2017-01-16 13:00 ` Ferruh Yigit
2017-01-16 13:17   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).