Re: [PATCH v2 09/37] baseband/acc100: add HARQ index helper function

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 8/20/22 04:31, Hernan Vargas wrote:
> Refactor code to use the HARQ index helper function and make harq_idx
> uint32.
> 
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
>   drivers/baseband/acc100/rte_acc100_pmd.c | 32 +++++++++++-------------
>   1 file changed, 14 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
> index a7e0df96e8..5d09908fd0 100644
> --- a/drivers/baseband/acc100/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc100/rte_acc100_pmd.c
> @@ -1304,6 +1304,11 @@ acc100_fcw_td_fill(const struct rte_bbdev_dec_op *op, struct acc100_fcw_td *fcw)
>   			RTE_BBDEV_TURBO_HALF_ITERATION_EVEN);
>   }
>   
> +/* Convert offset to harq index for harq_layout structure */
> +static inline uint32_t hq_index(uint32_t offset)
> +{
> +	return (offset >> ACC100_HARQ_OFFSET_SHIFT) & ACC100_HARQ_OFFSET_MASK;
> +}
>   
>   static inline bool
>   is_acc100(struct acc100_queue *q)
> @@ -1323,7 +1328,7 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc100_fcw_ld *fcw,
>   		union acc100_harq_layout_data *harq_layout)
>   {
>   	uint16_t harq_out_length, harq_in_length, ncb_p, k0_p, parity_offset;
> -	uint16_t harq_index;
> +	uint32_t harq_index;
>   	uint32_t l;
>   	bool harq_prun = false;
>   
> @@ -1362,8 +1367,7 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc100_fcw_ld *fcw,
>   			RTE_BBDEV_LDPC_HARQ_6BIT_COMPRESSION);
>   	fcw->llr_pack_mode = check_bit(op->ldpc_dec.op_flags,
>   			RTE_BBDEV_LDPC_LLR_COMPRESSION);
> -	harq_index = op->ldpc_dec.harq_combined_output.offset /
> -			ACC100_HARQ_OFFSET;
> +	harq_index = hq_index(op->ldpc_dec.harq_combined_output.offset);
>   #ifdef ACC100_EXT_MEM
>   	/* Limit cases when HARQ pruning is valid */
>   	harq_prun = ((op->ldpc_dec.harq_combined_output.offset %
> @@ -1443,12 +1447,6 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc100_fcw_ld *fcw,
>   	}
>   }
>   
> -/* Convert offset to harq index for harq_layout structure */
> -static inline uint32_t hq_index(uint32_t offset)
> -{
> -	return (offset >> ACC100_HARQ_OFFSET_SHIFT) & ACC100_HARQ_OFFSET_MASK;
> -}
> -
>   /* Fill in a frame control word for LDPC decoding for ACC101 */
>   static inline void
>   acc101_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc100_fcw_ld *fcw,
> @@ -2132,12 +2130,11 @@ acc100_dma_desc_ld_update(struct rte_bbdev_dec_op *op,
>   		struct rte_bbdev_dec_op *prev_op = desc->op_addr;
>   		op->ldpc_dec.harq_combined_output.length =
>   				prev_op->ldpc_dec.harq_combined_output.length;
> -		int16_t hq_idx = op->ldpc_dec.harq_combined_output.offset /
> -				ACC100_HARQ_OFFSET;
> -		int16_t prev_hq_idx =
> -				prev_op->ldpc_dec.harq_combined_output.offset
> -				/ ACC100_HARQ_OFFSET;
> -		harq_layout[hq_idx].val = harq_layout[prev_hq_idx].val;
> +		uint32_t harq_idx = hq_index(
> +				op->ldpc_dec.harq_combined_output.offset);
> +		uint32_t prev_harq_idx = hq_index(
> +				prev_op->ldpc_dec.harq_combined_output.offset);
> +		harq_layout[harq_idx].val = harq_layout[prev_harq_idx].val;

Don't mix declarations & code.
Also, the coding rules has been updated some time ago, it is possible to
go up to 100 characters [0] if it improves readability.

>   #ifndef ACC100_EXT_MEM
>   		struct rte_bbdev_op_data ho =
>   				op->ldpc_dec.harq_combined_output;
> @@ -2969,10 +2966,9 @@ harq_loopback(struct acc100_queue *q, struct rte_bbdev_dec_op *op,
>   	bool ddr_mem_in = check_bit(op->ldpc_dec.op_flags,
>   			RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_IN_ENABLE);
>   	union acc100_harq_layout_data *harq_layout = q->d->harq_layout;
> -	uint16_t harq_index = (ddr_mem_in ?
> +	uint32_t harq_index = hq_index(ddr_mem_in ?
>   			op->ldpc_dec.harq_combined_input.offset :
> -			op->ldpc_dec.harq_combined_output.offset)
> -			/ ACC100_HARQ_OFFSET;
> +			op->ldpc_dec.harq_combined_output.offset);
>   
>   	uint16_t desc_idx = ((q->sw_ring_head + total_enqueued_cbs)
>   			& q->sw_ring_wrap_mask);

With above minor issues fixed:

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

[0]: 
https://git.dpdk.org/dpdk/tree/doc/guides/contributing/coding_style.rst#n30