From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7073A0A02; Thu, 14 Jan 2021 18:19:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89FD91413DD; Thu, 14 Jan 2021 18:19:51 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 976411413DC for ; Thu, 14 Jan 2021 18:19:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610644790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E7cTOhGN7s/4+MCafZLp8mBTe7mbH+OtKP+FYmAiGjk=; b=AqhjpdtqwAwwRRlEyCRqCnlrisRAvwez1PTp8VFaua46XH/b5uUHTwnLlRG5VJcpOl6EX2 GF+lYISJnorPxXUD6m0K6oUbqkmtMgP40hV90RnyeOhTF5pQcb6875b7YCscbI2mPFlAxd gZgVrXj6GX7HCnzZZKKvwTV0Z69u2Yw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-csXMgJ9tPm-UMaQYTbKVrw-1; Thu, 14 Jan 2021 12:19:46 -0500 X-MC-Unique: csXMgJ9tPm-UMaQYTbKVrw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 756EE1012E85; Thu, 14 Jan 2021 17:19:45 +0000 (UTC) Received: from [10.36.110.24] (unknown [10.36.110.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5C6B15D9E2; Thu, 14 Jan 2021 17:19:41 +0000 (UTC) To: David Marchand Cc: dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata References: <20201220211405.313012-1-maxime.coquelin@redhat.com> <20201220211405.313012-8-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <4ab4a6d3-5e20-e139-c126-0fd5686b6c8a@redhat.com> Date: Thu, 14 Jan 2021 18:19:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 07/40] net/virtio: move MSIX detection to PCI ethdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/6/21 9:22 AM, David Marchand wrote: > On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin > wrote: >> >> There is no point it detecting whether we can use MSIX >> every time the interrupt is enabled/disabled/masked. >> >> Let's do it once for all at PCI device init time. >> >> Signed-off-by: Maxime Coquelin > > Is this a rework/fix of fe19d49cb525 ("net/virtio: fix Rx interrupt > with VFIO") ? Hmm, that was only planned as a rework, but it is likely to introduce a regression by reverting the fix you mention. I think I'll have to introduce a new callback so that drivers can update their status. Good catch, thanks! Maxime