From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D61C31BA3E for <dev@dpdk.org>; Wed, 25 Oct 2017 19:42:42 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2017 10:42:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,432,1503385200"; d="scan'208";a="167534147" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.45]) ([10.241.225.45]) by fmsmga006.fm.intel.com with ESMTP; 25 Oct 2017 10:42:17 -0700 To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org Cc: thomas@monjalon.net References: <20171023121623.27466-1-olivier.matz@6wind.com> <20171025151257.16459-1-olivier.matz@6wind.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <4ae4cbe7-1ba9-90a2-c072-51f9ecb66e2d@intel.com> Date: Wed, 25 Oct 2017 10:42:17 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171025151257.16459-1-olivier.matz@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] mbuf: rename deprecated VLAN flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 25 Oct 2017 17:42:43 -0000 On 10/25/2017 8:12 AM, Olivier Matz wrote: > PKT_RX_VLAN_PKT and PKT_RX_QINQ_PKT are deprecated for a while. > As explained in [1], these flags were kept to let the applications and > PMDs move to the new flag. There is also a need to support Rx vlan > offload without vlan strip (at least for the ixgbe driver). > > This patch renames the old flags for this feature, knowing that some > PMDs were using PKT_RX_VLAN_PKT and PKT_RX_QINQ_PKT to indicate that > the vlan tci has been saved in the mbuf structure. > > It is likely that some PMDs do not set the proper flags when doing vlan > offload, and it would be worth making a pass on all of them. > > Link: [1] http://dpdk.org/ml/archives/dev/2017-June/067712.html > Signed-off-by: Olivier Matz <olivier.matz@6wind.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>