From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C476CA04B6;
	Mon, 12 Oct 2020 05:22:00 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id B04491BCC4;
	Mon, 12 Oct 2020 05:21:58 +0200 (CEST)
Received: from incedge.chinasoftinc.com (unknown [114.113.233.8])
 by dpdk.org (Postfix) with ESMTP id 0EC2C1BACE
 for <dev@dpdk.org>; Mon, 12 Oct 2020 05:21:55 +0200 (CEST)
X-ASG-Debug-ID: 1602472912-149d114caf12fb50002-TfluYd
Received: from mail.chinasoftinc.com (inccas001.ito.icss [10.168.0.51]) by
 incedge.chinasoftinc.com with ESMTP id mqQdQY0SSRjx0k5C (version=TLSv1
 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO);
 Mon, 12 Oct 2020 11:21:52 +0800 (CST)
X-Barracuda-Envelope-From: huwei013@chinasoftinc.com
X-Barracuda-RBL-Trusted-Forwarder: 10.168.0.51
X-ASG-Whitelist: Client
Received: from [192.168.1.199] (139.159.243.11) by INCCAS001.ito.icss
 (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Mon, 12 Oct 2020
 11:21:50 +0800
X-Barracuda-RBL-Trusted-Forwarder: 192.168.1.199
To: Stephen Hemminger <stephen@networkplumber.org>
X-ASG-Orig-Subj: Re: [dpdk-dev] [PATCH] ethdev: check if queue setupped in
 queue-related APIs
CC: <dev@dpdk.org>, <xavier.huwei@huawei.com>
References: <20201010071212.24086-1-huwei013@chinasoftinc.com>
 <20201010082413.1c90098c@hermes.local>
From: "Wei Hu (Xavier)" <huwei013@chinasoftinc.com>
Message-ID: <4b00288c-a475-f49e-e0b9-3fd288e5fa6f@chinasoftinc.com>
Date: Mon, 12 Oct 2020 11:21:49 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201010082413.1c90098c@hermes.local>
Content-Language: en-US
X-Originating-IP: [139.159.243.11]
X-Barracuda-Connect: inccas001.ito.icss[10.168.0.51]
X-Barracuda-Start-Time: 1602472912
X-Barracuda-Encrypted: ECDHE-RSA-AES256-SHA
X-Barracuda-URL: https://incspam.chinasofti.com:443/cgi-mod/mark.cgi
X-Virus-Scanned: by bsmtpd at chinasoftinc.com
X-Barracuda-Scan-Msg-Size: 2646
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] ethdev: check if queue setupped in
 queue-related APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, Stephen Hemminger

On 2020/10/10 23:24, Stephen Hemminger wrote:
> On Sat, 10 Oct 2020 15:12:12 +0800
> "Wei Hu (Xavier)" <huwei013@chinasoftinc.com> wrote:
>
>> +	if (dev->data->rx_queues[rx_queue_id] == NULL) {
>> +		RTE_ETHDEV_LOG(ERR, "Rx queue %"PRIu16" of device with port_id=%"
>> +				    PRIu16" has not been setupped\n",
>> +				    rx_queue_id, port_id);
>> +		return -EINVAL;
>> +
> Please use correct spelling.
>
> Your change follows the existing style in rte_eth_dev_rx_queue_start() but
> my preference is that message strings are not split across
> lines. That makes it easier to use tools like grep to find messages in the source.
>
> Use of PRIu16 is not required. And recent compiler standards would require space
> around its use.
>
> Suggest:
> 		RTE_ETHDEV_LOG(ERR,
> 			       "Queue %u of device with port_id=%u has not been setup\n",
> 				rx_queue_id, port_id);

I fixed it in V2.

Thanks, xavier