From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 768F81B453; Tue, 23 Apr 2019 10:11:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 01:11:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,385,1549958400"; d="scan'208";a="167052973" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.1.168]) ([10.252.1.168]) by fmsmga001.fm.intel.com with ESMTP; 23 Apr 2019 01:11:39 -0700 To: Herakliusz Lipiec , dev@dpdk.org Cc: jianfeng.tan@intel.com, jia.quo@intel.com, gi.z.zhang@intel.com, stable@dpdk.org References: <20190417143822.21276-1-herakliusz.lipiec@intel.com> From: "Burakov, Anatoly" Message-ID: <4b235afe-0d15-3b38-415a-47ae74c0de67@intel.com> Date: Tue, 23 Apr 2019 09:11:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190417143822.21276-1-herakliusz.lipiec@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/8] ipc: fix rte_mp_request_sync memleak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2019 08:11:43 -0000 On 17-Apr-19 3:38 PM, Herakliusz Lipiec wrote: > When sending multiple requests, rte_mp_request_sync > can succeed sending a few of those requests, but then > fail on a later one and in the end return with rc=-1. > The upper layers - e.g. device hotplug - currently > handles this case as if no messages were sent and no > memory for response buffers was allocated, which is > not true. Fixed by always initializing message buffer > to NULL. > > Fixes: 783b6e54971d ("eal: add synchronous multi-process communication") > Cc: jianfeng.tan@intel.com > Cc: jia.quo@intel.com > Cc: gi.z.zhang@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Herakliusz Lipiec > --- > lib/librte_eal/common/eal_common_proc.c | 6 +++--- > lib/librte_eal/common/include/rte_eal.h | 3 ++- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c > index b46d644b3..abaff5164 100644 > --- a/lib/librte_eal/common/eal_common_proc.c > +++ b/lib/librte_eal/common/eal_common_proc.c > @@ -927,13 +927,13 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply *reply, > > RTE_LOG(DEBUG, EAL, "request: %s\n", req->name); > > - if (check_input(req) == false) > - return -1; > - > reply->nb_sent = 0; > reply->nb_received = 0; > reply->msgs = NULL; > > + if (check_input(req) == false) > + return -1; > + > if (internal_config.no_shconf) { > RTE_LOG(DEBUG, EAL, "No shared files mode enabled, IPC is disabled\n"); > return 0; > diff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h > index 833433229..575f8119e 100644 > --- a/lib/librte_eal/common/include/rte_eal.h > +++ b/lib/librte_eal/common/include/rte_eal.h > @@ -309,7 +309,8 @@ rte_mp_sendmsg(struct rte_mp_msg *msg); > * This function sends a request message to the peer process, and will > * block until receiving reply message from the peer process. > * > - * @note The caller is responsible to free reply->replies. > + * @note The caller is responsible to free reply->replies (even if the function > + * returned failure). > * > * @param req > * The req argument contains the customized request message. > These patches should've been submitted as one patchset - otherwise it is very difficult to review it. Please resubmit as a proper patchset. As far as the code itself goes, Acked-by: Anatoly Burakov -- Thanks, Anatoly From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D1379A05D3 for ; Tue, 23 Apr 2019 10:11:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 797271B455; Tue, 23 Apr 2019 10:11:44 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 768F81B453; Tue, 23 Apr 2019 10:11:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 01:11:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,385,1549958400"; d="scan'208";a="167052973" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.1.168]) ([10.252.1.168]) by fmsmga001.fm.intel.com with ESMTP; 23 Apr 2019 01:11:39 -0700 To: Herakliusz Lipiec , dev@dpdk.org Cc: jianfeng.tan@intel.com, jia.quo@intel.com, gi.z.zhang@intel.com, stable@dpdk.org References: <20190417143822.21276-1-herakliusz.lipiec@intel.com> From: "Burakov, Anatoly" Message-ID: <4b235afe-0d15-3b38-415a-47ae74c0de67@intel.com> Date: Tue, 23 Apr 2019 09:11:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190417143822.21276-1-herakliusz.lipiec@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/8] ipc: fix rte_mp_request_sync memleak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190423081138.USrCLwuvYrbMTmzxBcNLNjUZweP77o-djMKnuGx0fpM@z> On 17-Apr-19 3:38 PM, Herakliusz Lipiec wrote: > When sending multiple requests, rte_mp_request_sync > can succeed sending a few of those requests, but then > fail on a later one and in the end return with rc=-1. > The upper layers - e.g. device hotplug - currently > handles this case as if no messages were sent and no > memory for response buffers was allocated, which is > not true. Fixed by always initializing message buffer > to NULL. > > Fixes: 783b6e54971d ("eal: add synchronous multi-process communication") > Cc: jianfeng.tan@intel.com > Cc: jia.quo@intel.com > Cc: gi.z.zhang@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Herakliusz Lipiec > --- > lib/librte_eal/common/eal_common_proc.c | 6 +++--- > lib/librte_eal/common/include/rte_eal.h | 3 ++- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c > index b46d644b3..abaff5164 100644 > --- a/lib/librte_eal/common/eal_common_proc.c > +++ b/lib/librte_eal/common/eal_common_proc.c > @@ -927,13 +927,13 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply *reply, > > RTE_LOG(DEBUG, EAL, "request: %s\n", req->name); > > - if (check_input(req) == false) > - return -1; > - > reply->nb_sent = 0; > reply->nb_received = 0; > reply->msgs = NULL; > > + if (check_input(req) == false) > + return -1; > + > if (internal_config.no_shconf) { > RTE_LOG(DEBUG, EAL, "No shared files mode enabled, IPC is disabled\n"); > return 0; > diff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h > index 833433229..575f8119e 100644 > --- a/lib/librte_eal/common/include/rte_eal.h > +++ b/lib/librte_eal/common/include/rte_eal.h > @@ -309,7 +309,8 @@ rte_mp_sendmsg(struct rte_mp_msg *msg); > * This function sends a request message to the peer process, and will > * block until receiving reply message from the peer process. > * > - * @note The caller is responsible to free reply->replies. > + * @note The caller is responsible to free reply->replies (even if the function > + * returned failure). > * > * @param req > * The req argument contains the customized request message. > These patches should've been submitted as one patchset - otherwise it is very difficult to review it. Please resubmit as a proper patchset. As far as the code itself goes, Acked-by: Anatoly Burakov -- Thanks, Anatoly