From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BE9A429B0; Sat, 22 Apr 2023 07:26:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99C8140693; Sat, 22 Apr 2023 07:26:45 +0200 (CEST) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id C17C74021D for ; Sat, 22 Apr 2023 07:26:43 +0200 (CEST) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2474e09fdcfso2413513a91.0 for ; Fri, 21 Apr 2023 22:26:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20221208.gappssmtp.com; s=20221208; t=1682141203; x=1684733203; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jmCjXanj8RwYbPPIXrMLS5Rl+NLemvmAiqlezh/Ssqk=; b=ZJKVuC5izYvdbLsEC/R8qIT0AzPbLC5BE+1wYsVNitHSfWcUPFKG4PHCTEEqZeO2Xo MmQ4b9vyi+bTSP7fcGRNTMxt1sz2VzWomJtpZoAu6gMEUpnzKIuYcNDOlwLnHTgQxZrr W6RJ1hsWqMZOZZWvX+/Z9GP+i/sIPLGlCtU54q11Jjl6af2cqLWj0yQTwq8ZWKsMOl9h OuwDab992D34CD2Ehry6+nDNhc4bgESG9BBez0760MLi53ryT7ieYhtjMp5XTIiHbzZC z0cEGwlcg6/f0loRwewdE5s5ED8wuafx+qdaOvdem1XIUWfnq5Ib5A9c1G/CCHmnSMad AoXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682141203; x=1684733203; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jmCjXanj8RwYbPPIXrMLS5Rl+NLemvmAiqlezh/Ssqk=; b=UUpb9DGyKRzz0uIKs6OQlJIXWPX3kV8UHapR5dabdmfSmUD6nRo9rtxDRm0lCUfzjV 8i63xsVzbb4pjkgK7AFYk/pBW6QKmDzPvh93uwSxrOCp+4mQeRvp4NO99LBtPTQX7oxL k1czYZqGl4eufPLM4HfYykmkYIJXYfgl5N6Zv/+1dg9FpxZjECcmymu3hD8F4DNhScqg iGYVAPGbFbxbw+AbIVY2GrHPWxRzPD8qq7Yu1lxAN3KfEPAm5jcwAfaTEGpezsfsBvjO xzoOltEvJSeGVWVcCOajrX6jjDN04utAx0ARCRts2n7lAp8pk5UNrHK2G0n6/AQJ/O0w 673Q== X-Gm-Message-State: AAQBX9eVSsCZw8SYzWZxrWlfcU/guBU4ylM5l2hyBySLZr3kE9yZ+fCY N8cxyNDTgR2u/zs3PmnaVopmsQ== X-Google-Smtp-Source: AKy350b3KXX/XOn9Sq3IgrsKTQVseFm5JFKXARaBdPVBCjrJdS8qz0Vist9MDlqTitRxrKsW8Xqbzw== X-Received: by 2002:a17:90a:ce18:b0:247:4c4b:f4eb with SMTP id f24-20020a17090ace1800b002474c4bf4ebmr7054802pju.21.1682141202845; Fri, 21 Apr 2023 22:26:42 -0700 (PDT) Received: from ?IPV6:2400:4050:a840:1e00:4457:c267:5e09:481b? ([2400:4050:a840:1e00:4457:c267:5e09:481b]) by smtp.gmail.com with ESMTPSA id i12-20020a17090acf8c00b0024779068491sm3387948pju.26.2023.04.21.22.26.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 22:26:42 -0700 (PDT) Message-ID: <4b2afbbe-9335-e0b4-24ad-32e7cc7ad194@daynix.com> Date: Sat, 22 Apr 2023 14:26:40 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 2/2] config/arm: Enable NUMA for generic Arm build To: Ruifeng Wang , Bruce Richardson Cc: "dev@dpdk.org" , nd References: <20230414124139.66443-1-akihiko.odaki@daynix.com> <20230414124139.66443-3-akihiko.odaki@daynix.com> Content-Language: en-US From: Akihiko Odaki In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/04/20 16:20, Ruifeng Wang wrote: >> -----Original Message----- >> From: Akihiko Odaki >> Sent: Friday, April 14, 2023 8:42 PM >> To: Ruifeng Wang ; Bruce Richardson >> Cc: dev@dpdk.org; Akihiko Odaki >> Subject: [PATCH 2/2] config/arm: Enable NUMA for generic Arm build >> >> We enable NUMA even if the presence of NUMA is unknown for the other architectures. Enable >> NUMA for generic Arm build too. >> >> Signed-off-by: Akihiko Odaki >> --- >> config/arm/meson.build | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/config/arm/meson.build b/config/arm/meson.build index 724c00ad7e..f8ee7cdafb >> 100644 >> --- a/config/arm/meson.build >> +++ b/config/arm/meson.build >> @@ -271,13 +271,15 @@ implementers = { >> soc_generic = { >> 'description': 'Generic un-optimized build for armv8 aarch64 exec mode', >> 'implementer': 'generic', >> - 'part_number': 'generic' >> + 'part_number': 'generic', >> + 'numa': true > > The default value of numa is true. So no need to add it here? > > if not soc_config.get('numa', true) > has_libnuma = 0 > endif You're right. I confirmed this change is unnecessary. Please ignore this patch and consider merging only the first patch of this series. > >> } >> >> soc_generic_aarch32 = { >> 'description': 'Generic un-optimized build for armv8 aarch32 exec mode', >> 'implementer': 'generic', >> - 'part_number': 'generic_aarch32' >> + 'part_number': 'generic_aarch32', >> + 'numa': true >> } >> >> soc_armada = { >> -- >> 2.40.0 >