From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 53CFB9E3 for ; Thu, 27 Apr 2017 11:43:38 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2017 02:43:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,383,1488873600"; d="scan'208";a="850356215" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.58.98]) ([10.254.58.98]) by FMSMGA003.fm.intel.com with ESMTP; 27 Apr 2017 02:43:36 -0700 To: Wei Zhao , dev@dpdk.org References: <1493271581-56385-1-git-send-email-wei.zhao1@intel.com> From: Ferruh Yigit Message-ID: <4b2ef680-c9b7-6358-c3b7-f60b9b204585@intel.com> Date: Thu, 27 Apr 2017 10:43:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <1493271581-56385-1-git-send-email-wei.zhao1@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix ntuple filter support for sctp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2017 09:43:38 -0000 On 4/27/2017 6:39 AM, Wei Zhao wrote: > Add the support of RTE_FLOW_ITEM_TYPE_SCTP type packet for > ixgbe ntuple filter. > > v2: > --add type check of RTE_FLOW_ITEM_TYPE_SCTP for item flow. For version information in the commit log, can you put it as: Below signed-off tag, in new line put three dashes "---", later put the version information. This way git automatically strips that part when applied, otherwise maintainer manually needs to do the update. And can you please send new version of the patches using git send-email "--in-reply-to" option, otherwise it is hard to trace the patch versions and previous comments on it. Thanks. > > Fixes: 672be56d76a ("net/ixgbe: parse n-tuple filter") > > Signed-off-by: Wei Zhao > --- > drivers/net/ixgbe/ixgbe_flow.c | 30 ++++++++++++++++++++++++++++-- > 1 file changed, 28 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c > index e2ba9c2..98e414a 100644 > --- a/drivers/net/ixgbe/ixgbe_flow.c > +++ b/drivers/net/ixgbe/ixgbe_flow.c > @@ -142,6 +142,8 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr, > const struct rte_flow_item_tcp *tcp_mask; > const struct rte_flow_item_udp *udp_spec; > const struct rte_flow_item_udp *udp_mask; > + const struct rte_flow_item_sctp *sctp_spec; > + const struct rte_flow_item_sctp *sctp_mask; > uint32_t index; > > if (!pattern) { > @@ -253,7 +255,8 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr, > index++; > NEXT_ITEM_OF_PATTERN(item, pattern, index); > if (item->type != RTE_FLOW_ITEM_TYPE_TCP && > - item->type != RTE_FLOW_ITEM_TYPE_UDP) { > + item->type != RTE_FLOW_ITEM_TYPE_UDP && > + item->type != RTE_FLOW_ITEM_TYPE_SCTP) { There is a function comment, that documents the expected/valid pattern types, that should be updated with this new type.