From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C25EA04B7; Tue, 13 Oct 2020 15:10:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2345A1DA83; Tue, 13 Oct 2020 15:10:51 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 896B51D736 for ; Tue, 13 Oct 2020 15:10:48 +0200 (CEST) IronPort-SDR: bwlCWlx1ujl/iWNAVOc7a4Z+Yj7xiNAfu8iU8LqYhHG0sYxxSc7w+AEAtD/tajv9m6quaSTMG9 8oIQove733Pg== X-IronPort-AV: E=McAfee;i="6000,8403,9772"; a="165116434" X-IronPort-AV: E=Sophos;i="5.77,370,1596524400"; d="scan'208";a="165116434" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 06:10:46 -0700 IronPort-SDR: ZwUKHb9iisilzPADTiB9jipoapq6Q1D9MZIE79MdEF0psBsUsvRboKRFe6xa3B4hCbPPe3m36v P7jrWfkRixjA== X-IronPort-AV: E=Sophos;i="5.77,370,1596524400"; d="scan'208";a="530389290" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.214.64]) ([10.213.214.64]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 06:10:34 -0700 To: Thomas Monjalon , dev@dpdk.org Cc: arybchenko@solarflare.com, Stephen Hemminger , Haiyue Wang , Jeff Guo , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Somalapuram Amaranath , Ajit Khaparde , Somnath Kotur , Chas Williams , "Min Hu (Connor)" , Hemant Agrawal , Sachin Saxena , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Wei Hu (Xavier)" , Yisen Zhuang , Beilei Xing , Jingjing Wu , Qiming Yang , Alfredo Cardigliano , Shijith Thotton , Srisivasubramanian Srinivasan , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Harman Kalra , Rasesh Mody , Shahed Shaikh , Andrew Rybchenko , Keith Wiles , Maxime Coquelin , Chenbo Xia , Zhihong Wang , Yong Wang References: <20200913220711.3768597-1-thomas@monjalon.net> <20201013100634.2482593-1-thomas@monjalon.net> <20201013100634.2482593-3-thomas@monjalon.net> From: Ferruh Yigit Message-ID: <4b439205-55e2-5ba4-903a-90056887e980@intel.com> Date: Tue, 13 Oct 2020 14:10:28 +0100 MIME-Version: 1.0 In-Reply-To: <20201013100634.2482593-3-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 2/3] ethdev: reset all when releasing a port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2020 11:06 AM, Thomas Monjalon wrote: > The function rte_eth_dev_release_port() is partially resetting > the struct rte_eth_dev. The drivers were completing this reset > with more pointers set to NULL in the close or remove operations. > > More pointers are reset at ethdev level, > and some redundant assignments are removed from PMDs. > > Signed-off-by: Thomas Monjalon > Acked-by: Stephen Hemminger > Reviewed-by: Haiyue Wang > Acked-by: Jeff Guo > Reviewed-by: Andrew Rybchenko Reviewed-by: Ferruh Yigit