From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3BEBA034D; Wed, 12 Jan 2022 03:41:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD46541145; Wed, 12 Jan 2022 03:41:06 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id E6816410FD for ; Wed, 12 Jan 2022 03:41:04 +0100 (CET) Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4JYWxR4GMWz9s5K; Wed, 12 Jan 2022 10:39:55 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Wed, 12 Jan 2022 10:41:03 +0800 Subject: Re: [RFC] ethdev: introduce ethdev dump API To: Thomas Monjalon CC: , , References: <20220111115437.32855-1-humin29@huawei.com> <3408456.iIbC2pHGDl@thomas> From: "Min Hu (Connor)" Message-ID: <4b666dfb-aa0c-a166-c171-7399c82d6fba@huawei.com> Date: Wed, 12 Jan 2022 10:41:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <3408456.iIbC2pHGDl@thomas> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Thomas, fixed in v2, thanks. ÔÚ 2022/1/11 20:48, Thomas Monjalon дµÀ: > Please use --cc-cmd devtools/get-maintainer.sh so all maintainers are Cc'ed. > > 11/01/2022 12:54, Min Hu (Connor): >> --- a/doc/guides/rel_notes/release_22_03.rst >> +++ b/doc/guides/rel_notes/release_22_03.rst >> @@ -55,6 +55,12 @@ New Features >> Also, make sure to start the actual text at the margin. >> ======================================================= >> >> + * **Added the ethdev dump API, for query private info of ethdev.** >> + >> + Added the ethdev dump API which provides functions for query private info >> + from device. There exists many private properties in different PMD >> + drivers. The information of these properties is important for debug. As >> + the information is private, the new API is introduced. >> > > A blank line is missing. > Also please check the comment above asking to start the actual text at the margin. > > [...] >> +typedef int (*eth_dev_dump_t)(struct rte_eth_dev *dev, FILE *file); > > There is a dump function for rte_flow: rte_flow_dev_dump(). > This one should have a clear scope: private device infos? > > > > . >