From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83B42A00C5; Wed, 14 Sep 2022 18:43:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 762264021D; Wed, 14 Sep 2022 18:43:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BA13B40156 for ; Wed, 14 Sep 2022 18:43:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663173832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l3V/g0Lr0ZdeTnmXGfG1X2GQJg+j7EF/FPzN+E7v4gA=; b=a7czTTwScabYVtH+WKZmUBMK+MbH79u+as2FF+umiwcu0sfeJx94ivIvrWIVG3Qjike6Y5 FcPFtk+xFvWmobzdh+XSyKkmudRHBhOrxZ9OmL7dxZh1vJkrqpjxRWcRGBlOWd67QmZTE/ 0ZgaMZSznW9xnZb+uRMA+OO0lunnBN0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-137-KSyJU6QHN5-cDuZzbgJSuQ-1; Wed, 14 Sep 2022 12:43:48 -0400 X-MC-Unique: KSyJU6QHN5-cDuZzbgJSuQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AC81F294EDE4; Wed, 14 Sep 2022 16:43:47 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E51340C6EC2; Wed, 14 Sep 2022 16:43:46 +0000 (UTC) Message-ID: <4b764454-de2a-dd5b-6c28-c264bcf721b6@redhat.com> Date: Wed, 14 Sep 2022 18:43:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-3-hernan.vargas@intel.com> From: Maxime Coquelin Subject: Re: [PATCH v2 02/37] baseband/acc100: update ring availability calculation In-Reply-To: <20220820023157.189047-3-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, On 8/20/22 04:31, Hernan Vargas wrote: > Refactor of the queue availability computation to prevent the > application to dequeue more than what may have been enqueued. > That sounds like a fix, is it? If so, it should have the Fixes tag, so that existing application can get the fix without having to upgrade to a newer DPDK version that may have introduced API/ABI changes. > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 39 ++++++++++++++++-------- > 1 file changed, 27 insertions(+), 12 deletions(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 7f698ec3d2..0598d33582 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -3465,13 +3465,27 @@ acc100_enqueue_queue_full(struct rte_bbdev_queue_data *q_data) > acc100_enqueue_status(q_data, RTE_BBDEV_ENQ_STATUS_QUEUE_FULL); > } > > +/* Number of available descriptor in ring to enqueue */ s/descriptor/descriptors/ > +static uint32_t > +acc100_ring_avail_enq(struct acc100_queue *q) > +{ > + return (q->sw_ring_depth - 1 + q->sw_ring_tail - q->sw_ring_head) % q->sw_ring_depth; > +} > + > +/* Number of available descriptor in ring to dequeue */ s/descriptor/descriptors/ > +static uint32_t > +acc100_ring_avail_deq(struct acc100_queue *q) > +{ > + return (q->sw_ring_depth + q->sw_ring_head - q->sw_ring_tail) % q->sw_ring_depth; > +} > + > /* Enqueue encode operations for ACC100 device in CB mode. */ > static uint16_t > acc100_enqueue_enc_cb(struct rte_bbdev_queue_data *q_data, > struct rte_bbdev_enc_op **ops, uint16_t num) > { > struct acc100_queue *q = q_data->queue_private; > - int32_t avail = q->sw_ring_depth + q->sw_ring_tail - q->sw_ring_head; > + int32_t avail = acc100_ring_avail_enq(q); acc100_ring_avail_enq returns an uint32_t, but avail is an int32_t. I think avail should be a uint32_t and underflow check should be changed to: if (unlikely(avail == 0)) { Same comment applies in other places. Maxime