From: "Menon, Ranjit" <ranjit.menon@intel.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH 0/2] eal/windows: restore mistakenly hidden API
Date: Wed, 1 Sep 2021 12:35:01 -0700 [thread overview]
Message-ID: <4bc6d918-dcee-8b7b-888b-52ad025e39ed@intel.com> (raw)
In-Reply-To: <20210829021602.290466-1-dmitry.kozliuk@gmail.com>
On 8/28/2021 7:16 PM, Dmitry Kozlyuk wrote:
> Some functions were not exported, and UUID API not even built on Windows
> for no compelling reason. This hasn't been an issue so far, because only
> static build is currently available on Windows, however:
> 1) it's better to have fewer differences between platforms;
> 2) enabling shared build is planned for the near future.
>
> I don't believe this patchset should be backported
> because it doesn't fix any actual issue for 20.11.
>
> Dmitry Kozlyuk (2):
> eal: remove Windows-specific list of common files
> eal/windows: fix export list
>
> lib/eal/common/meson.build | 63 +++++++++-----------------------------
> lib/eal/version.map | 32 +++++++++----------
> 2 files changed, 31 insertions(+), 64 deletions(-)
Acked-by: Ranjit Menon <ranjit.menon@intel.com
<mailto:ranjit.menon@intel.com>>
next prev parent reply other threads:[~2021-09-01 19:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-29 2:16 Dmitry Kozlyuk
2021-08-29 2:16 ` [dpdk-dev] [PATCH 1/2] eal: remove Windows-specific list of common files Dmitry Kozlyuk
2021-09-01 17:20 ` William Tu
2021-08-29 2:16 ` [dpdk-dev] [PATCH 2/2] eal/windows: fix export list Dmitry Kozlyuk
2021-09-01 17:21 ` William Tu
2021-09-01 19:35 ` Menon, Ranjit [this message]
2021-09-30 20:48 ` [dpdk-dev] [PATCH 0/2] eal/windows: restore mistakenly hidden API Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bc6d918-dcee-8b7b-888b-52ad025e39ed@intel.com \
--to=ranjit.menon@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).