From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01hn0201.outbound.protection.outlook.com [104.47.2.201]) by dpdk.org (Postfix) with ESMTP id D32911E20 for ; Thu, 22 Feb 2018 13:57:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vaWBp2R5wsYFoB+roANlQ5KU6QuuPmIxi15bPl/9Rtw=; b=JSwVe4pzei6a19MN2n/9PIqp34THxwIHGYxvzt/gOPmQ0BzCAZJgOGw9djy6PsErjXTu5VzZdrouIXA8XltaGcwT4mpAB51ELh9w+Fly3VDyqTNmokKCbNqjsaDkmVia5OWXBBhIKNlMuNN2k5QTutuP91qYkGnxetI8G0vSLkM= Received: from [10.232.14.39] (192.88.169.1) by VI1PR0401MB2464.eurprd04.prod.outlook.com (2603:10a6:800:55::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.506.18; Thu, 22 Feb 2018 12:57:24 +0000 To: Nipun Gupta Cc: thomas@monjalon.net, hemant.agrawal@nxp.com, dev@dpdk.org References: <1519292089-13851-1-git-send-email-nipun.gupta@nxp.com> <1519292089-13851-6-git-send-email-nipun.gupta@nxp.com> From: Shreyansh Jain Message-ID: <4be9feae-544a-65db-1871-5f80b23c0e9b@nxp.com> Date: Thu, 22 Feb 2018 18:42:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1519292089-13851-6-git-send-email-nipun.gupta@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.88.169.1] X-ClientProxiedBy: SG2PR0601CA0017.apcprd06.prod.outlook.com (2603:1096:3::27) To VI1PR0401MB2464.eurprd04.prod.outlook.com (2603:10a6:800:55::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: ff3c65da-a710-4027-6e42-08d579f3d307 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:VI1PR0401MB2464; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0401MB2464; 3:E8uq72aMd9Ziqc0H8HJU2npQfd9ZN05oIoOiztW3CSOXGz8I+IDTEcnK3mDbkVFgrnPN19/L4NPKFmKUe7L9Ry4ntx5gGaiJKiwCTqk7Ri4bqvSYYhC4OBypqdZ3xMWDqa8XfBRv7APCjk4AzBhS1+ey4a8ZEPrvrAHvWzW8qTA2RNDpVHbf9B4Yw6PQ7wwLvAocqwZ4P1Y9Y4Hwtxd8j0z12SNl7SXNsJA6cSwaYux4SPEF2UeQEXkPvBDrzHVk; 25:lmeNMF2U6HP/Qc/5NAmYtFosMiHicCd+aWnqnyPiW1P+CEmLb1WjPCXQAbHskGo6vDPEHiM4SToKIynE/Xf33Zw3P0alWPqWyPPga3IdkiBExO4XneANhQfEPsOmb5CjdwfPcnhFpb3MFJ081OAwC2/TWSSl8p7fY2xYcgNptY6GuF6MSAtYuJTj9l5N5WNAi0wY2W35a1urG5mfQluPbtCig66yczxjZER6O6jUcKVruFqXZ0ZtTRxPPpkZDQw8kO/h7kz9D/gOdJWPQeg04bru7bQMolmNOKhxuV7me+dUbEV+f5KmSwUjt6O01jP0uWWiNg3jsBQbzyJPqElu0A==; 31:rV4F0gdyhiIxVRUWI8mi+d3ijb7JQ8GaXKAw+BOs4QV1HaiDc3c3FnqumNvBZRZrhkl5i86aG6X+84OfODKVdYzEAzJXulaPzuwJ7lxSsXExwaWBvPeqKccJEDQMyaL6MkFqnzw0IMpcgJ0E1tEKdBFcLFFQC7T31W6W2qDSTy9wN4Pd3pLbiTZX1suUr26psikV/Yi1YXqcghocCaZcMFezi6B0yWiMe2u4sqvX7Rc= X-MS-TrafficTypeDiagnostic: VI1PR0401MB2464: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0401MB2464; 20:yiHamdGWGCfkM2Lvc7Xmnx5f8dy0/xbStSX1RPWBt8wWFvYjlMcjX74GqoymM13J+4f9Rn4sDvXalIzvnfV+bhma/DCCs7tinyryexz9iueXth5L0QMH6+4XM7y5CfFCXyOAc52+IBUZ2iTONGwK+zuxJTJ36Q8A7e4aeJ0wmCkepBUP3gl5wV7xFBaE1sc61tP0JrOqAYSRdQx0ip11Z72ch+Gbg9oE4woNkyVFwk5EZI4FdN+CFy4OW+e/v4cm2XXk16cRtaihxesS1TectjIjkpECvnFW4R8PrMdZgSFnOiSSZBBLl4AgpAcxV0VtZnTWHHgFUDBu5qK4vYsD0fZhAU+Aj0mMDFtPkzXUMunLz6Mq46U3KOvLOagQ4JvSnLjDu3VCSdxFFghu61NoT58UAD/KuW1SeSLymXizPsGocs8QSw9V0V9AF/dXBRoc6EfX4AaHDR8Mukjquf6Ctpz9Bd2VxECgtOZImEIaplrIdGVeRstPmkKi/2ATKmFJ; 4:6vTIcpiKTCIeDaOaF7koQrUGOdjRtgTBnvaCYimPR+X6nU8G7jXRw1BJn/TrffWEoVjW3jQvgU38HQf9KealrynboOqZpQLqNtgS/EBGrkOYBkTZbDCBgkDlMx3j8JdPTOmGA67QJddh2Qu4wULV75B6p4Ynl2LALeJC0D0bsXcTaCzlxHdn3SlioxBbXsdJ6p2C+UksBO7O7myfWonPe3SSf1dVbUKokbyrtQdVNbMbFR0LMywHTLOmHNNFtupufi/AMf8+GXC1EnwZbwtb9lfO2cT2KYFgEFR7RBmk2sHoPWJvctY5yRtl7+1EYF7Jd2gYsUHLfYo0guZf1XL1wUh/XItqN82YmNeQULSLNHM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(66839620246622); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001079)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231162)(2232076)(944501161)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:VI1PR0401MB2464; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0401MB2464; X-Forefront-PRVS: 059185FE08 X-Forefront-Antispam-Report: SFV:SPM; SFS:(10009020)(6049001)(376002)(39860400002)(39380400002)(396003)(366004)(346002)(189003)(199004)(6116002)(7736002)(67846002)(3846002)(5660300001)(31686004)(6862004)(6246003)(58126008)(86362001)(81156014)(2906002)(65826007)(77096007)(81166006)(8676002)(26005)(6346003)(8936002)(105586002)(65806001)(37006003)(65956001)(66066001)(16526019)(31696002)(186003)(229853002)(47776003)(2950100002)(316002)(23676004)(52146003)(2486003)(6636002)(6666003)(52116002)(106356001)(6486002)(230700001)(16576012)(386003)(76176011)(25786009)(97736004)(36756003)(53936002)(305945005)(68736007)(64126003)(50466002)(478600001)(4326008)(59010400001); DIR:OUT; SFP:1501; SCL:5; SRVR:VI1PR0401MB2464; H:[10.232.14.39]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA0MDFNQjI0NjQ7MjM6eFdRRW9zU3Z0dW5uZ1hGNjNCaEg2Q1dx?= =?utf-8?B?Z3l2TnUvbG1WS3RsNEttc1NhWjRtWnNvUFoyQWdBTDc0SVhRQXdqTHBQZEUr?= =?utf-8?B?RG1XV3pnZUVBUnNkK0dSRjVINWF3cldCTm5tQVdTQ01seXhTYngxdTFtZ0hz?= =?utf-8?B?enRURHcvam0vV1VLS2RsK2p5YlU5ZlJlYkVLUXZzMlhOQzBNZG9vSVprOHBD?= =?utf-8?B?TXFLWGxYNU9wWVQyZnhEbC9xNUVEb1lzelpVa0xNZ2djNW9QVHZUbnZoTlZE?= =?utf-8?B?YTRPZUllQWJFWnk2em1keEROeU5SdkN4MmVCVk91RUJsR2xROEpzeUdwN1py?= =?utf-8?B?cGgzZnZWbXRFY05jQ2FZL3JGQVRvNHU1d2ZuZllrL2U3dFlDS3JWdTRwL252?= =?utf-8?B?REt4MEV3RmZRM0tCamM3NEFBMFM3NnlnOWY5TFpib2NvL3NYSTZlWFVhSXIw?= =?utf-8?B?RTFLdURHNVZoQUZLOUJxOXpvc05ySit4TDJ2MCtLU3creFdiWnVtMy9paDVF?= =?utf-8?B?WDhVUGZkQ1RCc0J1aXdJdytXSWpLRW4wL3FpUE5Sa2REQ2hDamhBTklKUUlF?= =?utf-8?B?OUgrTysyTDZ6ekZiS0dkMlJ6czNIbzUxMGpiUnFtR2dFbzBEV2hEMDFBdU1j?= =?utf-8?B?TFdZTDl6aktGdVJDaE1PMDhFZGY4VUxVcG55eHRRYTc5aHZtckxvd3Rqb2xN?= =?utf-8?B?TXF3cmlaTDVQejhZZHVPeHZ0b0xMVzh5N2dpWUVKaU5JNnlndVZ0RGE3eUhx?= =?utf-8?B?UEl1YzRPNDFyQ1U1SmJKbWRjVGg4dTZTRFk0Sy9yMUZRWUk0K3ZZbkpQTVFN?= =?utf-8?B?eVRXOFlUUE1GMDRwdFl2YkovaDFZTVI2MVk3VGtRVlRJeEhTdVJkQ3luRXVT?= =?utf-8?B?cU53eE9KUGcxcHByVStSNGZjTzNvVGg1MXdubnJyS1BOUE8vK1h6elMrNTls?= =?utf-8?B?UXNBb3hMVTZPYlpIWHZoWGFTUXdiSHFxZVhMdlZVTDZIajF1c0JvVi9VbnlX?= =?utf-8?B?QUI4TGVBMDN4TkFQMlNYemFSV05MS1hpYkhtMmxZL2lNbnRJQTRTaXBrQm5i?= =?utf-8?B?bm8rL2hxL25vczU1RlRIcDlvanlndHB2NHJjR0RmZkwraTJkUHN5eU5DQ0hu?= =?utf-8?B?OGU0ZGRQbnZjcDlkNnhhTys3RmNFNkZGWU96NWU2MW5XbDZwSnJXcDl1dlZD?= =?utf-8?B?bDhMMk44eEVzS3Fzekd3WklkbUp5NTJzQmVkeC9qTm0rSGRRNU1abVV1TDdo?= =?utf-8?B?bVlWZ1JQSVRGL3hVN1Y1blo5K0xUbExjbStiRi9ua3FWaFFoTmZhYTJiYmEr?= =?utf-8?B?UlZKMUNNSDlRdlJlVHpQdGxKeTExRTlNVkwzYUxyQUtxUDNGR3VhOEFtcHps?= =?utf-8?B?cmVPZkpWRTkvKzl2OXR0QldNOWxTR0VNYzhCSkIxekxFM2YwallLalRTOHdO?= =?utf-8?B?c0FMV1FxcDMrMkFlTURYTlFQcnRvNUF1V1RTeTlaVmdtWW9hbEZLcmwvQTNT?= =?utf-8?B?eFlFRU9Ta3dSWWt0c3Z2bGl6MDlkVUNadTdmZU5hS3JoQWRxbWVXTlBQdDR2?= =?utf-8?B?aTNJcGlWWWo5UWM1SkdQVjBSV0xFVlJmaGwrejgxUWRtaUMvVmJHNkx3NXYr?= =?utf-8?B?VjN1SWxvdFpsRDFJbWhvUFZrL3piaHRtRHZONytBOXBlOUlseXhFOW02WHdk?= =?utf-8?B?cXlRVjRxd1BoVUdwcEZpRlV2L0ZNOHZLaTlLZ3VnNUdienlrbHdmWGRGcWkv?= =?utf-8?B?OXFqMFYwTmN3QXFoMTl4Ti9xTmJYRmU5cWpFQkpnWExKRTNNWDVDOFEySGVB?= =?utf-8?B?bkFSeWJPMFNrMkduZzh4TThkZlhZWkJzc1lDU2tpK0JGU2tVMHBBZU5PTGlZ?= =?utf-8?B?YWhPTVAvL21jbWFZMFRLeFc5NUdlWHVUQ3A5YkEyaVJGL29NSUdiTTN1RDBB?= =?utf-8?B?c2ZXRkFuanBScEF3L0xBT0pPRDRpRUZieWdvMUFyR0VpRkNWbW9nMTNiZGZP?= =?utf-8?Q?z5rKFu6m?= X-Microsoft-Antispam-Message-Info: yeMjuTpjeLh0OCIxhKXdYIOWL1o+tufD4nB7xQWFPEAbJw3OjllNfpxADNOKfO5kP4XB2iBT7LwTQBHOlxL2G8Cpe/ZDMZDRFAkNidelTCkiAGlbR5S6rGUhxS7MzZoC9DZ3B+LH7BtGv6AcwhAS4r2ehT/vGnJ1xsau6j6KP2M= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0401MB2464; 6:IfhZCE1s9Xivm6zuQUvLY70Bd4lTr0ZAdVVoBqNXph85Tk36tHSuuHOGxyNBeMhDsJgrBNxNVuw6F25m+N9FiW4Z3+lL5y2XtlwZuXdTBqlOMODec6jj1b9Q//Lzm/ukYHP/qXAIJwiZw2Fbe6lrCvTSFS4J6APSOPvXXn19GQC8/SALTI7xhyCs59nOQfKzoFoCW/795p6v6uTiEFfKtaJyhtuMt8iwH9L6psD30kgCFPqJ3ttoHvi0p7dgvX3VKvhBQ+dmpNwKxp1/Ta6ZFVFg/sZlpCUUb9D0VSX4V//UAnnzqkOcDIn0ZbuzFdxBYxqZj6heT1/h6WxHn8UzHzgjuB0kw2A4X/mMpgpu/b8=; 5:HHVEo5wJru3hqwTiIvGIPcCmZqm4xvm7QK19LNKY3DcMUARaQJVwTrQ0jLBDzY1fx0gGQFDH6Dw47ngBa1qHe1skP04ox557QTNLJ5h8767oxTcjEisU5Gx42o6CJb5qiuGBUSoKtQoM2BuZvZd8WaCdFPSRsL+2Sc/QF0+nO+8=; 24:dEkDZLHsCW9JmydIFANIaUJjNbt7T1qXg7g9QKOCLsMF8NI40pMYbXUxAVrW+FGjNF6e9pLpkyotd9KzTMdRWw==; 7:yBeYO/i0niPC4A1auT08b8X8JKl7VEfBVt2Je+q1BT34sP77pBzzFBs7engncF83UWS+Gs0WJv8A/Yw/+8I/qUch3g6H4/+R/gFYMjNlflQHDTwJCSSPCHnZmpgi6pQA26yOnXsh+gsridtPw7yHuNf9E9B9dQ+cN8BozpLKjUosmJKnNbm15HnwX8cSw1Kj4Iyze1qNGX/ytID4tTFN9mXNpW9o2J3+S/BNB2Q46hDGrhEBRk6R4VnAp/Kke47O SpamDiagnosticOutput: 1:22 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2018 12:57:24.9786 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ff3c65da-a710-4027-6e42-08d579f3d307 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2464 Subject: Re: [dpdk-dev] [PATCH 5/9] raw/dpaa2_cmdif: introduce DPAA2 command interface driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 12:57:29 -0000 Hi Nipun, Some trivial inputs: On Thursday 22 February 2018 03:04 PM, Nipun Gupta wrote: > Signed-off-by: Nipun Gupta > --- > MAINTAINERS | 6 + > config/common_armv8a_linuxapp | 5 + > config/common_base | 5 + > config/defconfig_arm64-dpaa2-linuxapp-gcc | 6 + > drivers/raw/Makefile | 1 + > drivers/raw/dpaa2_cmdif/Makefile | 33 +++++ > drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 139 +++++++++++++++++++++ > drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h | 35 ++++++ > .../dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map | 4 + > mk/rte.app.mk | 1 + > 10 files changed, 235 insertions(+) > create mode 100644 drivers/raw/dpaa2_cmdif/Makefile > create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c > create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h > create mode 100644 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map > > diff --git a/MAINTAINERS b/MAINTAINERS > index a646ca3..e06df3b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -725,6 +725,12 @@ F: drivers/crypto/zuc/ > F: doc/guides/cryptodevs/zuc.rst > F: doc/guides/cryptodevs/features/zuc.ini > > +Rawdev Drivers > +-------------- > + > +DPAA2 CMDIF > +M: Nipun Gupta > +F: drivers/raw/dpaa2_cmdif/ I think you should put one more new line here. For all the sub-section for Maintainers, there are 2 new lines before new sub-section starts. > > Eventdev Drivers > ---------------- > diff --git a/config/common_armv8a_linuxapp b/config/common_armv8a_linuxapp > index 507b28a..32e3cfe 100644 > --- a/config/common_armv8a_linuxapp > +++ b/config/common_armv8a_linuxapp > @@ -94,3 +94,8 @@ CONFIG_RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS=2048 > # > CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=y > CONFIG_RTE_DPAA2_SEC_PMD_MAX_NB_SESSIONS=2048 > + > +# > +# Compile DPAA2 Command Intefrace driver ^^^^^^^^^ Interface - spell mistake > +# > +CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF=y > diff --git a/config/common_base b/config/common_base > index ad03cf4..a549b54 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -587,6 +587,11 @@ CONFIG_RTE_RAWDEV_MAX_DEVS=10 > CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV=y > > # > +# Compile DPAA2 CMDIF support > +# > +CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF=n > + > +# > # Compile librte_ring > # > CONFIG_RTE_LIBRTE_RING=y > diff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig_arm64-dpaa2-linuxapp-gcc > index afdbc34..ce1ffc5 100644 > --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc > +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc > @@ -42,3 +42,9 @@ CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX_FREE=n > CONFIG_RTE_LIBRTE_DPAA2_SEC_DEBUG_INIT=n > CONFIG_RTE_LIBRTE_DPAA2_SEC_DEBUG_DRIVER=n > CONFIG_RTE_LIBRTE_DPAA2_SEC_DEBUG_RX=n > + > +# > +# Compile DPAA2 Command Intefrace driver > +# > +CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF=y If already added in armv8a, why is it required in arm64-dpaa2 as well? Rawdevices are intended to be custom and I think they should be added only to the SoC specific configuration files. - Shreyansh