From: Ferruh Yigit <ferruh.yigit@amd.com>
To: fengchengwen <fengchengwen@huawei.com>,
Kaiyu Zhang <squirrel.prog@gmail.com>,
thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru
Cc: dev@dpdk.org
Subject: Re: [PATCH] lib/ethdev: sanity check on callback before resource allocation
Date: Tue, 11 Jul 2023 14:37:37 +0100 [thread overview]
Message-ID: <4bebf81e-11e5-aa86-4140-8e4f8c667d52@amd.com> (raw)
In-Reply-To: <bf4a4fd9-be24-c0fe-fe67-f89d0868d6bc@huawei.com>
On 7/11/2023 2:48 AM, fengchengwen wrote:
> On 2023/7/11 9:18, Kaiyu Zhang wrote:
>> sanity check is performed after a rte_eth_dev object is allocated.
>> The object is not freed if the check fails, though in the current
>> reality this never happens, but it's better programming paradigm
>> to move the quick check up front to the start of
>> rte_eth_dev_pci_generic_probe.
>>
>> Signed-off-by: Kaiyu Zhang <squirrel.prog@gmail.com>
>>
>
> Reviewed-by: Chengwen Feng <fengchengwen@huawei.com>
>
Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers")
Cc: stable@dpdk.org
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
next prev parent reply other threads:[~2023-07-11 13:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 1:18 Kaiyu Zhang
2023-07-11 1:48 ` fengchengwen
2023-07-11 13:37 ` Ferruh Yigit [this message]
2023-08-01 16:19 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bebf81e-11e5-aa86-4140-8e4f8c667d52@amd.com \
--to=ferruh.yigit@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=squirrel.prog@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).