From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E47643867; Mon, 8 Jan 2024 19:07:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A75F84067C; Mon, 8 Jan 2024 19:07:34 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2088.outbound.protection.outlook.com [40.107.212.88]) by mails.dpdk.org (Postfix) with ESMTP id 430AF402DF for ; Mon, 8 Jan 2024 19:07:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KlwrGCPDH/3Upif3jg8lIYM99MGSIcm3v8bYkzh0Mib6qdr3bv8j1j4Ksgs+kFLOITuT/cxgzaGCV7eZiuSa30w5ZgGCh8XG+n69i5wrT7S5Vf3t9dT3iv51DKV4cPjWpe0mqQ6z3iRjIWjF4dPZkRpiw7y9QLXwqFemiuzkQ+RE8fwE5WWT/73FU7y+F8PZZ8xfkjJbPKldXm6905HnHAEz4agCKtnLDogbZe/c/p5zs/vFcD3giJLRG1qY1elLCKeR4fJIe0FEpdRHtqv+BTS0S8HHmIF2O/4RuGU2uV7MUP7GnvElLGGi0ZpQeaJXfZpxskSYpreMswNGYxUPnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tJULUBPjTMfqBcZVcBtbr2qiak67jEuIgal4D4fEnbU=; b=fKEVMV9e/+e40cICzBNyKI13OfuXIxyTvr+uRC1bv09TSqmYPBuwA6RpZUtcIh6S92fYHnE1zfGCBW+Ddb7imnzrM+xDsQhDp2jiy0MYY0PGc1zvZuY7pULE/LHUDf/TK6xxt8f/CRZ6oO/zAVpNWXyN4xNTLJaEOdoe7vqc8IhbkOiXNoCxGJg3RIeFy0J5cPFFgOl79l25dkp3RkZk9tc3vdHNn5vbXcWNj/v1WgvR62W7UTeCImosyRHY9e79aLv872LQMe7kzyX+yDR+RvdG1bzmhs79Vubj60fnLwN1U2pDmZqgPT9IuZX5+YVIHo7p7NcvTvTRK/oL9hMTeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tJULUBPjTMfqBcZVcBtbr2qiak67jEuIgal4D4fEnbU=; b=pjTd/nYxkuLjgf0R/M4qT0AK+IpLoDxvq7H4o7ROFJVEq3R0X86+pBmiKL7BSVX/6yfIv9gsoXHsHiP9QEkfYylHTC9c5lwndnClmulMEAoCVj7ECPEDEaP1NlJ+NClFqZLHha/edNEIa0UODzjfkIKQSRDEIm/9hoKEZMQx5YQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB6278.namprd12.prod.outlook.com (2603:10b6:8:a4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.21; Mon, 8 Jan 2024 18:07:30 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7159.020; Mon, 8 Jan 2024 18:07:30 +0000 Message-ID: <4c02c5b6-2b57-4048-9253-8524afdab7f5@amd.com> Date: Mon, 8 Jan 2024 18:07:25 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/hns3: don't support QinQ insert for VF Content-Language: en-US To: Jie Hai , dev@dpdk.org, Yisen Zhuang Cc: fengchengwen@huawei.com, lihuisong@huawei.com References: <20231228121429.1264196-1-haijie1@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231228121429.1264196-1-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB6278:EE_ X-MS-Office365-Filtering-Correlation-Id: c6fb9a7b-ef39-4405-5e66-08dc1074addc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uGnqvAgsnG0YW7JcNx6Puzr29Y3YCRWFyezIU/Vh4F+ReFee1PH4AbJ76LlPdEOMXCv8+5FtsZlkvUhEGLM5m/J2hLwht9Vr++5wnYiJjfI1qmX+CrgVCI31yA5lVZkXUSYGVPfmWVGhfxMdN0NPs/yOMWVStbSdcJwlD/nBasiH00uLxftCPXz0asDFhzglytENHX0Y5aezPaUF1CjJMwfAd+JHorkIGeljddGkN2FvXG8Ct55rCtyBLHjzijdGg0Fdj/mfgs117qjjDWOSwjaAaR9Ip7bqSBDugdoiC7w25oiIVtPuljoRFXhfHf5rAjNuQFrF152mPi40wkqoMirv7S2rEvrN146q32/0VodHiOjtzFUcOYWVTHvgbr1hbyvsF57VW+rNrVeBInC50w7GKrAl0/ru+mtEO0be5pgEfREbx3ZOVYIXp0n8nZ1tQ0ECw3E8SjBctxbdVqh0dpALAwbgRKkSrWa1ZAhDKYIas6tCZORHARRUt9uLTLCwwKIlJu+7lsLkSXbsyH/62sA8RBZNwLm+HJRXCxyowovAyc0/9ixp2mAqCnPTxSxdkixt/JEuV7FOIYV3+rZCvTg34txf1tWabHT8AtcYWHz0LfaeNs8kgI3AJsPyaw44MmzvGLtyI6jqgI/MYd4r1g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(346002)(366004)(136003)(396003)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(110136005)(66476007)(478600001)(316002)(4326008)(86362001)(66556008)(6486002)(31696002)(66946007)(6666004)(38100700002)(31686004)(26005)(2616005)(6512007)(53546011)(6506007)(83380400001)(44832011)(8676002)(5660300002)(2906002)(36756003)(4744005)(41300700001)(8936002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkVWajdPWTM5QXQ5c01XZE82WThPZ1NEVEdUZTlxblJKWXlvWGl5U2VqRzc3?= =?utf-8?B?MEdNMGpobGlVeSs2bDdWT3JWckpJRDdsZWlmL0VqemY4U2J0TExzNnF1NlU1?= =?utf-8?B?OGdsdTdHZmFCTG93ME05eHc2L2p1UDBvcHB5Y2ZvbXNBd0VuMXR6NHFLSDZN?= =?utf-8?B?LzhsYUxHNEJWNU5FWmRScEpMUXNodklBYk1sY3JVSjJLK0ZVVDcwYk9pRmFs?= =?utf-8?B?dnpBdUtDc1hNT0xkbUNEQ2FZM3ZHNUVpbE5VMU5YNlVFbTJMMG45T1VQVEtC?= =?utf-8?B?cTNYbExoVnpTTU4zRDNFa3loV0puNUdLcndFYVpTSllkc1JxOXBTR2E1cDhW?= =?utf-8?B?Z1ovYkovUTdqMTQ1Q21SaXRCNlVzdVB3WkJ6VDZ4aXQ2QnBlZm9KTnR0TmNZ?= =?utf-8?B?c2hrNEg5TldJMDQ1d1BveDRUNG9VcFo1TzBGOWZnaVVwQ2VrTGJLLy8zWmN6?= =?utf-8?B?ZUVtS1EzZlJhdkUreHdua01wRkRnZnRVNGFZcFNWQjhXaFdTVmErb0JIakR2?= =?utf-8?B?TFJ3bzRVN3h0MU1aRGd0U0JuM2daWVZheHM5cENuUzBkbnhXaE00aCtSUncy?= =?utf-8?B?UW5HdXByUGlVaVFtangwVmtBYXhqZ1hUZWJHU2VWYzEvbEU4WGFaS240QnY0?= =?utf-8?B?b1JTTTJpZUc0Zy9hMUpzZkZWbGNlZS8yKzRpVGZVRS9BcXZUMkhHcnlrN004?= =?utf-8?B?VTJLUlJOZVRST1IrN1g4TTM1bis1TEc1QlBVVXBHZEZRajVjd0JkZ1d3d09C?= =?utf-8?B?WFZVcm5FeWI1eW5pbnVpeEsyZDNYSFluaUhXODVlbmE3aXpwNDc5QUJvd01N?= =?utf-8?B?a0kySHJGY3NhNHhraG5tcFJ1aGFQREtBR3hsOVBtTlZpUDVjRnlyaE5iY3ZZ?= =?utf-8?B?UmFvT0x5ZkpBYndlMWhsMkdlMVdoWkVDcE4yTWNKZFNYM2QwaDUzNnh3VERT?= =?utf-8?B?N3RtWWgzWi9iNzlPZEZXa2RxRURPaWw3VHRTOG9nY2JpYW5YdU5sVXpoaGFw?= =?utf-8?B?MHhMci96WnFEdDVNemVDTXJpYUZFVmRDNU44U2I2dHM2Q1JvZTdDNXZ0OUNO?= =?utf-8?B?S1BvS09MRWdqRE05bm1xVnpaMVQyTmh4S005TitpRmJTYk5RWmhQWXZyVVVk?= =?utf-8?B?b0NrZWxQRHpVNCtrL3oxT2JSdE5Rbkc1UFNTdWFRTlVUK1JIanpENDA5a29D?= =?utf-8?B?UWRGUUYyWmJ2Wk1aSms1bmxHTm1oR0hid2FUZloxL0JxSDRvZjJ0a0FlV001?= =?utf-8?B?VVRpOE12TU1pc0o1ZzhtcUdGTzQ2ZC9pbXRpajBYR0tvSTdaSkVjMk1jdWxG?= =?utf-8?B?MURxNXk1c0Y2d3phUWFsMk5ibkRiTFA3RUxndW9ZblJ4QkRPdUsySkJLY0do?= =?utf-8?B?NU5Zd3RVMjhOZjkxblJ1Zm8vVHFjUU96QS81WWsyNklVNUZ0MldQTEZlOXFZ?= =?utf-8?B?TU9uanpIdFcwSHp2STFESC9MeFpvUkhoa0h1bk91YkZpTjRqeklMYTcwRmh6?= =?utf-8?B?SmZqWC9VOTg1VzRQY2RjSTU3L0R6N2IvUjR0ZXJhTzRWckxDR3NOT1QxU1B3?= =?utf-8?B?YVQyclhUZ0p0SHZzbTE3ckVOaDMyVzRySXRrbzQwRW80ejc5T2d6T1cvRWlX?= =?utf-8?B?NERtVk1YSHBUaHlzMnd6NllKb3lwNkVnWEFHeDBhOUpXVGtzMTBVUTNML0J3?= =?utf-8?B?a3A0dEVyNHFxREdXeUtvYnMzSnp4Y2NlMzlteWlwTHVKYXQwZFdoNWdWck9Y?= =?utf-8?B?bWhQci90QVFKK2JIQThZR2dFWGdxUVJaWHlHSStoeEdHcEFDRDBNTW1JTHQ2?= =?utf-8?B?ZnhWcnhYVS9nR1BXOHZGdjNlN2JZM2dJY2wxcmxhUnhoc0pjdDFqUk9KZTlW?= =?utf-8?B?L09xamtRYlVzSFhrVEFOUVcxN29MQ1dQallnZzRzSnlnaTBaUHFZVEt4aCtB?= =?utf-8?B?dHNJU2wrVlIyb1ErY0ZMZGg5ZmF3M0VvQisvNFlZa3RXN0lEK3RyQU95Mzl2?= =?utf-8?B?WEVuU0tnM3J1VXJRNGJWTFptcGRvdVN4RS9tUVBmTkZGcDJLSi8xd1N0VWc3?= =?utf-8?B?Rk0yRllxTXZJeU9HTEtpdnczUDBRTUluWndGTWZZREsybzBKRVJaL2ZqSjdT?= =?utf-8?Q?RqWo=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6fb9a7b-ef39-4405-5e66-08dc1074addc X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 18:07:30.1889 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8U6jOsrkHbFXBP0HTz2tDEO0Ocwxtl60hswFIfPsgPXkIr1IjgzUR0yAp1R7QUmJ X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6278 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/28/2023 12:14 PM, Jie Hai wrote: > From: Chengwen Feng > > In the HIP08 platform, the PF driver will notify VF driver to update > the PVID state [1], and VF will declare support QinQ insert when PVID > is disabled. > > In the later platform (e.g. HIP09), the hardware has been improved, > so the PF driver will NOT notify VF driver to update the PVID state. > > However, the later platform still have constraint: PVID and QinQ insert > cannot be enabled at the same time, otherwise, the hardware discards > packets and reports an error interrupt. > > Plus, as far as we known, VF driver's users don't use the QinQ insert. > > Therefore, we declare that the VF driver don't support QinQ insert. > > [1] commit b4e4d7ac9f09 ("net/hns3: support setting VF PVID by PF driver") > > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > Signed-off-by: Jie Hai > Applied to dpdk-next-net/main, thanks.