From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0041.outbound.protection.outlook.com [104.47.36.41]) by dpdk.org (Postfix) with ESMTP id 4E0FC2BAE for ; Fri, 7 Apr 2017 10:10:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=V5awkeEAsVm1YNeRCtQ/SFo/WBZjj09Vxmo9P5TXpYE=; b=VsBYAGXc9Gpyx/MPmgN1zaNAKlpATXKFN7Ac+uORmvL6b8MJGvCA7uNy0zS74zNDqIWt5QwFf5YHS9Y+eEkH7Mg5p0JU9VPhLsMWlISCg3QJYJ5J/93rjJ49AlYMw21VkweXUt2s43zYdJFxxqxrE1PdP5WFt//YxTC82ZfSc+0= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=caviumnetworks.com; Received: from [10.0.0.75] (31.172.191.173) by SN2PR0701MB1038.namprd07.prod.outlook.com (10.160.58.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Fri, 7 Apr 2017 08:10:01 +0000 To: Thomas Monjalon References: <1490288768-8114-1-git-send-email-Andriy.Berestovskyy@cavium.com> <1490356325-15434-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com> <1692122.NGhiyjpKUa@xps13> Cc: dev@dpdk.org From: Andriy Berestovskyy Message-ID: <4c030b76-ae4f-2cff-6cc1-21870ee506fa@caviumnetworks.com> Date: Fri, 7 Apr 2017 10:09:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1692122.NGhiyjpKUa@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [31.172.191.173] X-ClientProxiedBy: HE1PR02CA0115.eurprd02.prod.outlook.com (10.170.249.44) To SN2PR0701MB1038.namprd07.prod.outlook.com (10.160.58.145) X-MS-Office365-Filtering-Correlation-Id: 33745e71-b1ee-4de4-db29-08d47d8d7dc8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:SN2PR0701MB1038; X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB1038; 3:VDl/DiWDmrcy7sz8SkfVON/BLsGarOW1yMu61lu5Nhw2SKkwPkZRhdo/mUuZ/Iq8GtE19cHHPa1TSlFxyokx8LnprLQvs3Te1FB5Shp+k3ShksBlyukg0wzVOcF1epN+gwFDPFWnxRUOhAe4IzYvAJbpc7gv5CkmELDFAHM8f0wcs5DZHdF0Gdz3k+0SopyCFu5kDiLY8npbvGVjp0l2mwSVnV84xjAmB6URnkZWaEs1oHNQaG4bM3NY1hOXASB4aHbXIK12lA4/ymRsgj+hEPVIDzXsG1TYKbPb7lNS4htmroW890f62KwBuBdkckTmgOeNjWv4i34d2nGdGgZ2GQ==; 25:hTF3tTY7S+WVlmyCFtQcyJgIeI4kLAF7EZsbQlR8GjhpnCF4eY+Y7oChGF6GqDbXAebqintvhffCPHRVBhCcpbu0EZNGvnGuCmqO/3dOTY4HZyxhvM9Z90O4nn2Vg1gya++M4qPqCgIHQM9olXvZK57F2vTaZnlHqdSlnPl+z0QYFHv5FsqFEu/i1s+g0mYps2NImwb6IVu0u/PL7vykuAKVM4ypwuQsGcMOARHOknw32WOGQ76expkiYmVu3ro41+LAyGwX3XUIGgqDZnMXcnUUbZ7VpzylfLkiIN5cak+cngqh+T32dq/otk4oPDuI/U3LWgiptpUQ6GS6UTc7Fgy8pN51QRgWHBINTafqlZclISa2g5JTDG20gOd579nWfhhtviHCS3OzVF6VRtrNqJR05In70b4yFObs093qQm1MXxbauHiJZVdlLMhHM1TNNFQbygpHTs83Og7uZOP0WA== X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB1038; 31:CeE/XqH/+sgsa9ZlvwuUexvD7TsFf/k1c/MDF20PDYJMC+LtclZNaln1lIAm/K5/8oyp4XyU+J1fhcUPIHN13QGecMzeR4QU0JmKifOgfJV8/6kgHLracLKM1Pp2NQ10Dw71MTr/vCEbzR88TqdKadTh0TYrj9lojBJHlT5DMvFJEMuPGY/YySHU5eZmoyNJmHUi7OKoNp1FaTo9Bmza9jpYwiURLqzgUCRpViQw0O/AYdNADKlL5Dgq1fI2MTU2SdCVprPz+v1uMFFI/5dsXstfcOYPeBjoIogkCCOMEwM=; 20:SaSNmDQwkIshJ9Nlfn3Iss1ggA2Lyg0rrcn9hmIiz3R4DNCXJNxzt7E/fkDabURJUf3NFxYva+ia9cWOC7L5eNuHUOZ8tv6UKirxOAXFCHtMW1oX8Gp87+w2bsaE+Ytu10aK0oCtAToXAQPSIpnKqp3s9wUXlX3DCnwZgP/WYdJp77zO7Z0kTHM+bZ7J9/2KoVdFaNsZtDyo6bEVhNO2GdV1zPyicZ3RFan0mSfx2Pk/bZbTLdSFf+ZFfXDg75kSEvpcYpn5Im/1byKi1Dn4xWfd3UQA9BlK5d4gwBtz041enb27fJFmqZwWDJBry67dNqP4j2uQ0c/gxJG6rmGLl+4AyytqRO+teR9Bk5KD1Z1cxdcdSDsqBymsarpz2Ppo9/dLHaABTrpWHfGLaT+Z44VNnh2jUaFI3A3hXBl+HGuMn4txGdPx4FvRMKhOzK6F3c5IG8DqqH+U5EJlcwrKdcTZzFNZCy+Y6yMENJBzD5VBXNfQim+pam7RUKRqGhfYcrmbBrSyE37ly0BoaWKEwWyvrHqa0DqBHRi4PGKn0IvDufEMJTXn9FbFkLJv8CPz33LRSzq+990hmhx/+xpPPlAdB8lXcXv+ILwWEfHDAas= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(6072148); SRVR:SN2PR0701MB1038; BCL:0; PCL:0; RULEID:; SRVR:SN2PR0701MB1038; X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB1038; 4:OfU5IAXgZ+4DUP3X6OoZ37lXNGSb7MIvNgk3Lpyht/8Z1lBZ//hGWavtnMUfpcLqs+FVxTvUPXBJp/qMfVPn0SppMVYrYt82RjXkGeVWCtWL0kWkxMLDiRwCftzQg5CDk7o3+o5xyX1U+dBjiQ+N8jphANf5hY9NGf5HEuo0q1E7+INt2Jo+cHsyCzmW7esYI+aGL+5wP4JhkBzb1mBP3AuEKy5zBYcaqocXuMrZT+trk59P9+EQosK8mj+wV4Mb6MgXuRTR0o/Af1L1Y/DLTQ/Av5WEwaKMzTbggdgUQQZ2Z7RYEY1aQ/F8Y8J2PW/Bk2zhJEpXwl9EAym8L9SKP3x9+lc2BBtLjt8DxlFYmaIj+bc0WdYvxMmVUHeQw4C1gKbwsiIoIivcFysYXmHhrcvr2e/72ieqMyXcL9wyQRZUsb6jVrZY93exNHqiq6A+l4asu3DUUGvs/TVDRsNG+SmW/JwWysT/mG6T6ziiXWZxpdKBWfZ7djE9GE3oFKF2EiozsdmwbCD9x/XFWfGn4QaOgwUgRcq12xy5xeovD1fm+MjP8neO+j2tWTZi/SRCJJIbvFj/tnKTezoa3ccCz+eVBF3jGdabOdFb1vT7neoTXspHPE1Bc2VU1ZSwgpLYiLoetAhhY8X1yc5ACmsnqEKPcTkLOLWc01IRU0wsE9LT5BCrqSlKyg5uNW0g9EEF X-Forefront-PRVS: 0270ED2845 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6049001)(6009001)(39410400002)(39400400002)(39450400003)(39840400002)(52314003)(24454002)(64126003)(76176999)(54356999)(5660300001)(50986999)(65826007)(31686004)(66066001)(65806001)(305945005)(50466002)(36756003)(2950100002)(8676002)(42882006)(6666003)(6916009)(47776003)(42186005)(81166006)(33646002)(3846002)(6116002)(53936002)(4326008)(31696002)(6246003)(90366009)(189998001)(77096006)(6486002)(2906002)(38730400002)(23746002)(230700001)(110136004)(25786009)(53546009); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR0701MB1038; H:[10.0.0.75]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; SN2PR0701MB1038; 23:s9Ryr7DyxqmfWAbShEHjOf7rqjkqs+EEe1G?= =?Windows-1252?Q?MFzCdiLQuV0+F2DJfLjQMYAkXW3SujzRLmFCJxNB0X7Mfw2BVsVnzLQq?= =?Windows-1252?Q?zyZ2AR5o20dT6OyKgBXIeB2IiJR/IFH/VTbRu+rVJdIU4tIU3dQo86V7?= =?Windows-1252?Q?Pud+mGM36RzN5EBqZgttMq4Ga8LVIT5Dxnq2WxNXJu3rmy7wKIZsFbTQ?= =?Windows-1252?Q?KozU/ZaHRx49jaGO+c1ALIm62J3WEM0Rt/A9QfyYgN3LToc+jX05dIkQ?= =?Windows-1252?Q?at5tvJdSszYQ71M5SXnGOhTHZdxl+w4WHXjLwSOG1wWif+djn4lsw8KP?= =?Windows-1252?Q?NUIhG/MbzqLXVhlERM24rEe3F5G92dTRPNXOcvI+B9bj1mLOVW7ABC12?= =?Windows-1252?Q?Dtd4wTF3NIBr6sLK3yfqMk7AWf+1rMBgiri2aDB09ZroSN9WzX5FxO2B?= =?Windows-1252?Q?jfZgSqHEHDw8/7DhkT6ttM5tOxgkTlFzQ/eP6hwJoIskt4/EmN/gOTCU?= =?Windows-1252?Q?8PM29bjDRBHsAVTF+l8dBDCGcZDAGX3ySV2jO+k6iEyMPvnHV4Ewzdmy?= =?Windows-1252?Q?mNxpTNF9AzWf6pI/uLHDPU118Rg/fsAVThFd2yRyQ6rJLtEO22E0c98G?= =?Windows-1252?Q?9Pdg08FkX8Cri8tdrj2hfH9RqQdZlaHON6GCIfPGFoRRRvLkPeuOAQwK?= =?Windows-1252?Q?OY2qToxms17oxSP2MLW1luG70AH1aPeRbhLMdZ2W4qj8bSn0OXk+zdji?= =?Windows-1252?Q?VvRJFltzoflAJk2sf1SzxYkeYsGpDP+Orzk8s1KNUhz3HHig4cVNO+a/?= =?Windows-1252?Q?T3u76RvlwbdXjol2jXyOSduV9YRQnvobLKNaPDeNqMnpcGR2jVjzr6gf?= =?Windows-1252?Q?QTagYbc2+zxITFTz76NMH0GiXcSsqIWQ/E1pgpQVbUkxQ1fOMKCY8z/5?= =?Windows-1252?Q?5apeqfTkzLNYsQV/NVsgSRa9i3NcHeifZRfdRkkIDCvw+3XBsr/xfDMg?= =?Windows-1252?Q?H1gPs6Ag45vy2AzKxRrRkJoyzwY3ybIdxuuv7B8RRGPX6xdLy/dS1+jX?= =?Windows-1252?Q?GzVpxyb/PNFWybVdsQNZlNAqt4XuEx3Bm/j8YKvgqNZ4RcL3DiVyFpjt?= =?Windows-1252?Q?V+VYO7p0Mb573VIv1iDAQnPBBUMWr0UDIfT4DG272BNjjD3c3vYiyPn4?= =?Windows-1252?Q?DouDkQNrgkdhJPoCKsN+XPFqLilMm0i8jX+COXAIfrUXoDljnfxikIur?= =?Windows-1252?Q?33OUZhNuwnG0Ni/4Nsg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB1038; 6:jIqHlPE857zsjWqLdY789/Dgv1Wl5Lm+vztztzxgLhD/DgSuKze+rGrdDmProOPcmVH+X2+16w144s5JskQ2iFLuO6jVi/4UrGz6YnWGTXOfxm/iYSbTCnaVtlVyenDctAodDxoGWv9nMgIgwYtEDbdNtZDkpnAiCNT1fOOUJ2Of+lkywqBlMKF7qUR9No41HbeN3mrPokU3Wox/4WxNJqHi7iRu691yYHW9ff5HSUkOzDw86nrRdK/FrdpOyaUi8UdcemtMW/grcYEg9qawxKtx527a/pKY6EFQ9dDi4XWDc2+haeJPtYBB1CqIBUAxpqzsNUuhhOfLGpiBqZLVrxC/4oKNFEQH4d6Akscp8+auy29vTnRXCETHzI3tHXqp3orTsxKLDQcvwkmc2RN0Jw==; 5:8R+X1kYngjOaizdBE4fCfzDo6e3e0+ChMQs3Rg38iGSD+EN2RDIjAtBwF63Ys4HxRHoHx/woeRwHXOVG4NH/wwtP3j+Dp+rSwGS2XAK4j9K8RYOgfth0CcNRAZ84tq/fAoegsQkoAL9sJqOEJIEPoQ==; 24:10xFRgUorYBF7BRqwBIfgvlJhUAgSXZiaZNn5BMn6P21U2HuJRXfRVkoM1W3A31O/JOj1jyuE4ZfE1xmxT9GBXyzzwOMKHcXYEjTYhEPLrA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB1038; 7:6hVqj17C52gCAs9BwZ3G7bQGiEIfQZkob5h3BoQ1ntrL+MYZqfSUQFVWE7g0q7gOHiVy03l+bScDc/82+VegB2m4Yw3H2mZJ49xH83cSJ27uKl+tNn9HS5RqAUYBqmaZL1kFCuAVeng4KSSlxjzHPWIrk14TNQZX5JmltCAX5WGR4nnilvWIktZKoeH4yErmKh3qVASs+j3mkavf5YDSXtXsgsKgJhXiv6y0YhJNBn3/HDE7eHl02wEIFsF1VlfBj7KkJ+ydaMoKBQMPL/YdihQpggaiHXOaipX2za3UYFQqEH0um+mT9aj/NBOJFTl18GRyo73YJCMCesjDwt4Zqw== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2017 08:10:01.2762 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR0701MB1038 Subject: Re: [dpdk-dev] [PATCH v2] ether: use a default for max Rx frame size in configure() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 08:10:03 -0000 Hi Thomas, On 06.04.2017 22:48, Thomas Monjalon wrote: > Anyway, why not fixing it in the reverse way: returning error for > out of range of non-jumbo frames? I guess we need to fix most of the examples then, since most of them just pass 0 for normal frames. And there is no default for jumbo frames, so an app must first get this info from the NIC... > I am not sure setting a default value in the back of the caller is really > a good behaviour. From app perspective, any working default is better that a non-working app, which you have to fix and recompile on each PMD/platform. What if we use 0 for a default value both for normal and jumbo frames (i.e. ETHER_MAX_LEN and dev_info.max_rx_pktlen) and an error if user passed a non-zero max_rx_pkt_len? It will make it consistent, we will not need to fix the existing apps and we will have a default both for normal and jumbo frames. Win-win? ;) Andriy