From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id AC6722BBB for ; Fri, 31 Mar 2017 16:37:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490971040; x=1522507040; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=CgTSz65SjvknQA2tsIISLTRjLZ94JPPYAZgxrDBFC7U=; b=mtL88643IXXtFdotOJ9RwmoJKPAxqSCBHGfEZ3KGQ8XFF1Y1zmyMrKbC M2SR1jGDrAeidX5H3BbytGq6yKgVTQ==; Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2017 07:37:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,252,1486454400"; d="scan'208";a="840426959" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by FMSMGA003.fm.intel.com with ESMTP; 31 Mar 2017 07:37:16 -0700 To: Bruce Richardson , olivier.matz@6wind.com References: <20170328203606.27457-1-bruce.richardson@intel.com> <20170329130941.31190-1-bruce.richardson@intel.com> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: <4c0bd0b8-d221-1a6b-85eb-cb1777861e3b@intel.com> Date: Fri, 31 Mar 2017 15:37:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170329130941.31190-1-bruce.richardson@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 00/14] refactor and cleanup of rte_ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 14:37:21 -0000 On 3/29/2017 2:09 PM, Bruce Richardson wrote: > This patchset make a set of, sometimes non-backward compatible, cleanup > changes to the rte_ring code in order to improve it. The resulting code is > shorter, since the existing functions are restructured to reduce code > duplication, as well as being more consistent in behaviour. The specific > changes made are explained in each patch which makes that change. > > Changes in V5, p8 & p9 only: > * Fixed errors in performance-thread sample app due to missed updates to > enqueue/dequeue calls. > * Added in missing doxygen comments for new API parameters > > Changes in V4: > * Fixed errors in the crypto PMDs due to missed updates to their > enqueue/dequeue calls (p8 & p9). > * Updated quota_watermarks documentation to match changed code (p10) > > Changes in V3: > * removed anonymous union for sp_enqueue and sc_dequeue variables (p2) > * fixed parameter to dequeue function which was mistakenly named is_mp > instead of is_sc (as described in the comments) (p12) > * skipped unneeded check in tail pointer update fn for sp/sc operation (p13) > > Changes in V2: > * Eliminated extra cacheline padding where cachelines are 128B > * Renamed rte_ring_ht_ptr struct to rte_ring_headtail > * Removed missed references to ring watermarks in test code and docs > > This patchset is largely the same as that posted previously on-list as > an RFC: > http://dpdk.org/ml/archives/dev/2017-February/thread.html#56982 > > Changes in V1 from RFC: > * Included release notes updates as changes are made in each patch > * Fixed some missed comment updates when changing the code > * Separated some initial fixup patches from this set to send separately > * Dropped the final two patches for an rte_event_ring, as not relevant > for this set. That can be done as a separate set later. > * The macros for copying the pointers have an extra parameter added, > indicating the start of the ring buffer itself. This allows more > flexibility for reusing them in other ring implementations. > > Bruce Richardson (14): > ring: remove split cacheline build setting > ring: create common structure for prod and cons metadata > ring: eliminate duplication of size and mask fields > ring: remove debug setting > ring: remove the yield when waiting for tail update > ring: remove watermark support > ring: make bulk and burst fn return vals consistent > ring: allow enqueue fns to return free space value > ring: allow dequeue fns to return remaining entry count > examples/quota_watermark: use ring space for watermarks > ring: reduce scope of local variables > ring: separate out head index manipulation for enq/deq > ring: create common function for updating tail idx > ring: make ring struct and enq/deq macros type agnostic Hi Bruce, After latest master tree integrated into next-net, icc build throws following error, which I assume related to this patchset, FYI: In file included from .../lib/librte_ring/rte_ring.c(90): .../lib/librte_ring/rte_ring.h(162): error #1366: a reduction in alignment without the "packed" attribute is ignored } __rte_cache_aligned; ^