From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C34BE41C2D; Tue, 7 Feb 2023 11:11:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B297410DF; Tue, 7 Feb 2023 11:11:14 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 122D340042; Tue, 7 Feb 2023 11:11:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675764673; x=1707300673; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=BNPJEQgWK8LJTfqRrDBL2WlcHtbNB1YVjVDgU4yXMlI=; b=Z1Vu6zCz68tJlbErItk/5kjjur+quxcDfN86yefh8AsiLiAVeqCn/+yE EkxbYEj02vnFQGe90tUOJ7M2qaj1woKuIfArO4H07GPiAoDKvW6P010XZ ydoATsg/s69KHJqxeEQgB6h64suqewn7tfhpckvIcJvMW87kT+QOrbBwu 6oZ+BKAKl4R4sRTTe2cenTqn4YKk1H9AN/zff8K/Dd1mTRlYZ0Fw+gzcI f6ORsp0h9g6lsTyD5rthtHsrW2D1/Rg2/axX4BHD2Cq++eQm5aSjdhANu hoUb00Ncsqj0mKpEXxj9ky4UXlxV04YuFbCKmu3NTWM4XCEdo2fjocmmu g==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="330758724" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="330758724" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 02:10:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="775505342" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="775505342" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 07 Feb 2023 02:10:53 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 7 Feb 2023 02:10:53 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 7 Feb 2023 02:10:52 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 7 Feb 2023 02:10:52 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 7 Feb 2023 02:10:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OAYPwBr9dqp9exFeLkpHGjHebn8o24njMT8dvvwkZiVaAQf5A5pp0yvKje4i378tzv30cCf5+3NZLYEy2FEdNbSL+fxtZp60aUwzUiTtFJ7TcG8hT/RlHgJXclK6ReeFqGNqGdSlVPp4SFYNajcDj/ehNfWPDsK6DpEIuuBwQ6M+DDIBl52SIFfWG7uBKnNWzMSIfH/iqDKklcw1o+4q1fq/vPmtBg7iF0ZEJXJPYraeJzCa0cqEPdvC+NAys347do1f7gtlcGSBhlof8Pcltd3hvqMq/GgGJe+urt2uiLQiI9K1CnmkJ5KVCit6L6sA28F10sCiW6skHesawvKbfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BNPJEQgWK8LJTfqRrDBL2WlcHtbNB1YVjVDgU4yXMlI=; b=DleLtb3s2mMCqZhgur6y1uZ2RjKOBPfP3V+kKDB0MtYDwkIYdx02VtwrN0nUS/Et8g/pL4J+tZoECogMokbpGtUHPFBr1dirWCFVoirhT2ALh5e69xQgi0f1+lje1EXTwYjriovR9NQXDJPuzCTyAPc/nidP5Bexpjeomw+RL1odKfbjayXTncyYA7qGpsuugwAu508IDVmcJK9IB0BhIkyXayng+SZAMSmHkJpYb/2tqJe8AHsYk/wKT3iwz+N/F1JveQrL+RS89JPu31VJ/Pi9D7v+h3m54GTNYwEwKIaNeMS1TCMzcoHfEtWYFYaNqbE0OGJ6aA5UaHxgROTrVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by SJ1PR11MB6249.namprd11.prod.outlook.com (2603:10b6:a03:45a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Tue, 7 Feb 2023 10:10:48 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::7b62:475f:32a5:d4]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::7b62:475f:32a5:d4%3]) with mapi id 15.20.6064.036; Tue, 7 Feb 2023 10:10:48 +0000 Message-ID: <4c995d84-82f0-6c4c-b189-14da06f013ea@intel.com> Date: Tue, 7 Feb 2023 15:40:35 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] app/testpmd: fix forwarding stats for Tx dropped Content-Language: en-US To: Ferruh Yigit , Yuying Zhang , David Marchand , "Ferruh Yigit" , Maxime Coquelin CC: , , Joshua Washington References: <20230131115603.640254-1-ferruh.yigit@amd.com> From: "Singh, Aman Deep" In-Reply-To: <20230131115603.640254-1-ferruh.yigit@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PR01CA0094.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:27::9) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB0062:EE_|SJ1PR11MB6249:EE_ X-MS-Office365-Filtering-Correlation-Id: 841ba3b6-d17d-4751-6f16-08db08f39569 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4H3wxQByl+rJlfi9nq/6Y76tj7/fVZlcypIfKDSmBK7iPtCqTw+wFK7M2Xxki1Wvp8IVEq95G6h/oaHjAXQbzAN+7okr9aW3pOZ+FUrdugVu/lCV5H0+X7U6OlYKn7YKaA99F3Ut3YDmMkSlTiNiSqC4ZbwU/mqQBbOeUP4mm/wZD+Tv7q0SYhSwSt6g9TbRQ9BcgvwJUw2f8B/OcTYVT3Z9rTMIu8U/m/4kTxJ6E57QLqe8Ige4dffaa/ZG2R3br0BmmALZM17OVdi3cb28USQ6bw+Ug5Lv7zBOEMyxPKI6Dp46z6FcUj3nx/siVKX1D/8UZ+f0OzWXrhc0e4Vq+uX2eSZ5NHQz6nl6frcttB/mb9AoSmkh3pS8+DGA7cAuYnSWHK0idGMxrIrgvXhIUyrmbY3MZwT/mN84ObIoUaX1u4gfW/MKU7mWlXzt6p+CAd+8Jxm7VrdUzc08zX1/OIwwt8Klf6nZjmzf+p/dK+WIWyDGCFkDjyRzpxQK8JVSkg6Hg3wgYGbFMID3mFbnpArRdLhfo9ihLCkqZWSz2/wPA+VYuTcVlWVXCWbkMRhSYX41tan10JeBEGgmY5iowkh6vKua/JjFbGj6NT/AGIwlhqqfVjA3pcC0G3Nm4+WQZceDJ6AYqKxG22XK6IiglapJ3gaujggf2g+mO6+UQtlrTzwE5P3Uy2A6kTdh+yzXkqKOC2KVvhausiRxtelbcbL+VbDwthB7X6+SQcQXODtlqqJZV/rQaFc0WBWOZpqimAXMVWF/f08zXC+hliTGGQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(366004)(39860400002)(136003)(396003)(346002)(451199018)(31686004)(2616005)(186003)(478600001)(6486002)(966005)(36756003)(86362001)(31696002)(83380400001)(38100700002)(2906002)(8936002)(316002)(41300700001)(4744005)(110136005)(53546011)(6506007)(6512007)(26005)(66556008)(6666004)(5660300002)(66476007)(82960400001)(8676002)(4326008)(66946007)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1JuVDJ6bElUWTgyZk9JMzAxRzhac004eFZabEh3aHhvcFVYUWV3dGdXVlJE?= =?utf-8?B?ZG9URFVUTFREOU1JZ0N3SURKOUNIRENTdFJvOFNjeWhhZ0p3Unh6eWtsUzNo?= =?utf-8?B?bXVNWDg1VC9xVVRyZkNEdFl3NDg5RzNkdGdha01PUUY5SEU4VE1uSGk4TFNK?= =?utf-8?B?NXlZU0RWQ3QwTWJncWovUHkrS3NoSFo0Y3lVRXZyZldzdDhzdlRsbUlRbG1W?= =?utf-8?B?d01VVHROQXI4MFY5djlGc1lacXQ5S1JKNW5ENmZUOE1JVGFUVGwvbGdOZVhU?= =?utf-8?B?Wm9SSXpudnZZdmtnTm9ucGcwRXp1aWhmUW1SemFJSkZ4SFYwc2dMdUs3Wllx?= =?utf-8?B?S01XSU9vU3hKOFZaRVlHa2x0TXA3SEdUaVE2UStYUDdQYnVOVlRibkJxVmdK?= =?utf-8?B?d1VBWXdrT1EzNVdSZFF3M3lUbm5vb2ZnVTlXK1E0UnJqZHRxdjY3MjYzb3Ax?= =?utf-8?B?cFY3V25RVFJSQVlNd1g2WHF3TG5CWXhvWVRJQjRySmkzMXlVMkZVSjUwaXhn?= =?utf-8?B?OFgxdndzNVJ3OE1QRG8vbjI5UitoT1dRSllINi9XZHhPem1zSmFZWm84L0p1?= =?utf-8?B?V1ROZXo5MlhxQWFDRHFzZkwrd3hTRWRPbHpLMXUxSWMzNzV0TkdlK1hkQmc5?= =?utf-8?B?b1Q3YWxkai91S3FzNjV0M0pNQm5mVGkzSjByU2tOYm9YUUVENm9BVGc0UkIv?= =?utf-8?B?a1h0R092Nm1VejlyTmtXTnNYSUIwQUc4MzBONEdTdHF1eVhQUDBwK2RsVnh0?= =?utf-8?B?YzYzNnlBZXJyazlBRU5uS1hyRUl4M3lUWmxQWkFPb2wrd0wydkJ4NFYyYWtW?= =?utf-8?B?aHNtNnAyc2FJNHR2bFlWSGk2RWpkUk1RbmJyUXBBWUpYYkpXVWtpSUdUK0hn?= =?utf-8?B?aHROU1Jlc3oycTRvNVRwbXRCVkNFd1VXVldzYTlmRC8yVU1oRlBwOWdxWVRh?= =?utf-8?B?UDdiRFdycWMraWk1RFRFeUZnMkNkekZlZi9hQlFobXdsYitSR09OQnRianZJ?= =?utf-8?B?bXV3MVV1eGZoRWFneWx5SzdlaUlLbzF3dUZOS0pDWDB5RWx3R1JWK2xkYU82?= =?utf-8?B?S0dqMmp5L2VrNk1wQkx0NHZ3ZnZYVEhCNkV3cGFXU2I3amNheExsdGI4ei8r?= =?utf-8?B?bEZCT0JTK2UxMGdTWlBWN0J4R2dISWxqbXdkcG1qOXVQWkNPZzNFclBYU0h0?= =?utf-8?B?UHMzOGRXSGEzdEVIRXkxSzBqVnVQUlZybFpaTUVkelBjTU5sUFpqankxQ1Fj?= =?utf-8?B?d3hmYTQ3K2l3cWhwRTl2NDF3TGU3anorWUtHN2llWW5PRU1JSm9xUlQvR1Ba?= =?utf-8?B?RXAyYkt6VDBjNHpxcVdLNmVLb1FtZTFIa0w5MVZsckZHRWhjamg2TWhKUXg5?= =?utf-8?B?d3cxTUx6NGF6RExNV1hGZnRqUFpaOVVvbll0TkRGQ2lPbXZtLzFqM2Y5VGN0?= =?utf-8?B?Nkl0U3hiQTJaR3FSVGV4YWhZaXI2amx5SS9EVVQ1ejdGUzNvdDFrNEhDODJL?= =?utf-8?B?Uy82M1JKN3Z4NXUzNkNuQVpHUjUvQk1sRHYyK3JYY2Y3d1JrU1NFV1d5MGFw?= =?utf-8?B?a2FsTjVlb3Z2UUxLckcvaU9UQXhUa2dTVDM0bkhCcHBIQStNVTg0TGFaUHNB?= =?utf-8?B?L2RmVnYrRkZWaXJUdDNjZ3R6QXBVMW5GRjJncW04dTh4a2RXczVmRXlkdEU5?= =?utf-8?B?aGpsMGx5a3dNQWo3c0xkUlJVQ1VyWWs0aXNsaWE1YmY2M0RSRk9STkpFWEdt?= =?utf-8?B?ZVFoc2FqVCt0azB3aVJ1NlJnMkJSallqcWhTVG43RkNGUUdHemZpcmR1Mm1s?= =?utf-8?B?TThocEo4dGMzc2RhQzlWY2x6TTd2YnJEbVE2RUtMOGlzZ3RIWWRhcjhXWkt3?= =?utf-8?B?OEdCekpXRmJXRjVGVnYxWUNUdDNZUkxQaDZsWkhTNm1BQ3o0ejYwU0E2SUcr?= =?utf-8?B?S2ZIYWhuRThYZ2paWmRTbzZlRTB6ZGY4bDU0NXgveUlFdnVxWnlSSWFhb3Vh?= =?utf-8?B?QWZMSWdhVno5ODFGalR2UEZxUUF0anZNbCtsN0hVN053TkJTNW5YZTB5ck1W?= =?utf-8?B?MEtGZy9SR2hab1FwSU1BNDg3czNReXd6MVlCRVhHeXJNOGdrZWtVTEU3OGlG?= =?utf-8?B?amxwSzR1bU9XcnJEVWZVQnBSWXBnekp0TjN0azA0dVVHd0VtK2MxZ0lFcytI?= =?utf-8?B?NGc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 841ba3b6-d17d-4751-6f16-08db08f39569 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 10:10:48.3596 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7/lMBpFssNorf4oo8louStzu9j/4GEoMchvN/YTNjRwezgdrD8YJdW77z3yhjersbQluMW17S/2mAHjZK/2HIH7HgDMQamidrZhfNiQONsA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6249 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/31/2023 5:26 PM, Ferruh Yigit wrote: > There is an inconsistency at displaying Tx dropped value for per port > forwarding stats and accumulated forwarding stats. > > While displaying per port TX-dropped value, it only takes > 'ports_stats[pt_id].tx_dropped' into account, > but for accumulated TX-dropped results it takes both > 'ports_stats[pt_id].tx_dropped' & 'stats.oerrors' into account. > > To fix, make both per port and accumulated stats display 'tx_dropped' > and 'stats.oerrors' (ports_stats[pt_id].tx_dropped + stats.oerrors). > > Fixes: 53324971a14e ("app/testpmd: display/clear forwarding stats on demand") > Cc: stable@dpdk.org > > Reported-by: Joshua Washington > Signed-off-by: Ferruh Yigit Acked-by: Aman Singh > --- > > Cc: david.marchand@redhat.com > > Mail list reference: > https://inbox.dpdk.org/dev/a440ab60-9624-f21e-396a-239bdf2aa1a1@amd.com/ > ---