From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90674A04A4; Fri, 1 May 2020 00:18:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 345AA1DA66; Fri, 1 May 2020 00:18:28 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id E39F11DA02 for ; Fri, 1 May 2020 00:18:26 +0200 (CEST) IronPort-SDR: 9oQkPMI/qH+2Yf4PIfbNLNVWglVE9k1Ul+fWlQHT4vGBaIsdKIrdlPGf+4U8t4901pwLWzXkck 3QcZmIQda1XQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2020 15:18:25 -0700 IronPort-SDR: R1AeKTFzD8lOB7vVS1P7ea+/8n1n2/k0WgQ3iFamRtPW70k3LDfp+87kQhS3u6ObRCzkxFe4QZ JGMFBmevhrGg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,337,1583222400"; d="scan'208";a="293713778" Received: from pkadam-mobl1.amr.corp.intel.com (HELO [10.213.184.156]) ([10.213.184.156]) by fmsmga002.fm.intel.com with ESMTP; 30 Apr 2020 15:18:24 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, ranjit.menon@intel.com, Harini.Ramakrishnan@microsoft.com, Narcisa.Vasile@microsoft.com, dmitry.kozliuk@gmail.com, tbashar@mellanox.com References: <20200429232427.7112-1-pallavi.kadam@intel.com> <1680001.aGCPj5yezQ@thomas> From: "Kadam, Pallavi" Message-ID: <4ca29fce-f431-6d24-923d-d6a639e77c43@intel.com> Date: Thu, 30 Apr 2020 15:18:23 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <1680001.aGCPj5yezQ@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/2] Windows logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/29/2020 11:48 PM, Thomas Monjalon wrote: > 30/04/2020 01:24, Pallavi Kadam: >> This patchset adds EAL logging support on Windows. >> Logs will be sent to console output. >> >> Pallavi Kadam (2): >> eal: initialize eal logging on Windows >> eal: add fnmatch implementation on Windows > > fnmatch is required to change the log level of logs > specified with a globbing pattern. > > I think it would be nicer to introduce fnmatch first, > and state in the other patch that logging is supported on Windows. > > Titles would be: > eal/windows: add fnmatch implementation > log: support on Windows > > Ok, will interchange the sequence of the patches in v2. Thanks,