From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50A50A0471 for ; Fri, 16 Aug 2019 10:05:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 517B1378B; Fri, 16 Aug 2019 10:05:39 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 0B6A129D2 for ; Fri, 16 Aug 2019 10:05:38 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 957EC78006B; Fri, 16 Aug 2019 08:05:36 +0000 (UTC) Received: from [192.168.1.11] (85.187.13.152) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 16 Aug 2019 09:05:25 +0100 To: , , , John McNamara , "Marko Kovacevic" , Thomas Monjalon CC: References: <20190816055511.2322-1-pbhagavatula@marvell.com> <20190816055511.2322-4-pbhagavatula@marvell.com> From: Andrew Rybchenko Message-ID: <4ca361c2-c350-6888-e5c3-5d3454af35ab@solarflare.com> Date: Fri, 16 Aug 2019 11:05:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190816055511.2322-4-pbhagavatula@marvell.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [85.187.13.152] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24850.003 X-TM-AS-Result: No-9.948900-8.000000-10 X-TMASE-MatchedRID: hls5oAVArl8eimh1YYHcKPZvT2zYoYOwC/ExpXrHizyRoQLwUmtovzCW p18HPoW8SjVIFO5E44A8Lz/SCMJ/sjTHlbL9ZrD9IAjxomarSPDxuhkRWK22GJ+4ziUPq4LxIv1 5iK3UB+jB+XLylh073we6q5PK7+2HLgXLFIpsZZP9xyC38S1f/SIk3dpe5X+hB0L0/Ut7x1DK8V ygGkP/nHxs7qFZ9FbOj0IvV7jlqDhlTf++5Usob2pno6KlGnd6v8jdqvFOu+IL9Tj77wy87C2CA W3ky8WrqiwYwBfQ0nc9YOvVgQs+pa+/EguYor8cgxsfzkNRlfKx5amWK2anSPoLR4+zsDTtLa13 Fo3TPRYIq0v4AajkYNh3viyXdXFV15f5z0Pgk1zDFYCzbKCBV1Zca9RSYo/b X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--9.948900-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24850.003 X-MDID: 1565942737-0ogTozN5YcRg Subject: Re: [dpdk-dev] [PATCH 3/7] ethdev: add flow action type update as an offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/16/19 8:55 AM, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Add new Rx offload flag `DEV_RX_OFFLOAD_FLOW_MARK` that can be used to > enable/disable PMDs write to `rte_mbuf::hash::fdir::hi`. Notes similar to RSS hash. It requires better motivation why. It lets Rx queue know that it will be used as flow action MARK target and the queue should be configured to deliver the mark from NIC to PMD and processed in the driver. Also I think that flow API action MARK documentation should be updated to mentioned the offload. > Signed-off-by: Pavan Nikhilesh > --- > doc/guides/nics/features.rst | 12 ++++++++++++ > lib/librte_ethdev/rte_ethdev.h | 1 + > 2 files changed, 13 insertions(+) > > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst > index f79b69b38..d67430d90 100644 > --- a/doc/guides/nics/features.rst > +++ b/doc/guides/nics/features.rst > @@ -594,6 +594,18 @@ application to set ptypes it is interested in. > * **[provides] mbuf**: ``mbuf.packet_type``. > > > +.. _nic_features_flow_action_type_update: May be  _nic_features_flow_mark ? > + > +Flow type update May be "Flow mark delivery" ? > +---------------- > + > +Supports flow action type update to ``mbuf.ol_flags`` and ``mbuf.hash.fdir.hi``. > + > +* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_FLOW_TYPE``. DEV_RX_OFFLOAD_FLOW_MARK, not TYPE. > +* **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_FDIR``, ``mbuf.ol_flags:PKT_RX_FDIR_ID;``, > + ``mbuf.hash.fdir.hi`` > + > + > .. _nic_features_timesync: > > Timesync > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index 889486a11..4a0cff830 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1014,6 +1014,7 @@ struct rte_eth_conf { > #define DEV_RX_OFFLOAD_SCTP_CKSUM 0x00020000 > #define DEV_RX_OFFLOAD_OUTER_UDP_CKSUM 0x00040000 > #define DEV_RX_OFFLOAD_RSS_HASH 0x00080000 > +#define DEV_RX_OFFLOAD_FLOW_MARK 0x00100000 > > #define DEV_RX_OFFLOAD_CHECKSUM (DEV_RX_OFFLOAD_IPV4_CKSUM | \ > DEV_RX_OFFLOAD_UDP_CKSUM | \ Add to rte_rx_offload_names